Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE:(2) [PATCH v4 4/7] scsi: ufs: wb: Add explicit flush sysfs
 attribute
Reply-To: j-young.choi@samsung.com
Sender: Jinyoung CHOI <j-young.choi@samsung.com>
From:   Jinyoung CHOI <j-young.choi@samsung.com>
To:     ALIM AKHTAR <alim.akhtar@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <1f8e95da0c92f92937b5455a45430c939539d524.camel@gmail.com>
Message-ID: <20220728005403epcms2p35f6f6b0384aa05f44274445b52a89b68@epcms2p3>
Date:   Thu, 28 Jul 2022 09:54:03 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <1f8e95da0c92f92937b5455a45430c939539d524.camel@gmail.com>
        <20220727070724epcms2p8e449d0c89b52f03a9d3dc254df0ec547@epcms2p8>
        <20220727070410epcms2p5206785e4d960b32dcbb6729710dab535@epcms2p5>
        <20220727065904epcms2p60a7a56101785ddefa55c82b3cc25116d@epcms2p6>
        <20220727070841epcms2p5e212d617dd0f985555fa052f099013f0@epcms2p5>
        <CGME20220727065904epcms2p60a7a56101785ddefa55c82b3cc25116d@epcms2p3>
Precedence: bulk

>>=C2=A0There=C2=A0is=C2=A0the=C2=A0following=C2=A0quirk=C2=A0to=C2=A0bypas=
s=C2=A0=22WB=C2=A0Flush=22=C2=A0in=C2=A0Write=C2=A0Booster.=0D=0A>>=C2=A0=
=0D=0A>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0UFSHCI=
_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL=0D=0A>>=C2=A0=0D=0A>>=C2=A0If=C2=A0this=C2=
=A0quirk=C2=A0is=C2=A0not=C2=A0set,=C2=A0there=C2=A0is=C2=A0no=C2=A0knob=C2=
=A0that=C2=A0can=C2=A0control=C2=A0=22WB=0D=0A>>=C2=A0Flush=22.=0D=0A>=0D=
=0A>>=C2=A0=0D=0A>>=C2=A0There=C2=A0are=C2=A0three=C2=A0flags=C2=A0that=C2=
=A0control=C2=A0Write=C2=A0Booster=C2=A0Feature.=0D=0A>>=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A01.=C2=A0WB=C2=A0ON/OFF=0D=0A>>=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A02.=C2=A0WB=C2=A0Hibern=C2=A0Fl=
ush=C2=A0ON/OFF=C2=A0(implicitly)=0D=0A>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A03.=C2=A0WB=C2=A0Flush=C2=A0ON/OFF=C2=A0(explicit)=0D=
=0A>>=C2=A0=0D=0A>>=C2=A0The=C2=A0sysfs=C2=A0attribute=C2=A0that=C2=A0contr=
ols=C2=A0the=C2=A0WB=C2=A0was=C2=A0implemented.=C2=A0(1)=0D=0A>>=C2=A0=0D=
=0A>>=C2=A0In=C2=A0the=C2=A0case=C2=A0of=C2=A0=22Hibern=C2=A0Flush=22,=C2=
=A0it=C2=A0is=C2=A0always=C2=A0good=C2=A0to=C2=A0turn=C2=A0on.=0D=0A>>=C2=
=A0Control=C2=A0may=C2=A0not=C2=A0be=C2=A0required.=C2=A0(2)=0D=0A>>=C2=A0=
=0D=0A>>=C2=A0Finally,=C2=A0=22Flush=22=C2=A0may=C2=A0be=C2=A0necessary=C2=
=A0because=C2=A0the=C2=A0Auto-Hibern8=C2=A0is=C2=A0not=0D=0A>>=C2=A0support=
ed=C2=A0in=C2=A0a=C2=A0specific=C2=A0environment.=0D=0A>>=C2=A0So=C2=A0the=
=C2=A0sysfs=C2=A0attribute=C2=A0that=C2=A0controls=C2=A0this=C2=A0is=C2=A0n=
ecessary.=C2=A0(3)=0D=0A>>=C2=A0=0D=0A>>=C2=A0Reviewed-by:=C2=A0Avri=C2=A0A=
ltman=C2=A0<avri.altman=40wdc.com>=0D=0A>>=C2=A0Signed-off-by:=C2=A0Jinyoun=
g=C2=A0Choi=C2=A0<j-young.choi=40samsung.com>=0D=0A>>=C2=A0---=0D=0A>...=0D=
=0A>>=C2=A0=0D=0A>>=C2=A0+static=C2=A0ssize_t=C2=A0wb_buf_flush_en_store(st=
ruct=C2=A0device=C2=A0*dev,=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct=C2=A0device_attribute=C2=A0*attr,=
=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0const=C2=A0char=C2=A0*buf,=C2=A0size_t=C2=A0count)=0D=0A>>=C2=A0+=7B=
=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct=C2=A0ufs_hb=
a=C2=A0*hba=C2=A0=3D=C2=A0dev_get_drvdata(dev);=0D=0A>>=C2=A0+=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned=C2=A0int=C2=A0wb_buf_flush_en;=0D=0A=
>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ssize_t=C2=A0res;=0D=0A>=
>=C2=A0+=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if=C2=A0(u=
fshcd_is_wb_allowed(hba)=C2=A0&&=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=21(hba->quirks=C2=A0&=C2=A0UFSHCI_QUIRK_S=
KIP_MANUAL_WB_FLUSH_CTRL))=C2=A0=7B=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0dev_warn(=
dev,=C2=A0=22It=C2=A0is=C2=A0not=C2=A0allowed=C2=A0to=C2=A0configure=C2=A0W=
B=C2=A0buf=0D=0A>>=C2=A0flush=21=5Cn=22);=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ret=
urn=C2=A0-EOPNOTSUPP;=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=7D=0D=0A>>=C2=A0+=0D=0A>Hi=C2=A0J-young,=0D=0A>=0D=0A>I=C2=A0don't=C2=
=A0understand=C2=A0here,=C2=A0if=C2=A0UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTR=
L=C2=A0is=0D=0A>not=C2=A0set=C2=A0(manual=C2=A0flush=C2=A0is=C2=A0not=C2=A0=
disable),=C2=A0so=C2=A0we=C2=A0cannot=C2=A0manually=C2=A0flush=0D=0A>buffer=
?=C2=A0or=C2=A0should=C2=A0we=C2=A0check=C2=A0if=C2=A0Auto-Hibern8=C2=A0is=
=C2=A0supported?=0D=0A>=0D=0A>Kind=C2=A0regards,=0D=0A>Bean=0D=0A=0D=0AHi=
=20Bean,=20=0D=0AAs=20the=20patch=20was=20separated,=20the=20conditional=20=
sentence=20went=20wrong.=0D=0AThank=20you=20for=20checking.=20I=20will=20mo=
dify=20it=20quickly.=0D=0A=0D=0AThanks,=0D=0AJinyoung.