Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a899346-f9b1-dc3a-2da0-f3271c85327c@oracle.com>
Date:   Thu, 28 Jul 2022 10:51:59 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [RFC PATCH] mm/kfence: Introduce kernel parameter for selective
 usage of kfence.
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>, glider@google.com,
        elver@google.com, dvyukov@google.com, cl@linux.com,
        penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org, vbabka@suse.cz,
        roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, corbet@lwn.net
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        kasan-dev@googlegroups.com, linux-mm@kvack.org
References: <20220727234241.1423357-1-imran.f.khan@oracle.com>
 <08da326f-3fe4-3342-bce8-bbd94bf8be97@infradead.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <08da326f-3fe4-3342-bce8-bbd94bf8be97@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUpOak10MUh1Y1RSbzRwZlhwNGlSZ3lLZEthLzgwOW85UHNrbThUdDlmQUcv?=
 =?utf-8?B?T2Vkbm5MSDg3WmVDeHIySmROMUZFaENpUE5MbmJQMWpZMklyUjdUMVdDR0pT?=
 =?utf-8?B?bFFhcC9ORUZXQzFoa2NERFU4RTIvYytFL2Y3dkdoZHN3MjY5YkRNcXRHSXZu?=
 =?utf-8?B?U1hoVHdBemduU3VtblhGSGlvU0FNMWtVemVsRWpEdDBZa1UxZFJjQnY4ZnRa?=
 =?utf-8?B?UVhFMFBaSEtqM2V3TTFyTU5hYW9UdHYxU2x6dEl2eW1BZXoxQUV2R01SMFFz?=
 =?utf-8?B?ZW5QOXlvUk0vSWxDa3prUVNRZklNZ0sxRnA1Qis3WEwvQ1NPZDZ2OWFxQ1Yv?=
 =?utf-8?B?ZnFMNWVqQjFYY2d5U0pGbVkvV3lWS21iVFJJc3hMSUowaGF4dldhempGT2U0?=
 =?utf-8?B?SVJXWDAzc2ptVEtTWFI0Mk5MMENQVFNrVkZpWWd4angwKy9ZOVM5ZWlXTDFv?=
 =?utf-8?B?UGxBemNlSEp1c2JCVXNvZy9lMGdWbUxpQWhyMndwRWFSQ0ZRNlZxSS82VUFB?=
 =?utf-8?B?U2k0L21kNHJzL1F3SC95cXRHRjBrSHdKcHIyZVFIRTdWdW9WVGFJR3hJckYw?=
 =?utf-8?B?S3Z0ZGVSZEIxc3VBNmYxenc2d2pYUVJGT0JTTXViWjh2ZHluelEwQ0gxTGNF?=
 =?utf-8?B?MTZUTFI2NzhMTkh3VG5MVGtCbHhlb1FKc3k5ZW5VOHV3QlNSb1NRSVJBUVd1?=
 =?utf-8?B?enlGN1h6dmpYQTY2NHhNM3VSeVFsQUZsSHJ3T1YzQU9UbldwNURLblBQdjZu?=
 =?utf-8?B?TXVUOTZQSm1PTVlnME0xSTRHODNUWlMrSVpMK2loYVFqQ3V6bXB0SDE1ME92?=
 =?utf-8?B?Vzh0aGxEZUNqdVNyOCtabXVSbFpvVDN4bnQ1ZUtEUFlLUEx2YVpFNXIvS2Va?=
 =?utf-8?B?MFhpTmhTVVdySlAzQTFzSHpwd2dvZlZZSnFRSzVkdUF5RWZsS1g0SjJCVlht?=
 =?utf-8?B?RDd1T2YzYUcrLzFnR1BZbVZiSkJJQ3RPQnl4RVhGVmxycTh6ZTdVeEhDNkNk?=
 =?utf-8?B?OTNLOE9RbDlPNFpvQ252eDZmdE5qajdmREowbUhsM051SEdWNUxvMCtVelc3?=
 =?utf-8?B?M25XK0Q4VzdtZGpURi9ybEU0dXViVkZtUXhNd3V2SkhVMFdpcVF2TCtCNEwv?=
 =?utf-8?B?eWpFWlVseEpTamoraEF6TGJwUWtjaS9pM0tMYUpFd1FiQjd5UERmajRlWElt?=
 =?utf-8?B?MEwvWFhabG9nZlNmMHF1Y0JFTENDT1JNeUg1NmE5bEtQWitGZHlpNmhCdkMv?=
 =?utf-8?B?NWFselhDQ3g5RFFCcHA5Z2g2NmtialZ6SnRBMFFZOFdTWkF2dHBDWUNVZUla?=
 =?utf-8?B?cFg1cE5ra2FyWURmTG0wSThid0ptSEpwQmJMZ21RZUxpbEtYQndSa2ZiN2xD?=
 =?utf-8?B?QWZDamE1NEEzWUo0L3pRQXFmUzN6anBuZnN6WGgwVXFjeU5LNmZ4a2lTQlRN?=
 =?utf-8?B?MWJhbklXSk8zbTFiZ3lxR2x4T0ZMNVpQTE1iZHpRd2h3OS9sOGRBM2lBTm1D?=
 =?utf-8?B?djZWS1U5MmE0R3labUl6aHZuVnAxWHhBMTY1a1NYc2hza1ZXWmZTdWNYamI3?=
 =?utf-8?B?SlhOQUZlQmRyRlU5R2NLNzFBNjZaMzFrT0g2eW9xNXNUWTZSWm43WXE1R0Zw?=
 =?utf-8?B?emMzM1VpYW5xQitDc0wzVUd1Y05aWmcwQ0ZxNFlFSkMvUnByY3lycjR0dndL?=
 =?utf-8?B?ZEgwOTVoYTdsK2M2Y1c1TTFoU2lrQzUvVDV2bDROY2JZVFlnTlJPWG9oU2J5?=
 =?utf-8?B?VzZZNERMR3ZsREUvWHdYT2lrS09CYUZPanZCT200TVZiMmpmWGhlbXVUTVlz?=
 =?utf-8?B?QmppeWd4WjNDaitveTZxQnFpWC8zbFN4bjZsblh1WXJ5ZFFBUmFkeVVhbGNR?=
 =?utf-8?B?REpGaWlxTFNPTG56bUdwR3pIREhEc1cxcXUrYml4M3NJR2o5K1J5T1ovWnB2?=
 =?utf-8?B?UUFhNEErWU5BUlR4NGhxZHNPWWZpSjg0czN6VDJjVDRKV0QyTElJTE9IZGcz?=
 =?utf-8?B?VW5jRHBFUGF6cEJMWFNwaEMvb01hcDVJWUlWaVhPc1dDUkV4K3MxRDRpWU9B?=
 =?utf-8?B?eHpIVVdERmxsL25vS3Z4VzZOdmhTbG4vMHlWdjB4Qi9GN0VzS2dsV0FCdG4v?=
 =?utf-8?B?bjJNemxPTlJTMUowclB4NlpSNnl2QjRic0dkc280cnRQVThlODYyQmN0UGls?=
 =?utf-8?B?ZEE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f267262a-6fef-4f34-bf7d-08da703366a1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 00:52:09.7142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pH08+VlHAeK9RGLz6szC7nO2O3odiw0IV6YzE1KRG3wDipNAKgUzmew/W+VRM079e9WrajP0QXpp+3xmjqE4YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4710
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-27_08,2022-07-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 bulkscore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207280001
X-Proofpoint-GUID: xwuPV-5pFBTF588P0cOGqvWHh97VPG8A
X-Proofpoint-ORIG-GUID: xwuPV-5pFBTF588P0cOGqvWHh97VPG8A
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Randy,
Thanks for your review.

On 28/7/22 10:00 am, Randy Dunlap wrote:
> Hi--
> 
> On 7/27/22 16:42, Imran Khan wrote:
>> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
>> index 98e5cb91faab..d66f555df7ba 100644
>> --- a/Documentation/admin-guide/kernel-parameters.txt
>> +++ b/Documentation/admin-guide/kernel-parameters.txt
>> @@ -5553,6 +5553,11 @@
>>  			last alloc / free. For more information see
>>  			Documentation/mm/slub.rst.
>>  
>> +	slub_kfence[=slabs][,slabs]]...]	[MM, SLUB]
> 
> I suppose that 'slabs' are by name?
> How can the names be found?  via 'slabinfo -l' or 'ls /sys/kernel/slab/' ?
> 
> 
Yes 'slabs' are by name and names can be obtained from slabinfo or sysfs or
using kmem -s on a vmcore. As it is a boot time option user needs to be aware of
slab name just like when someone uses slub_debug.

> It seems to me that the boot option should be listed as s/slabs/slab/.
> I.e., one uses 'comma' to list multiple slabs.
> Or is there a way for multiple slabs to be entered without commas?
> 

Yes, 'slabs' is a typo above, it should be 'slab'. The name of the slabs will be
specified as a comma separated list for example:
slub_kfence=kmalloc-*,dentry,task_struct.

I will make s/slabs/slab change in next version once I have gathered some more
feedbacks.

thanks
-- Imran