Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp149205imn; Wed, 27 Jul 2022 18:15:57 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tLgKpzdUdeC0ktRVmOtCl0meCh+UHy3nFvIDEp1RP8MM+wpe8FeEorPdeMB9VUauEnsDjs X-Received: by 2002:a05:6402:84a:b0:423:fe99:8c53 with SMTP id b10-20020a056402084a00b00423fe998c53mr26425632edz.195.1658970957601; Wed, 27 Jul 2022 18:15:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658970957; cv=none; d=google.com; s=arc-20160816; b=gjcgl+IlVdJjNtadwXMaS8ll3e/PYp5TrXpEubXHz0GEPekNI3H5oGe0tSOKOGHawE Kn0YKTn5969oylhjAS7ZzkKSuNC5PyY7/zs2oLVW0QLGcV/N2PgjboUFe3Pn5HOUFEMw 1UxBqruW6bBpibAyOQlnLg9yJ2glI3kTcyFmgUeUhU+qFAw/S6rQjdxJfj0C9Z6VYdYJ W13USHTzRyn8SH57v91BRTOJZY9kJz3Wu97ZQioSog1DoAThmn55Xrzg1T2U5e5zK0v4 0rp2CJ6kFpIpryxrzcO1pGvObMVnO942F2Po0gxYub5rJ4mDK5sQYgqopNFe9iX6PPFz WPpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=IDcJE7OjPz6fXvQppFNOy2ulIl8uBgFJWr9d+OYuu2I=; b=OGiUZXBuGHoJijmYzv++VEH1YkrvGbLsqF8yxYCKdnLvTzM5zlqUZQcnA5OID6e0Xt NDfMlNQMH0O9l9ekgaI8LGxZWjUYgdrrxYEKmEigFhLBooYFiGJ3JbV+fZvEcVd6fLKk NzN/rbLMfK2+E0w8uKYtgfA16eudENz58DaKOwk15exO7fa97NCWGt0Lq57BwHv+2n/o ovELbe0Ykw5NF8Dr0Vp6qDABdzPumeAzPKi3jrXKnpgsP+e2ZdZJKtc1Bow30IuXrasf BXFTNkpZAA0hvOQ0QvwXevnq+xnxFWBuhgOHp+grPtxp11ShDszvVfeHvo6PRArElHat 4AEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nlqaAET4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn21-20020a1709070d1500b007123c7ecf90si21997213ejc.476.2022.07.27.18.15.11; Wed, 27 Jul 2022 18:15:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nlqaAET4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236086AbiG1Ab7 (ORCPT + 99 others); Wed, 27 Jul 2022 20:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiG1Ab6 (ORCPT ); Wed, 27 Jul 2022 20:31:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D81EE54CA0; Wed, 27 Jul 2022 17:31:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 75B23B8229F; Thu, 28 Jul 2022 00:31:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22D28C433D6; Thu, 28 Jul 2022 00:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658968315; bh=cgMax9nf9qW48JMtAkUoIyip26M7Bpa8V5h47PbKfC4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=nlqaAET4ci75hpEpVFTfRPIEF2htScl2LXIAlqXintsUaUKetcCiPAzb42chVmnkB wKr9EwczFt7JxVVho5QiYakPC+GtoRtP4t0rfUVwGo9Fslccl0m+4xx7uQrCsgmCTm DO7IySLE7/4lrN2Wbug+uNmq4hEj2qUCKYShnJduTcyRX+nB26mLun1a4MxFjOqyJ1 f2wI2hMWzsu0AaZVl7XYyzu8ulkz9VwMj5klckTi/1Y0zHSSkpKf/rEdKtDtWEXpkd VpwhUErr0IIXtuOyfLAJvhkyLkJGvvPVMm6yRSH/RtCPQnAFIrj9KScMWnH2Stkk5W Rj4PZYLvujSxA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220714203822.186448-1-marijn.suijten@somainline.org> References: <20220714203822.186448-1-marijn.suijten@somainline.org> Subject: Re: [PATCH] clk: qcom: gcc-sdm660: Use floor ops for SDCC1 clock From: Stephen Boyd Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Marijn Suijten , Andy Gross , Bjorn Andersson , Michael Turquette , Taniya Das , Rob Herring , Craig Tatlor , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Marijn Suijten , phone-devel@vger.kernel.org Date: Wed, 27 Jul 2022 17:31:53 -0700 User-Agent: alot/0.10 Message-Id: <20220728003155.22D28C433D6@smtp.kernel.org> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marijn Suijten (2022-07-14 13:38:22) > In commit 3f905469c8ce ("clk: qcom: gcc: Use floor ops for SDCC clocks") > floor ops were applied to SDCC2 only, but flooring is also required on > the SDCC1 apps clock which is used by the eMMC card on Sony's Nile > platform, and otherwise result in the typicial "Card appears > overclocked" warnings observed on many other platforms before: >=20 > mmc0: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz > mmc0: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz > mmc0: Card appears overclocked; req 104000000 Hz, actual 192000000 Hz >=20 > Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver= for SDM660") > Signed-off-by: Marijn Suijten > --- Reviewed-by: Stephen Boyd