Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mm/folio-compact: fix potential NULL pointer in
 pagecache_get_page
To:     William Kucharski <william.kucharski@oracle.com>
CC:     Matthew Wilcox <willy@infradead.org>,
        "dhowells@redhat.com" <dhowells@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "zhangxiaoxu5@huawei.com" <zhangxiaoxu5@huawei.com>,
        "yanaijie@huawei.com" <yanaijie@huawei.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>
References: <20220727064621.534528-1-liuyongqiang13@huawei.com>
 <B92F20D6-595A-4B7F-95CA-7C681C2AF79D@oracle.com>
From:   Yongqiang Liu <liuyongqiang13@huawei.com>
Message-ID: <3e80debb-eb34-75ed-6c12-feb072e42546@huawei.com>
Date:   Thu, 28 Jul 2022 09:36:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <B92F20D6-595A-4B7F-95CA-7C681C2AF79D@oracle.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Understood, thanks for your explanation :)

?? 2022/7/27 19:40, William Kucharski д??:
> This isn't a NULL pointer dereference; returning &(0->page) is completely legal
> as was discussed regarding this exact code back in April:
>
> https://lore.kernel.org/lkml/YmfgqKcMmstgfz+0@casper.infradead.org/
>
>> On Jul 27, 2022, at 12:46 AM, Yongqiang Liu <liuyongqiang13@huawei.com> wrote:
>>
>> When __filemap_get_folio() failed and returned NULL, we would
>> get a NULL pointer dereference in pagecache_get_page.
>>
>> Fixes: 3f0c6a07fee6 ("mm/filemap: Add filemap_get_folio")
>> Signed-off-by: Yongqiang Liu <liuyongqiang13@huawei.com>
>> Cc: <stable@vger.kernel.org> # 5.16
>> ---
>> mm/folio-compat.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/folio-compat.c b/mm/folio-compat.c
>> index 20bc15b57d93..7b21393480e0 100644
>> --- a/mm/folio-compat.c
>> +++ b/mm/folio-compat.c
>> @@ -124,7 +124,9 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index,
>> struct folio *folio;
>>
>> folio = __filemap_get_folio(mapping, index, fgp_flags, gfp);
>> - if ((fgp_flags & FGP_HEAD) || !folio || xa_is_value(folio))
>> + if (!folio)
>> + return NULL;
>> + if ((fgp_flags & FGP_HEAD) || xa_is_value(folio))
>> return &folio->page;
>> return folio_file_page(folio, index);
>> }
>> -- 
>> 2.25.1
>>
>>
> .