Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp172300imn; Wed, 27 Jul 2022 19:08:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uOHn33yhvdTYzik8x5Ct0iQ5uRXmxoJcpOjt5At6iBvnzc/NrRgYCnYkaMbwe7+eYCPVN1 X-Received: by 2002:a17:907:7243:b0:72f:21d7:d122 with SMTP id ds3-20020a170907724300b0072f21d7d122mr19909984ejc.271.1658974095170; Wed, 27 Jul 2022 19:08:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658974095; cv=none; d=google.com; s=arc-20160816; b=qL8BVR4WQHfsHi2gnYbvMtwHr4FX9iUoqcyS5POcaPiwBrN7XXec6Rk5Wu0rs+dzlA TfBfAJ4gAQr+WuthvGOZPPnn8i3l6yRapVwpQQis5k6dBYvUJRKq64RSpANnDet6op0L dbHuxhuoz0JzDCYI/FaDIu0+BbqcihCm5IqxFP3qzS4gk4EaFImYL+InS/S5ELN9lpAT Cl5AyNcxyyOMkdJQlPSmPpAGkd5ScMXWQlLBq4Rfgsjf6wgi8KzPWLcJpZ9hKudX0nyH EtKZqoT8imC2qxMdaEXF8aPF4KptptX1hSYYIy8DuMtmAuUJtazlPd2G46G18mwxHFcl GgRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nlR2CtQneTjkaKEuU9Yu8TJ6XvBnVcJP6XjuDMSl7dU=; b=lNPobJBNQSyU8NlNnacC+s2LShkw20Gi+GtmkDiwRioNtzAsNxtLJo3x5XToAVYXo8 JrAhUTbVr44FGbaWHp77J/x0TPE/JD07pmSPaIRisJxOTkAapIOFnCdouO2Qdl/3l9Zw H0oFJTpM0M6KAgYRkp+n3HCFjUpNd8d1jojBMq8uM/SxQMjgEgccF8sSXgbPCBsdajyR TdMycnO/4GWPnhfeRg1vje1cunXMy/FWgxb+9woXVWYd1aXFOmTWIaS/cOLFrOClm7aS f7tbJGF3ZnEgDyHmd5SsUIOGX+8Knut/NW6mKbOygx+Mmpb/jMF3Ni8cQKlp0bItz9lS jRrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dNCsZuXF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht22-20020a170907609600b00722f74fff57si21381640ejc.313.2022.07.27.19.07.50; Wed, 27 Jul 2022 19:08:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dNCsZuXF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235484AbiG1Bg6 (ORCPT + 99 others); Wed, 27 Jul 2022 21:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiG1Bgz (ORCPT ); Wed, 27 Jul 2022 21:36:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 664194D81C; Wed, 27 Jul 2022 18:36:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 06813B8224E; Thu, 28 Jul 2022 01:36:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AD37C433C1; Thu, 28 Jul 2022 01:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658972208; bh=DnonMiuWXIiuzZDXL8pNnHlEBP04K89tqhUudaTWyW4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dNCsZuXFlDoDjpOHeM3xi6E8xS9DNsogbnl15CBPmj7ogMT7BmE0UR54KlN6yJ6EX GhEB/jVRpViOcoVlRVjkNgyK03DeMJ87yZxrLPbCcIpPkKnBqN2D/wreTzQVd8e0MO cmV7Q3EzBCLPzZT6zI/3ghxQkEsH4xwRuk8+40sRDs3n5Aux2FkoNH/4nPvQyqDyRP 1Mi8kCO7CinKNrt6zeRYs0zluWjr1q5YUwG0/SeuY6O8W6duObF5l67FhXLKlURpPJ myGZC29GJ+ZTLhUJJeIBj0U6hCE8OPwEAYSxUEsl3V9miv2dGnNUktfMJIqP8ibyM+ JdeacHjPn9qtQ== Date: Wed, 27 Jul 2022 18:36:47 -0700 From: Jakub Kicinski To: Duoming Zhou Cc: linux-hams@vger.kernel.org, ralf@linux-mips.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] netrom: fix sleep in atomic context bugs in timer handlers Message-ID: <20220727183647.23ae46f8@kernel.org> In-Reply-To: <20220726032420.5516-1-duoming@zju.edu.cn> References: <20220726032420.5516-1-duoming@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jul 2022 11:24:20 +0800 Duoming Zhou wrote: > nr_heartbeat_expiry > nr_write_internal > nr_transmit_buffer void nr_transmit_buffer(struct sock *sk, struct sk_buff *skb) { [...] if (!nr_route_frame(skb, NULL)) { > nr_route_frame int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25) { [...] if (ax25 != NULL) { ret = nr_add_node(nr_src, "", &ax25->dest_addr, ax25->digipeat, ax25 must be NULL on this path AFAICT. > nr_add_node > kmemdup(..,GFP_KERNEL) //may sleep