Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: Re: [PATCH 1/9] trinity: Add base driver
Reply-To: myungjoo.ham@samsung.com
Sender: MyungJoo Ham <myungjoo.ham@samsung.com>
From:   MyungJoo Ham <myungjoo.ham@samsung.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Jiho Chu <jiho.chu@samsung.com>
CC:     "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yelin Jeong <yelini.jeong@samsung.com>
In-Reply-To: <YuE8JNjIBNdg/kkX@kroah.com>
Message-ID: <20220728020543epcms1p22f45bba0006bb9fcf04d697d9a2d5ec2@epcms1p2>
Date:   Thu, 28 Jul 2022 11:05:43 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <YuE8JNjIBNdg/kkX@kroah.com>
        <20220725065308.2457024-1-jiho.chu@samsung.com>
        <20220725065308.2457024-2-jiho.chu@samsung.com>
        <CGME20220725065309epcas1p4565e7bb0fea1aaf3e5e300de00774c2a@epcms1p2>
Precedence: bulk

> 
> > +	help
> > +	  Select this option to enable driver support for Samsung
> > +	  Neural Processing Unit (NPU).
> > +
> > +	  This driver works as a base driver of the other drivers
> > +	  for Trinity device family.
> > +
> > +	  This option should be enabled to support Trinity
> > +	  Vision 2 (TRIV2), and Trinity Audio (TRIA).
> > +
> > +config TRINITY_VISION2
> > +	tristate "Samsung NPU Trinity Vision 2"
> 
> What happened to "vision 1"?

It's designed before Vision 1, but its products are still not yet
released. The two have different target neural networks.

> 
> > +	depends on TRINITY
> > +	default n
> > +	help
> > +	  Select this option to enable driver support for a Samsung
> > +	  Neural Processing Unit (NPU), Tinity Vision 2.
> > +
> > +	  This driver enables userspace system library to access the
> > +	  device via /dev/triv2-N.
> 
> What is the module name?
> 
> Where is the userspace library code that talks to this?  Any
> documentation for this interface anywhere?
> 

I believe Jiho will provide documents soon; however, the userspace
library code is at
https://git.tizen.org/cgit/platform/adaptation/npu/trix-engine/
, which is shipped with 2022 TVs.

Cheers,
MyungJoo