Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp180695imn; Wed, 27 Jul 2022 19:28:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vLcZyRzTXcolwxM9XVFL0Hefypv9L3BbjTgvRMTzmm1OaezqiGJhRXnTQOpiiTEbNbFnk2 X-Received: by 2002:a17:90b:1c08:b0:1f2:19da:aa04 with SMTP id oc8-20020a17090b1c0800b001f219daaa04mr8063902pjb.90.1658975326494; Wed, 27 Jul 2022 19:28:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658975326; cv=none; d=google.com; s=arc-20160816; b=lUTCQShUOW/FtDlkgzWsHXeP7CCD7+u9R7XO+jYlqxbQjeIxgKb0uh/9eKwrxI0FmW tyGLt3XPqv8rRL51Nf6lJ+VMcj9KzVkDYlklTe1IEYSS+MUHBmo9vbP3o6V8aOu3m+L5 HnCr6oEvFG3zzMqtp6zsnhX18Z1/D4zIdOcrMnKX6nWA/IbKJCxTQpGp2mgo24cqBp+9 Ukb7vgWzsQEPp/lx+k2e83WZjxwb5tNgybh7uxzHugcq0mplq5i3tpOv8AcKtvWYz1nI fbzJmtTZqHsRvcG8i5DlU+QHxQQH+Vfzxll8HD9lfZoQQXPqc1eB5fE47vzlV+6E/0+X Itww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=JBOF5GKHt+oYtQp8FtJ3P7wau3LJcG5KQ6nxvYP6g3Y=; b=FANAAYBH424Qo83avwAR53QiW8wxYZ7u1CKurzO4ieVrbfu3sD4tGLeHFERK/Ur6V7 Ac8+zxIxUjGR8qfp0i51uXhDfWkTafFGEIVN6hl9PbmUQjcJcH1goEEzUvSKW+kq2UME sqUBHzpSPgJTmOBUE8S67Ny+SmH2JcvEVg9uewdHOfxb6ll4njxhTPur0b32EIo097JA 7+YPn7uquaOJirSzNVUo73StZFlCkqOJwK0TzjFfll0Lw0a4+xWDQUFofusSxfcm8uvY Fwjz4mm+32vVdXFMNioqJU6bvZC05OqBvUUxPj7MQcyH3aw1ACn+DGD2v8DeGHd6IidH 4/hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mhQM00jT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p14-20020a170902780e00b0016be96cf31bsi20758054pll.273.2022.07.27.19.28.31; Wed, 27 Jul 2022 19:28:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mhQM00jT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235685AbiG1CFR (ORCPT + 99 others); Wed, 27 Jul 2022 22:05:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234232AbiG1CFP (ORCPT ); Wed, 27 Jul 2022 22:05:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADA9622B13; Wed, 27 Jul 2022 19:05:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1155061871; Thu, 28 Jul 2022 02:05:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2996EC433D6; Thu, 28 Jul 2022 02:05:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658973912; bh=zxAKqmDeRgvh0LUTcg21PJ4FKLkJ74pWTcnTnUAl92Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mhQM00jTzuSpHfXb4wQ/CqjEsZAhMkVaV/YZBeJNXHT9hTmBuc0PwSl4HUHGO98U3 qbDLVZ7R4FqiZRgLP8+Tj/mEahMK/x/o+5PdACpxTByTcRGR3+dXxvtAuJXHMRFhUi nABawSHdGdbZ8TZxOWZQsA+cXu7muQJT2VDNLIEg9AU+K4J/gdK4Xj4tqriwLSPaiE W69sbSsE1ZqQewNtk6Gg7HxjiqIFJYmdwBGLXVeWS3LvoAQAwJNsO9vyrrvmEtAeeD Ws46dXFdCewXSbo8tR3PV2Y75oUaR/kQa1Pmwav3AYW6JyxVeE5MDJ6ru7ZUapVIL2 4QvKQQllZGw6A== Date: Wed, 27 Jul 2022 19:05:11 -0700 From: Jakub Kicinski To: Yang Li Cc: borisp@nvidia.com, john.fastabend@gmail.com, davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH -next] tls: rx: Fix unsigned comparison with less than zero Message-ID: <20220727190511.08f4fe0c@kernel.org> In-Reply-To: <20220728011025.10865-1-yang.lee@linux.alibaba.com> References: <20220728011025.10865-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Jul 2022 09:10:25 +0800 Yang Li wrote: > struct tls_strparser *strp = (struct tls_strparser *)desc->arg.data; > - size_t sz, len, chunk; > + int sz; > + size_t len, chunk; > struct sk_buff *skb; > skb_frag_t *frag; Thanks for the fix, please keep the sorting of the variable lines from longest to shortest. "int sz;" should be the last variable declaration line and "size_t len, chunk;" goes after the skb.