Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933306AbXFEWQK (ORCPT ); Tue, 5 Jun 2007 18:16:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762919AbXFEWP5 (ORCPT ); Tue, 5 Jun 2007 18:15:57 -0400 Received: from gate.crashing.org ([63.228.1.57]:55887 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762672AbXFEWP4 (ORCPT ); Tue, 5 Jun 2007 18:15:56 -0400 Subject: Re: [PATCH/RFC] signal races/bugs, losing TIF_SIGPENDING and other woes From: Benjamin Herrenschmidt To: Davide Libenzi Cc: Linus Torvalds , Linux Kernel list , Andrew Morton , Paul Mackerras In-Reply-To: References: <1181006711.31677.97.camel@localhost.localdomain> <1181009413.31677.117.camel@localhost.localdomain> Content-Type: text/plain Date: Wed, 06 Jun 2007 08:15:20 +1000 Message-Id: <1181081720.31677.144.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 21 On Tue, 2007-06-05 at 08:52 -0700, Davide Libenzi wrote: > if (tsk == current) > recalc_sigpending(); > > What can happen, is that a task may notice TIF_SIGPENDING and not find > a > signal once it calls dequeue_signal(), but this is fine as far as > signalfd > goes. This should be OK in general, no? What about the code in __dequeue_signal though ? That notifier thing is used by the DRI though I'm not sure what would happen if it acts on the wrong task. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/