Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: syUwQdck2bNxXKWL70MfHNr2Qlhi+RJMa0LNmbSZY4ed+Kz34Yb2THC2RcJs/YHRhjkI5k+uVD
 3PMTLGsJVFS2CDfEjMsnbJiN/6tvhFekB5P2/LPbd9OCNOIdkRPQqVfh+DJdvs8lFAGkQ+9jGU
 bGEJhlFaQq4E3W36XXGxrQ6KOqedHY0o5mId0mSEyCQlFx1qJzrsUTq5m4qP0USLAJBFA7gpwQ
 aksEqd6/h+p6jENfBcQOeLJ1nJotPSPXmRm4jVO7J4LmYixVCfrhjSm8m+uK3PZR6BTClNnw1J
 5vOtZ1x/N7XjAKoC16WEkC08
IronPort-SDR: 5uvtx0rz6GCFCovOurt6Kgxu7AtiG2yTxG6QsQkAMyRPSa9FKnUK26wvcaraqR0SOc990LwZL/
 7CyNld950geVb3vYoasCq0LXYdqNv6+T5aZzkaoIIuTUEXf2FTYo3xEqeKUPwZ5ZzNjnIfAG4V
 2tn2oFosCPJyEE2hLfHzwm6TK+3I1zb+M2T0yx7Oeq8df47NUK8sQBcoxxZRZ9V59Auef+hY8F
 L+Kzv5b9dyl6R0sKunM2fN3pTsfAi76E/mMma7JCPjxysEwRtjC46FTGLvzwAEFf2dXMPcMtey
 PXk=
WDCIronportException: Internal
Message-ID: <63350fdc-9cc8-3034-c8d6-8dcff50780f4@opensource.wdc.com>
Date:   Thu, 28 Jul 2022 12:20:28 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v8 08/11] dm-zone: use generic helpers to calculate offset
 from zone start
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, hch@lst.de, axboe@kernel.dk,
        snitzer@kernel.org, Johannes.Thumshirn@wdc.com
Cc:     matias.bjorling@wdc.com, gost.dev@samsung.com,
        linux-kernel@vger.kernel.org, hare@suse.de,
        linux-block@vger.kernel.org, pankydev8@gmail.com,
        bvanassche@acm.org, jaegeuk@kernel.org, dm-devel@redhat.com,
        linux-nvme@lists.infradead.org,
        Luis Chamberlain <mcgrof@kernel.org>
References: <20220727162245.209794-1-p.raghav@samsung.com>
 <CGME20220727162254eucas1p1fd990f746d9f9870b8d58ee0bd01fedd@eucas1p1.samsung.com>
 <20220727162245.209794-9-p.raghav@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220727162245.209794-9-p.raghav@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/28/22 01:22, Pankaj Raghav wrote:
> Use the bdev_offset_from_zone_start() helper function to calculate
> the offset from zone start instead of using power of 2 based
> calculation.
> 
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  drivers/md/dm-zone.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c
> index 3dafc0e8b7a9..31c16aafdbfc 100644
> --- a/drivers/md/dm-zone.c
> +++ b/drivers/md/dm-zone.c
> @@ -390,7 +390,9 @@ static bool dm_zone_map_bio_begin(struct mapped_device *md,
>  	case REQ_OP_WRITE_ZEROES:
>  	case REQ_OP_WRITE:
>  		/* Writes must be aligned to the zone write pointer */
> -		if ((clone->bi_iter.bi_sector & (zsectors - 1)) != zwp_offset)
> +		if ((bdev_offset_from_zone_start(md->disk->part0,
> +						 clone->bi_iter.bi_sector)) != zwp_offset)
> +
>  			return false;
>  		break;
>  	case REQ_OP_ZONE_APPEND:
> @@ -602,11 +604,8 @@ void dm_zone_endio(struct dm_io *io, struct bio *clone)
>  		 */
>  		if (clone->bi_status == BLK_STS_OK &&
>  		    bio_op(clone) == REQ_OP_ZONE_APPEND) {
> -			sector_t mask =
> -				(sector_t)bdev_zone_sectors(disk->part0) - 1;
> -
>  			orig_bio->bi_iter.bi_sector +=
> -				clone->bi_iter.bi_sector & mask;
> +				bdev_offset_from_zone_start(disk->part0, clone->bi_iter.bi_sector);
>  		}
>  
>  		return;


-- 
Damien Le Moal
Western Digital Research