Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     Baolu Lu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        "Zhu, Tony" <tony.zhu@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jean-Philippe Brucker" <jean-philippe@linaro.org>
Subject: RE: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu
 interface
Thread-Topic: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu
 interface
Thread-Index: AQHYkC3GvF//WyZOvUaTLdl04LC2Cq2MG8sAgAEavgCAAhH3gIABB5EAgAB+1ACAANqooIAAlRyAgAD5zPA=
Date:   Thu, 28 Jul 2022 03:06:47 +0000
Message-ID: <BN9PR11MB52766C3D37FA985DEBDC30C78C969@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220705050710.2887204-1-baolu.lu@linux.intel.com>
 <20220705050710.2887204-5-baolu.lu@linux.intel.com>
 <20220723141118.GD79279@nvidia.com>
 <686b137f-232a-2a78-beb0-e4373bd20959@linux.intel.com>
 <20220725144005.GE3747@nvidia.com>
 <6da27a6b-b580-4ba4-24c8-ebdfb2d9345d@linux.intel.com>
 <20220726135722.GC4438@nvidia.com>
 <BN9PR11MB5276974ABA5981A7361953708C979@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20220727115339.GM4438@nvidia.com>
In-Reply-To: <20220727115339.GM4438@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c3vAGjOVXK0XjIx1t4JTCIOjN9jQDRR6DfdI39/oPSo5+/KJwBT8PHXFVnqB?=
 =?us-ascii?Q?RGgwUbpPkBUuXDlDjvek9nQnL8xICIDVosPJvbx31R8B/nnbwKg8W4AetepM?=
 =?us-ascii?Q?VcBYeVx1pzIb5c4leDHhFBCZsOQDsSrNMcyLn46hUxi0J7nj0uxbk1lhfsQE?=
 =?us-ascii?Q?wQ277rO/M4mCWd6KOOCQj1qJivx8LxdEd9gnkV+4zaG2/hKeS1X7zq7ufQPb?=
 =?us-ascii?Q?sPSX0HXquvpzdktQ6m98LPVC57TaJNcpxUgYP1FLqIN5k1z3ZM0WLbDOvrH3?=
 =?us-ascii?Q?7pNu1kqRy7pM9tgW63/82ftMMGo2tuZKdQIPgvFcB5gAsWGbFNh+tJ1RQKEk?=
 =?us-ascii?Q?bbV/9MJUTPifPjwdokEdQGTtlPpcJjGCo7EGJOiRAaeIDcRFfSFxKokDl/iv?=
 =?us-ascii?Q?l+s1dQT7TXqDEsO7L+TNpfxmjvTZ3PEiyQx8zYrd9cMO+Jt2inc052jNXomR?=
 =?us-ascii?Q?n9bEJj9fsXEK9f86GW/jG4MVzeOkfm/wyVIUfezJSNbr1IsXLdzz4tCHuBi/?=
 =?us-ascii?Q?xaPc02G9PfwE1ew0ENwiI0k0VMFyituNZtOlkCowKrs7UZgkS7+XH7YkFmsA?=
 =?us-ascii?Q?4/yfoF4dt7j+8BfBLejH3xK0N7vwd9g63BYqlKA9M0wBIulwerDWxZQwInHp?=
 =?us-ascii?Q?pA4nbBDppUzz1PTuPztmAlaSxOAOCUCLn578mvAzL0MGkNIGXTVk9Q2oDqla?=
 =?us-ascii?Q?THFXgqZCeOimGL4KIvxt/LwESR6K/WSc4HTQo091sVVeO5ouq4+9aqexGy8r?=
 =?us-ascii?Q?brBehSG9R5kaZRe2L+hZZFxHhE2QFjZ7d4sYVkNoQpGzU/GUFqhSpe+/HAiQ?=
 =?us-ascii?Q?erbgSICbr28azPw6vZaN7YnyZZF51E8i+tTS3b9SiBdRDu/KFQLUHmTirIlJ?=
 =?us-ascii?Q?yoY/Yz0M9fWYv29w/TL9BLug1Z6bWduGr+HLTCRMD+i4kvBVOkjv9+sel5oe?=
 =?us-ascii?Q?Oihaf+wP6PANjdiKHYtWPDXOoiYjgbkgmB9xK1fscwtMn66EMBea6HMzRI7N?=
 =?us-ascii?Q?MpdjZ4U9PHtv3fHKsJBgmuhyf0HCmktWRGScSp59dp0pk448fyvpj1F0rHPl?=
 =?us-ascii?Q?mmtFLKFAs0G3o0HjsncpBerayJrA8ZCBDQztMBCHjeHjrEYvfwb3s44ARj4t?=
 =?us-ascii?Q?NCeizJfn7mEYsJj5Y78gGNGb45svXwQN106+/LNCQ5SaG1eQ3zKMu+8LEbWh?=
 =?us-ascii?Q?iGYExfWtfxerfcIxYTpYM6JXbLZMWcC90HhIeVasYTAWyry6UWYs2Y/ABJI1?=
 =?us-ascii?Q?IqmtlwdC67YZJIv1HU341mqtoeKejqi2vd0vNoErDZrxC3h0uWl156wh+dHQ?=
 =?us-ascii?Q?V8YXjy0wcb3ml9M0cA53I4oW9BAWw0X55FaXg98YvH3ogL8kl1DfT6jNBc9I?=
 =?us-ascii?Q?kZRsGfyoitxjACvXw/rAlrrV8VrI9JoH+wbFNRK79elzoAHWCZEl71QPKTW7?=
 =?us-ascii?Q?AJr0HyU3OkrGFoYFi5NGxgsX7WOBpL1Vi9x3U6OrFlqgmDHYY87dpaTkYwR/?=
 =?us-ascii?Q?pzvRzaaAQyNEti6EZYoKafclpWg+ukIhmrpjCIU02E+7dnA4bBVw0gPejXeb?=
 =?us-ascii?Q?N14/2rQi7Ks8Gg4EDIjawoPWHiAIkw5Q7AyEWRsp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c75f3671-84a9-4cf7-6b33-08da70463582
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 03:06:47.3795
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KcpuqboWUUW78uZIyx730rx4cS4xu2aUwQ7jj16wDqQ+vdPIMW/aDW+5edc9/jFIJtUX7ag4p/05IEwrI3crkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3315
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Wednesday, July 27, 2022 7:54 PM
>=20
> On Wed, Jul 27, 2022 at 03:20:25AM +0000, Tian, Kevin wrote:
> > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > Sent: Tuesday, July 26, 2022 9:57 PM
> > >
> > > On Tue, Jul 26, 2022 at 02:23:26PM +0800, Baolu Lu wrote:
> > > > On 2022/7/25 22:40, Jason Gunthorpe wrote:
> > > > > On Sun, Jul 24, 2022 at 03:03:16PM +0800, Baolu Lu wrote:
> > > > >
> > > > +	 * Block PASID attachment in all cases where the PCI fabric is
> > > > +	 * routing based on address. ACS disables it.
> > > > +	 */
> > > > +	if (dev_is_pci(dev) &&
> > > > +	    !pci_acs_path_enabled(to_pci_dev(dev), NULL, REQ_ACS_FLAGS))
> > > > +		return -ENODEV;
> > >
> > > I would probably still put this in a function just to be clear, and
> > > probably even a PCI layer funcion 'pci_is_pasid_supported' that
> > > clearly indicates that the fabric path can route a PASID packet
> > > without mis-routing it.
> >
> > But there is no single line in above check related to PASID...
>=20
> The question to answer here is if the device/fabric supports PASID,
> and on PCI that requires ACS on any switches. IMHO that is a PCI layer
> question and perhaps we shouldn't even succeed pci_enable_pasid() if
> ACS isn't on.

Yes, this sounds a better approach than inventing another function
for iommu core to check.

>=20
> Then we don't need this weirdo check in the core iommu code at all.
>=20

and then we could also move group->pasid_array to device->pasid_array
with this approach. Though the end result doesn't change i.e. still only
the singleton group can enable pasid the iommu core can just stick to
the device manner now.