Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp211021imn; Wed, 27 Jul 2022 20:45:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1swwy6O0bDvzJfuhouh1BuQI4wvjuAbjKkp6mMBW7NaGsV/xcZq7HLy2tSE3LoESsLeZ+M9 X-Received: by 2002:a17:902:cf09:b0:16d:6a06:f994 with SMTP id i9-20020a170902cf0900b0016d6a06f994mr19005229plg.62.1658979942697; Wed, 27 Jul 2022 20:45:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658979942; cv=none; d=google.com; s=arc-20160816; b=j1rZBAWR1tnnugjbcRwsyQFaZYyUuXfbs9j8B/1rf2nsW2Gs/jtVzMzxjM/vh9Wuoh Psvhvg2DRK/l+yRrhkOvAydqHLKIk+sXWD/s9+b/LX/Cw+GghNIiOaVezC347TT0NsGP Q1Ci2y29JhQ3Jal2XF0IjOw4zlKY7ZaQLStALg7/xRILdif6IgvmbecYZ74Ax6MiqnUf aJLt/qmsfQrIepW0/FnR6Ro5yhZhSNx+BfAA3ia8KwIzJOGFbQM7HP5lTzdyzBRMxv89 Yx+hpPBGaXryGPcWZK24TAIn3Wve1UeI9QBUfCprAwlzk0MUQLBbp7XUehhDE0jwci/B 8cMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=q71qCusexdgQod/MLNrjubxhj3b1imiM6uHyEI+ptXg=; b=lkKLnsoix/h5FC6s1aYye1pw1J7wbgLP7t97ltJgsUqVvwlHI+4whHyTJyo+fsm6CU g5mO/+nhZ2/DUCm1mD8M2ENxaj9dLIOf+h5zKw3BuVXVrZVqoUgxYXY6z7d2P6y8j3Ch UpABC7mxZ96+NYgh0vN+YpAiXwrUUAr17TEox+YvIPflDskZnRhCqmp3/q9tPdMTDq41 VKCzZ6kEj2Y4+EtvaUcwyDHpY752b1bQH8O5ZgtwGhxVQRRj9e1SqLhtF2QZs2QtOoj8 8qYD5fy3lbi1TNyclTM5sNQJjnEl1ADsUh+nALpShFHGWp2Zj5Y1N4BDH9LSF0Mev2aF zIOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020a170902e80c00b0016d0be7887csi23287593plg.518.2022.07.27.20.45.27; Wed, 27 Jul 2022 20:45:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235685AbiG1Dbd (ORCPT + 99 others); Wed, 27 Jul 2022 23:31:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234161AbiG1Dbb (ORCPT ); Wed, 27 Jul 2022 23:31:31 -0400 Received: from mail.nfschina.com (unknown [IPv6:2400:dd01:100f:2:72e2:84ff:fe10:5f45]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8BBF852DD9; Wed, 27 Jul 2022 20:31:29 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id B4A441E80D72; Thu, 28 Jul 2022 11:31:31 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ANGcd-Ku-b8R; Thu, 28 Jul 2022 11:31:29 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: yuzhe@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id 4D8BE1E80CF5; Thu, 28 Jul 2022 11:31:28 +0800 (CST) From: Yu Zhe To: Felix.Kuehling@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, liqiong@nfschina.com, Yu Zhe Subject: [PATCH v2] drm/amdkfd: use time_is_before_jiffies(a + b) to replace "jiffies - a > b" Date: Thu, 28 Jul 2022 11:30:26 +0800 Message-Id: <20220728033026.15952-1-yuzhe@nfschina.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220727025917.22477-1-yuzhe@nfschina.com> References: <20220727025917.22477-1-yuzhe@nfschina.com> X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org time_is_before_jiffies deals with timer wrapping correctly. Signed-off-by: Yu Zhe --- drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c index a9466d154395..34772fe74296 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c @@ -146,7 +146,7 @@ static void interrupt_wq(struct work_struct *work) struct kfd_dev *dev = container_of(work, struct kfd_dev, interrupt_work); uint32_t ih_ring_entry[KFD_MAX_RING_ENTRY_SIZE]; - long start_jiffies = jiffies; + unsigned long start_jiffies = jiffies; if (dev->device_info.ih_ring_entry_size > sizeof(ih_ring_entry)) { dev_err_once(dev->adev->dev, "Ring entry too small\n"); @@ -156,7 +156,7 @@ static void interrupt_wq(struct work_struct *work) while (dequeue_ih_ring_entry(dev, ih_ring_entry)) { dev->device_info.event_interrupt_class->interrupt_wq(dev, ih_ring_entry); - if (jiffies - start_jiffies > HZ) { + if (time_is_before_jiffies(start_jiffies + HZ)) { /* If we spent more than a second processing signals, * reschedule the worker to avoid soft-lockup warnings */ -- 2.11.0