Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: HAOKeges8/0ZO35ahl4ns8bCVjCaYJGqvFbHQtx9oq8NEF9B5FQG4nRPv7OqtSGXJEywItAqk1
 3nHiPwK/ixNq8Hsnu5Jefa+KBYZCb9rD4n1ja6etx3tc+VJnSdama9TtHkLATrZTWdmTu61Lg/
 v+j4C5WMH55lt3vMTDlSRuYAi+mSZU2evaOa/I5Lt5GF9E9xyWaywTQ+/kMIuoBoN3UuaxnORQ
 tflr2vn1ZZuKn416CxQSjp7Ooyp+WcRQkmTzQTDz+SeUrz1tqYWOpgQ3XbbHKqUaNr9U4z/vSy
 A1gMqC7EoeW08YmzR5+X8538
IronPort-SDR: BlOC6jMfuHKtcvNydchF3i10m4Z58+m+URb4qyb4JUhq0fL+7rtin64iSnoHdykR+pAIZcGmvO
 ol2q+KUQnR1nk7B7TS73SlyExSz9sUSKeer1P3YvMSpGEyKhLpil5ETzSubFBzXiUJ6IeyAXgg
 d2g2KX9kxrVkxipwf+zr8jrPIdOEdlnMSGp+aWNQ3Ji8y5GCCn0y9tX9OteESN2ZwnBkbfjUR5
 t7ONKuqzsN3yEpA3M9EB1I5aDerNggZgZw8lNoX14ALOLlMdnmbThlaxRAoiO8qrs15v4+japN
 18Q=
WDCIronportException: Internal
Message-ID: <65a336f0-ecd7-e9d5-2646-37cf9f157d53@opensource.wdc.com>
Date:   Thu, 28 Jul 2022 12:22:41 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v8 09/11] dm-table: allow non po2 zoned devices
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, hch@lst.de, axboe@kernel.dk,
        snitzer@kernel.org, Johannes.Thumshirn@wdc.com
Cc:     matias.bjorling@wdc.com, gost.dev@samsung.com,
        linux-kernel@vger.kernel.org, hare@suse.de,
        linux-block@vger.kernel.org, pankydev8@gmail.com,
        bvanassche@acm.org, jaegeuk@kernel.org, dm-devel@redhat.com,
        linux-nvme@lists.infradead.org
References: <20220727162245.209794-1-p.raghav@samsung.com>
 <CGME20220727162255eucas1p2945c6dca42b799bb3b4abf3edb83dde8@eucas1p2.samsung.com>
 <20220727162245.209794-10-p.raghav@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220727162245.209794-10-p.raghav@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/28/22 01:22, Pankaj Raghav wrote:
> As the block layer now supports non po2 zoned devices, allow dm to
> support non po2 zoned device.

Please rephrase "non po2 zoned devices" here and in the title to correctly
refer to the zone size of zoned devices. Because "non po2 zoned devices"
means absolutely nothing. Let's be clear please.

> 
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
>  drivers/md/dm-table.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 332f96b58252..534fddfc2b42 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -250,7 +250,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>  	if (bdev_is_zoned(bdev)) {
>  		unsigned int zone_sectors = bdev_zone_sectors(bdev);
>  
> -		if (start & (zone_sectors - 1)) {
> +		if (!bdev_is_zone_aligned(bdev, start)) {
>  			DMWARN("%s: start=%llu not aligned to h/w zone size %u of %pg",
>  			       dm_device_name(ti->table->md),
>  			       (unsigned long long)start,
> @@ -267,7 +267,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>  		 * devices do not end up with a smaller zone in the middle of
>  		 * the sector range.
>  		 */
> -		if (len & (zone_sectors - 1)) {
> +		if (!bdev_is_zone_aligned(bdev, len)) {
>  			DMWARN("%s: len=%llu not aligned to h/w zone size %u of %pg",
>  			       dm_device_name(ti->table->md),
>  			       (unsigned long long)len,
> @@ -1642,8 +1642,8 @@ static int validate_hardware_zoned_model(struct dm_table *t,
>  		return -EINVAL;
>  	}
>  
> -	/* Check zone size validity and compatibility */
> -	if (!zone_sectors || !is_power_of_2(zone_sectors))
> +	/* Check zone size validity */

The comment is not super useful now given the trivial test.

> +	if (!zone_sectors)
>  		return -EINVAL;
>  
>  	if (dm_table_any_dev_attr(t, device_not_matches_zone_sectors, &zone_sectors)) {


-- 
Damien Le Moal
Western Digital Research