Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8678322f-01e9-862e-9c6e-1ada1c6badf5@fb.com>
Date:   Wed, 27 Jul 2022 22:51:16 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH bpf-next v5 8/8] bpf: add a selftest for cgroup
 hierarchical stats collection
Content-Language: en-US
To:     Yosry Ahmed <yosryahmed@google.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Hao Luo <haoluo@google.com>,
        Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Shuah Khan <shuah@kernel.org>,
        Michal Hocko <mhocko@kernel.org>,
        KP Singh <kpsingh@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        =?UTF-8?Q?Michal_Koutn=c3=bd?= <mkoutny@suse.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        David Rientjes <rientjes@google.com>,
        Stanislav Fomichev <sdf@google.com>,
        Greg Thelen <gthelen@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org, cgroups@vger.kernel.org
References: <20220722174829.3422466-1-yosryahmed@google.com>
 <20220722174829.3422466-9-yosryahmed@google.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220722174829.3422466-9-yosryahmed@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHJIZ1FJRjV6a3BKOTZnZnpXL24zcHhRNlNJeDRBL1NzaTBqdW1TS2o4WlV3?=
 =?utf-8?B?aFJoVWpFL01qMjIyRnY2dXRhWXk0YmJPaTMyN0VjVG56amp4R2IwTnpGZXhk?=
 =?utf-8?B?QnVTdkZ2eGthWkJxNDcwZG1pTyswb2tJdDJFd1IyT00rY2pYeGZXQy8wb1Ni?=
 =?utf-8?B?THB0SGJFL0E5QmlsQUs5aGQyZVVUMEkxRTU4bkQrZXdxeHlmSzdHVzNtMWEv?=
 =?utf-8?B?QzNGMjI4NVVmNVhnNTJLZThEY0ZTUzdGbEZ4dnluSGFQYWNIRDM4L1ZyZ3Fx?=
 =?utf-8?B?NzRzaHh6OGh2ZklzMC9tbHV1VitLeXpDL2JNT3RkVkdPeEN4U1dGYkpjUmxY?=
 =?utf-8?B?bHVpN0ZKTGgyUTFQNnN0U1NuTWw2MlFVVDdqc0hnQXp1M0o5KzFmVkhZZlNZ?=
 =?utf-8?B?d2hYRmx1SzVOT0FXWVh6ZnhyOWNodzV1QURRd2ZpdXA1NG5JNUZ4eDN4cW4y?=
 =?utf-8?B?aE9vdys0OENiYlgvc01FOFM0c3BVODNCVDJ5MFVhYVExenhYeVpRYlp3Rno3?=
 =?utf-8?B?RVVWdVNlK0VHMVZpdzdBZWMvQzhNcGtsallVc1I4c1VvVllSblE1WFE1ZitQ?=
 =?utf-8?B?ZDhBM0IwNXI1dHZaOEVCRnM5cjFxQlRralZ5SHVuYmpFUGdYcW9XQXMvTVd5?=
 =?utf-8?B?WGNIa3JySk5UVWVMUXRPWlRxNU04NEVJZThRRHVaZzNZY0dtNVhnNytOTlpq?=
 =?utf-8?B?aU12S2cxdHBLVk4wUzh0ZDlQMTdzRUpoaFJPRHBVZi83cGRFdFQyZnpYeC9C?=
 =?utf-8?B?b3FncmpXc29rb1JyOVNNcXlXZTlDWXk1QStyZzdiY0M0K0tFSTQwa0t6VVBo?=
 =?utf-8?B?RHAydFJhKzdIYW1uWHBtQ1c0NGwvYnQyenZUU0VlV25UWURlekh1U29BZko5?=
 =?utf-8?B?WjRMay9YTDFTWUhDODNhZ0F1V0pId2lsWU05WWViOVdmR3ZPV1UxZ0FOT0l0?=
 =?utf-8?B?dWVRZndXN3l6dGh1R1d1V1NhWnhvdCtYU2xGK05IaEV4REJqaVRCUGtXQTFy?=
 =?utf-8?B?Y2RTZlV4K2phanN5RVdhSDZPd3grSzhDaHg0cWRtc3h3VlBwUkFJQUkzS2hC?=
 =?utf-8?B?cjFxMHZwZHlQZ1B3bGtRWDAyWU85RjM4ODAxNnI1cjZIS3VDYURtOGE5TWRB?=
 =?utf-8?B?dndoL0ljQXRDTHNLTXljRFFTYlpGZzBRbVZJOW9yai9aNGpBcFg5MTJhUkwx?=
 =?utf-8?B?YTZiQlRyL3pBVktDNUpQbFVESEswdUUrZVV3dW1HaFpIc2pqVjRMMis4KzA3?=
 =?utf-8?B?TmdveGRaVk1aaEtScHVyZHh5cGxKbFRiYmtEbFVDOHJpQ20vN2lyWGY3dVFC?=
 =?utf-8?B?VHR2OGRHSEJrc2ptbVYzNFRFNlNMQUJkclE0bzhHVkc5b0NabzJXY0JmdThQ?=
 =?utf-8?B?aG1uckp0Wi8wL2hpZk9aMEE3aEFHM2JaNmVzTjNqeEI0dUJ4WHdKd0NCZXIx?=
 =?utf-8?B?WnNuT3JiRU9MRjRmWnhMRm0xUTFobTB1cVBYWU9zSVNSSHJiWUcrcGpGcmVm?=
 =?utf-8?B?SC9WRGdLSk9VM3NFRVZnUnVYbHdMV0xnd0c3TlN0ZmwxODA5cUcxQVh3WlRJ?=
 =?utf-8?B?ZHdMdzVTQ2xoNFZsSWJ0MjQwbTdIa0Z0Z3dNSmZvakorYy9uT2JMUUhjOVRN?=
 =?utf-8?B?LzFvWU9ZS3JYenVkQ0ZJOW5KZm9Ec0FKcFpqRGE4T2RYczFJNFk0ZGgrcGRW?=
 =?utf-8?B?NnhCN0dMRGNSV2dvWDRRQVpBUGtXdFVVNnZrN1BEVkN4UHM0NmFtZEFFS05w?=
 =?utf-8?B?Wnp2Z2hreXJUZUJ6dXdnZlRxSGVVMExDRXpTVTBZRU9aN0tGbUtYV1phWGIy?=
 =?utf-8?B?WnI4aDRMb1d3cEhNbWpQelB0ZlIrLy9zTTQ5R05MVjNaWURsbHBhcnUzS3Bw?=
 =?utf-8?B?OGpBUnhrWFF0TmFVS2NHVnY2U1Qvam1rSE45bjdnUUJneWk1UUVueHNoRE1j?=
 =?utf-8?B?U29PcHdjVkhUMzBJZzgyYzEwL0RkcmlmUHRqajh6SzZKakhFMUNidkcwanFm?=
 =?utf-8?B?R1c1b2tmYUtQKzl5d0FBWCs0ajRpaEROczJ4NFl4cWFycEhHeExPcGF5dGww?=
 =?utf-8?B?cGhzN1ZpM1ZZenFrNnd3aUJTUkZLdmlkOVc1bEdGQWo0NXNrQnIrTkd6RzJN?=
 =?utf-8?B?OTdkYnorTjZhQWY1UitjSDRINVZndXBpVGJPVVZ2aFArOGRZeHQzWTlabUlM?=
 =?utf-8?B?NkE9PQ==?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a3416e8-aa8c-4082-56ff-08da705d3192
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 05:51:19.4477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uXcW0X+SK5lLl3cO/dNXnAth4MVOcLb3ulPuBSVcmEAqW2KYd6riBRwXAWjuy/7V
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR15MB5416
X-Proofpoint-GUID: ONtMkau17rQRlTdK9wEXuge4rfH6Lj4K
X-Proofpoint-ORIG-GUID: ONtMkau17rQRlTdK9wEXuge4rfH6Lj4K
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-27_08,2022-07-27_01,2022-06-22_01
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/22/22 10:48 AM, Yosry Ahmed wrote:
> Add a selftest that tests the whole workflow for collecting,
> aggregating (flushing), and displaying cgroup hierarchical stats.
> 
> TL;DR:
> - Userspace program creates a cgroup hierarchy and induces memcg reclaim
>    in parts of it.
> - Whenever reclaim happens, vmscan_start and vmscan_end update
>    per-cgroup percpu readings, and tell rstat which (cgroup, cpu) pairs
>    have updates.
> - When userspace tries to read the stats, vmscan_dump calls rstat to flush
>    the stats, and outputs the stats in text format to userspace (similar
>    to cgroupfs stats).
> - rstat calls vmscan_flush once for every (cgroup, cpu) pair that has
>    updates, vmscan_flush aggregates cpu readings and propagates updates
>    to parents.
> - Userspace program makes sure the stats are aggregated and read
>    correctly.
> 
> Detailed explanation:
> - The test loads tracing bpf programs, vmscan_start and vmscan_end, to
>    measure the latency of cgroup reclaim. Per-cgroup readings are stored in
>    percpu maps for efficiency. When a cgroup reading is updated on a cpu,
>    cgroup_rstat_updated(cgroup, cpu) is called to add the cgroup to the
>    rstat updated tree on that cpu.
> 
> - A cgroup_iter program, vmscan_dump, is loaded and pinned to a file, for
>    each cgroup. Reading this file invokes the program, which calls
>    cgroup_rstat_flush(cgroup) to ask rstat to propagate the updates for all
>    cpus and cgroups that have updates in this cgroup's subtree. Afterwards,
>    the stats are exposed to the user. vmscan_dump returns 1 to terminate
>    iteration early, so that we only expose stats for one cgroup per read.
> 
> - An ftrace program, vmscan_flush, is also loaded and attached to
>    bpf_rstat_flush. When rstat flushing is ongoing, vmscan_flush is invoked
>    once for each (cgroup, cpu) pair that has updates. cgroups are popped
>    from the rstat tree in a bottom-up fashion, so calls will always be
>    made for cgroups that have updates before their parents. The program
>    aggregates percpu readings to a total per-cgroup reading, and also
>    propagates them to the parent cgroup. After rstat flushing is over, all
>    cgroups will have correct updated hierarchical readings (including all
>    cpus and all their descendants).
> 
> - Finally, the test creates a cgroup hierarchy and induces memcg reclaim
>    in parts of it, and makes sure that the stats collection, aggregation,
>    and reading workflow works as expected.
> 
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>

Let us tag the subject with "selftests/bpf: Add a selftest ..." instead
of "bpf: add a selftest ..."