Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Jul 2022 08:22:20 +0100
From:   Aaron Tomlin <atomlin@redhat.com>
To:     jan.kiszka@siemens.com, kbingham@kernel.org
Cc:     atomlin@atomlin.com, linux-kernel@vger.kernel.org,
        swboyd@chromium.org, dianders@chromium.org,
        skhan@linuxfoundation.org
Subject: Re: [PATCH v2] scripts/gdb: Ensure the absolute path is generated on
 initial source
Message-ID: <20220728072220.xhyg65izemzcdojr@ava.usersys.com>
References: <20220712110248.1404125-1-atomlin@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220712110248.1404125-1-atomlin@redhat.com>
Precedence: bulk

On Tue 2022-07-12 12:02 +0100, Aaron Tomlin wrote:
> Post 'make scripts_gdb' a symbolic link to scripts/gdb/vmlinux-gdb.py
> is created. Currently 'os.path.dirname(__file__)' does not generate
> the absolute path to scripts/gdb resulting in the following:
> 
>     (gdb) source vmlinux-gdb.py
>     Traceback (most recent call last):
>       File "scripts/gdb/vmlinux-gdb.py", line 25, in <module>
> 	import linux.utils
>     ModuleNotFoundError: No module named 'linux'
> 
> This patch ensures that the absolute path to scripts/gdb in relation to
> the given file is generated so each module can be located accordingly.
> 
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
> ---
>  scripts/gdb/vmlinux-gdb.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py
> index 4136dc2c59df..3e8d3669f0ce 100644
> --- a/scripts/gdb/vmlinux-gdb.py
> +++ b/scripts/gdb/vmlinux-gdb.py
> @@ -13,7 +13,7 @@
>  
>  import os
>  
> -sys.path.insert(0, os.path.dirname(__file__) + "/scripts/gdb")
> +sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)) + "/scripts/gdb")
>  
>  try:
>      gdb.parse_and_eval("0")
> -- 
> 2.34.3

Any feedback?


Kind regards,

-- 
Aaron Tomlin