Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp316208imn; Thu, 28 Jul 2022 01:14:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1voRCIFFaXRrdEd4TxvTloUHkiJwABy+aaY83t3rjkhbcN5E3mDAqCV07KZB+PVQxneU6I6 X-Received: by 2002:a05:6402:48:b0:43a:caa8:756b with SMTP id f8-20020a056402004800b0043acaa8756bmr25853612edu.112.1658996079565; Thu, 28 Jul 2022 01:14:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658996079; cv=none; d=google.com; s=arc-20160816; b=YGpBTGqU57gtLZZaXPfVfyUW+iSNA8ykOZTRPP6GvEaTGoioU2X6qNB/tYBWzDejS4 4UQOR+RX7GeeLdSNDtxYZ4cW8hvpOz2tP1wJReOuCPKA9USm56309XuAzOrG7qIC/bJQ egF8wn8Qratae+qNm66Pu94JFM8p+QMJfcnooH17TzWr3NXBkAAlHaPtSFWJ/5EYF8F9 foPOUeGRwY8YpydwspUKW+GFDk1oCiElqlD+WcUMi4b18SOUZyWEtF8x+dirPcd9/bzq 0NwoPca69yVGk8pp1tQG9VbCZMj13LVOj6E8Nijkkykwrr9L2/U5eaZlQT7p1gfjG9nx yA2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id; bh=9MmRJRezDi2KJSNQLQXk8Ll9qvELWNZRS7UmUzHJKJ0=; b=CZVH/GFFGAewue2AuwF98g10vZjpEepzg+D4DXwl6cOkr+NbMP4DUA4WlR/F3u1QTu 9JuKzTGQbiUToa+RlDFUG9UobyOz/NIwqfrvDXDQdGx8sfaxzVID9XZ51Z24Dc1w4kqv 24Jk7zdHq8bW2Nkv4bLT4NcrfB6nHgM47CjHYmc4YshjSLXJt+wboeQf6GOkUaWUtgZ5 GZ7/OZWNIlpyoQn8Ns38mltCQ3p5c6DHHE/G2tC+ng+Hva86QWYYwHBbGjkF9kC0BYUN 6TtuVgV4u1AekBZ92mmJdHL9++qSRkSSYQ/qb4rJSx6lEl9oFLWGyptKrqELTpcG1AAO bjjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ck22-20020a170906c45600b006e7fe1e4eb4si148004ejb.847.2022.07.28.01.14.11; Thu, 28 Jul 2022 01:14:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234974AbiG1IGb (ORCPT + 99 others); Thu, 28 Jul 2022 04:06:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233818AbiG1IG3 (ORCPT ); Thu, 28 Jul 2022 04:06:29 -0400 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 375EE61D54; Thu, 28 Jul 2022 01:06:28 -0700 (PDT) Received: from [10.18.29.47] (10.18.29.47) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 28 Jul 2022 16:06:25 +0800 Message-ID: <032b3c3f-f899-bf53-ecbb-35191d39392b@amlogic.com> Date: Thu, 28 Jul 2022 16:06:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V2 0/3] Add S4 SoC clock controller driver Content-Language: en-US To: Jerome Brunet , , , , , , Rob Herring , Neil Armstrong , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl References: <20220728054202.6981-1-yu.tu@amlogic.com> <1j8rodhfn9.fsf@starbuckisacylon.baylibre.com> From: Yu Tu In-Reply-To: <1j8rodhfn9.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.47] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi JB, On 2022/7/28 15:08, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > > On Thu 28 Jul 2022 at 13:41, Yu Tu wrote: > >> 1. Add clock controller driver for S4 SOC. >> >> Yu Tu (3): >> dt-bindings: clk: meson: add S4 SoC clock controller bindings >> arm64: dts: meson: add S4 Soc clock controller in DT >> clk: meson: s4: add s4 SoC clock controller driver >> >> V1 -> V2: Change format as discussed in the email. >> >> Link:https://lore.kernel.org/linux-amlogic/20220708062757.3662-1-yu.tu@amlogic.com/ >> >> .../bindings/clock/amlogic,gxbb-clkc.txt | 1 + >> MAINTAINERS | 1 + >> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 11 + >> drivers/clk/meson/Kconfig | 15 + >> drivers/clk/meson/Makefile | 1 + >> drivers/clk/meson/s4.c | 4732 +++++++++++++++++ >> drivers/clk/meson/s4.h | 296 ++ >> include/dt-bindings/clock/s4-clkc.h | 146 + >> 8 files changed, 5203 insertions(+) >> create mode 100644 drivers/clk/meson/s4.c >> create mode 100644 drivers/clk/meson/s4.h >> create mode 100644 include/dt-bindings/clock/s4-clkc.h >> >> >> base-commit: b293bc9286ee21824e93f0fcfed3b78fdfee01e6 > > Please don't post until you have addressed *ALL* the comments from the > previous version. The last email asked you to adopt A1 method, but you did not reply? > > At first glance, I can see that this is still a single driver for > what is obviously 2 controllers with 2 register spaces. Simple comments > like the "<< 2" in the register declaration have not been addressed either. I understand that this should be a controller, just two address descriptions. One is the various PLL registers and one is the clock for the peripherals. And PLL is to provide a clock source for various peripheral clocks. So a clock controller is reasonable. I think you got it wrong. Ok, if you insist on using two clock controllers,, please provide your the reason and example code? > > Seeing that, I have not reviewed this version further. > I won't until all the comments from v1 are either addressed or answer > > Regards > Jerome > > .