Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <00914cf65b64e06f370213fdc079111aa2a27145.camel@xry111.site>
Subject: Re: [PATCH 1/5] LoongArch: Add section of GOT for kernel module
From:   Xi Ruoyao <xry111@xry111.site>
To:     Youling Tang <tangyouling@loongson.cn>, loongarch@lists.linux.dev
Cc:     linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 28 Jul 2022 17:02:58 +0800
In-Reply-To: <849f514e-f78a-72a2-b94e-6974074b75eb@loongson.cn>
References: <385f63bcbee8e37c42f479ce9cdc7e7d731d419b.camel@xry111.site>
         <3f43d51d530344f73a0a7087407799ff9dff3ba8.camel@xry111.site>
         <849f514e-f78a-72a2-b94e-6974074b75eb@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-07-28 at 16:29 +0800, Youling Tang wrote:
> On 07/28/2022 12:26 AM, Xi Ruoyao wrote:
> > +	mod->arch.got.shdr->sh_type =3D SHT_NOBITS;
> > +	mod->arch.got.shdr->sh_flags =3D SHF_ALLOC;
> > +	mod->arch.got.shdr->sh_addralign =3D L1_CACHE_BYTES;
> > +	mod->arch.got.shdr->sh_size =3D (num_plts + 1) *
> > sizeof(struct plt_entry);
> > +	mod->arch.got.num_entries =3D 0;
> > +	mod->arch.got.max_entries =3D num_plts;
> =C2=A0Hi, Ruoyao
>=20
> =C2=A0=C2=A0We should use num_gots instead of num_plts when creating .got
> section.

Yes, it's a stupid error and I'll fix it in V2.

But why didn't this cause a malfunction on my system? :(.

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University