Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 1/5] LoongArch: Add section of GOT for kernel module
To:     Xi Ruoyao <xry111@xry111.site>, loongarch@lists.linux.dev
References: <385f63bcbee8e37c42f479ce9cdc7e7d731d419b.camel@xry111.site>
 <3f43d51d530344f73a0a7087407799ff9dff3ba8.camel@xry111.site>
 <849f514e-f78a-72a2-b94e-6974074b75eb@loongson.cn>
 <00914cf65b64e06f370213fdc079111aa2a27145.camel@xry111.site>
Cc:     linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>
From:   Youling Tang <tangyouling@loongson.cn>
Message-ID: <fac4319d-26ee-1702-518c-2d6fbb1a0d57@loongson.cn>
Date:   Thu, 28 Jul 2022 17:21:05 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <00914cf65b64e06f370213fdc079111aa2a27145.camel@xry111.site>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/28/2022 05:02 PM, Xi Ruoyao wrote:
> On Thu, 2022-07-28 at 16:29 +0800, Youling Tang wrote:
>> On 07/28/2022 12:26 AM, Xi Ruoyao wrote:
>>> +	mod->arch.got.shdr->sh_type = SHT_NOBITS;
>>> +	mod->arch.got.shdr->sh_flags = SHF_ALLOC;
>>> +	mod->arch.got.shdr->sh_addralign = L1_CACHE_BYTES;
>>> +	mod->arch.got.shdr->sh_size = (num_plts + 1) *
>>> sizeof(struct plt_entry);
>>> +	mod->arch.got.num_entries = 0;
>>> +	mod->arch.got.max_entries = num_plts;
>>  Hi, Ruoyao
>>
>>   We should use num_gots instead of num_plts when creating .got
>> section.
>
> Yes, it's a stupid error and I'll fix it in V2.
>
> But why didn't this cause a malfunction on my system? :(.

Maybe num_plts is greater than num_gots, and the size of plt_entry is 
equivalent to the size of four got_entry, so that when the module is 
loaded, it just allocates a larger space without causing the module to 
fail to load.

Thanks,
Youling
>