Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 4/5] LoongArch: Stop using undocumented assembler options
To:     Xi Ruoyao <xry111@xry111.site>, loongarch@lists.linux.dev
References: <385f63bcbee8e37c42f479ce9cdc7e7d731d419b.camel@xry111.site>
 <4f09c81c22d0a16883a6914a8f7209957386c07c.camel@xry111.site>
Cc:     linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>
From:   Youling Tang <tangyouling@loongson.cn>
Message-ID: <4f4ced23-2046-586c-2590-542923025149@loongson.cn>
Date:   Thu, 28 Jul 2022 17:46:39 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <4f09c81c22d0a16883a6914a8f7209957386c07c.camel@xry111.site>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 07/28/2022 12:29 AM, Xi Ruoyao wrote:
> Now we can handle GOT and GOT-based relocations properly, remove the
> undocumented `-Wa,-mla-{global,local}-with-{pcrel,abs}` assembler hacks.
>
> Adjust assembly code to explicitly use "la.pcrel" where necessary.
>
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
>  arch/loongarch/Makefile      |  5 +----
>  arch/loongarch/kernel/head.S | 10 +++++-----
>  2 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> index 039dcc4fe1f3..9552c7880d34 100644
> --- a/arch/loongarch/Makefile
> +++ b/arch/loongarch/Makefile
> @@ -40,10 +40,7 @@ endif
>
>  cflags-y			+= -G0 -pipe -msoft-float
>  LDFLAGS_vmlinux			+= -G0 -static -n -nostdlib
> -KBUILD_AFLAGS_KERNEL		+= -Wa,-mla-global-with-pcrel
> -KBUILD_CFLAGS_KERNEL		+= -Wa,-mla-global-with-pcrel
> -KBUILD_AFLAGS_MODULE		+= -Wa,-mla-global-with-abs
> -KBUILD_CFLAGS_MODULE		+= -fplt -Wa,-mla-global-with-abs,-mla-local-with-abs
> +KBUILD_CFLAGS_MODULE		+= -fplt

The -fplt flag may be removed, the compiler defaults to -fplt if not
specified (riscv is also not manually specified as -fplt).

Thanks,
Youling