Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <73f83b51eaf40ff1f173059e1f187182db47a1c6.camel@xry111.site>
Subject: Re: [PATCH 3/5] LoongArch: Support relocation against
 _GLOBAL_OFFSET_TABLE_
From:   Xi Ruoyao <xry111@xry111.site>
To:     Jinyang He <hejinyang@loongson.cn>, loongarch@lists.linux.dev
Cc:     linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 28 Jul 2022 18:57:10 +0800
In-Reply-To: <caf8ec4b-f74d-e6ef-17f2-9e899d41b3a9@loongson.cn>
References: <385f63bcbee8e37c42f479ce9cdc7e7d731d419b.camel@xry111.site>
         <99733532831377ab6585d43ee40bf314a2d4c5a3.camel@xry111.site>
         <10c1e0f9-8409-a0f4-9b18-a5f56dfb14e1@loongson.cn>
         <9a79a424a11339ae025539c38fe121104ff00804.camel@xry111.site>
         <caf8ec4b-f74d-e6ef-17f2-9e899d41b3a9@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-07-28 at 17:14 +0800, Jinyang He wrote:
> Not sure but maybe re-align is needed here.
> Since '{BYTE(0)}' actually use 1byte. _GLOABL_OFFSET_TABLE_ may have
> difference with really GOT table entry. Have no machine and without=20
> test... :-(

BYTE(0) is only for preventing the linker from removing the section.=20
All we want from the linker is a slot for .got in the section table, and
the actual property (including size) will be filled at runtime by
module_frob_arch_sections.  The first GOT entry won't be "appended"
after one byte, it is wrote into the start of .got (at runtime).

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University