Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f8b9895d807b954b3af435b5ef4b70ddd95862b.camel@xry111.site>
Subject: Re: [PATCH 4/5] LoongArch: Stop using undocumented assembler options
From:   Xi Ruoyao <xry111@xry111.site>
To:     Youling Tang <tangyouling@loongson.cn>, loongarch@lists.linux.dev
Cc:     linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>
Date:   Thu, 28 Jul 2022 18:58:40 +0800
In-Reply-To: <4f4ced23-2046-586c-2590-542923025149@loongson.cn>
References: <385f63bcbee8e37c42f479ce9cdc7e7d731d419b.camel@xry111.site>
         <4f09c81c22d0a16883a6914a8f7209957386c07c.camel@xry111.site>
         <4f4ced23-2046-586c-2590-542923025149@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-07-28 at 17:46 +0800, Youling Tang wrote:
>=20
> On 07/28/2022 12:29 AM, Xi Ruoyao wrote:
> > Now we can handle GOT and GOT-based relocations properly, remove the
> > undocumented `-Wa,-mla-{global,local}-with-{pcrel,abs}` assembler
> > hacks.
> >=20
> > Adjust assembly code to explicitly use "la.pcrel" where necessary.
> >=20
> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> > ---
> > =C2=A0arch/loongarch/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 5 +=
----
> > =C2=A0arch/loongarch/kernel/head.S | 10 +++++-----
> > =C2=A02 files changed, 6 insertions(+), 9 deletions(-)
> >=20
> > diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> > index 039dcc4fe1f3..9552c7880d34 100644
> > --- a/arch/loongarch/Makefile
> > +++ b/arch/loongarch/Makefile
> > @@ -40,10 +40,7 @@ endif
> >=20
> > =C2=A0cflags-y=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0+=3D -G0 -pipe -msoft-float
> > =C2=A0LDFLAGS_vmlinux=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0+=3D -G0 -static -n -nostdlib
> > -KBUILD_AFLAGS_KERNEL=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0+=3D -Wa,-mla-global-with-pcrel
> > -KBUILD_CFLAGS_KERNEL=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0+=3D -Wa,-mla-global-with-pcrel
> > -KBUILD_AFLAGS_MODULE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0+=3D -Wa,-mla-global-with-abs
> > -KBUILD_CFLAGS_MODULE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0+=3D -fplt -Wa,-mla-global-with-abs,-
> > mla-local-with-abs
> > +KBUILD_CFLAGS_MODULE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0+=3D -fplt
>=20
> The -fplt flag may be removed, the compiler defaults to -fplt if not
> specified (riscv is also not manually specified as -fplt).

Will remove explicit -fplt in V2.

By the way, how do you think about "-G0"?  It does not have any effect
now because the toolchain does not attempt to use sbss/sdata sections.
Do we have any plan to add sbss and sdata support in the toolchain?


--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University