Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 3/5] LoongArch: Support relocation against
 _GLOBAL_OFFSET_TABLE_
To:     Xi Ruoyao <xry111@xry111.site>, loongarch@lists.linux.dev
References: <385f63bcbee8e37c42f479ce9cdc7e7d731d419b.camel@xry111.site>
 <99733532831377ab6585d43ee40bf314a2d4c5a3.camel@xry111.site>
 <10c1e0f9-8409-a0f4-9b18-a5f56dfb14e1@loongson.cn>
 <9a79a424a11339ae025539c38fe121104ff00804.camel@xry111.site>
 <caf8ec4b-f74d-e6ef-17f2-9e899d41b3a9@loongson.cn>
 <73f83b51eaf40ff1f173059e1f187182db47a1c6.camel@xry111.site>
Cc:     linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>
From:   Jinyang He <hejinyang@loongson.cn>
Message-ID: <1671786a-d2a5-5f98-e8be-244ba0a91e91@loongson.cn>
Date:   Thu, 28 Jul 2022 19:21:10 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <73f83b51eaf40ff1f173059e1f187182db47a1c6.camel@xry111.site>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 07/28/2022 06:57 PM, Xi Ruoyao wrote:

> On Thu, 2022-07-28 at 17:14 +0800, Jinyang He wrote:
>> Not sure but maybe re-align is needed here.
>> Since '{BYTE(0)}' actually use 1byte. _GLOABL_OFFSET_TABLE_ may have
>> difference with really GOT table entry. Have no machine and without
>> test... :-(
> BYTE(0) is only for preventing the linker from removing the section.
> All we want from the linker is a slot for .got in the section table, and
> the actual property (including size) will be filled at runtime by
> module_frob_arch_sections.  The first GOT entry won't be "appended"
> after one byte, it is wrote into the start of .got (at runtime).
Thank you for the detail answer which solves a doubt
that bothered me for a long time. I used to define the
'sym' outside of '.sec'. It always failed without align.