Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Jul 2022 13:38:27 +0200
From:   Jean Delvare <jdelvare@suse.de>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     linux-mediatek@lists.infradead.org,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Chenglin Xu <chenglin.xu@mediatek.com>
Subject: Re: [PATCH] soc: mediatek: Let PMIC Wrapper and SCPSYS depend on OF
Message-ID: <20220728133827.5f59e824@endymion.delvare>
In-Reply-To: <98eccbdd-3446-f44d-9278-79a4a60c1c18@collabora.com>
References: <20220728112216.13b10689@endymion.delvare>
        <98eccbdd-3446-f44d-9278-79a4a60c1c18@collabora.com>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Angelo,

On Thu, 28 Jul 2022 12:51:44 +0200, AngeloGioacchino Del Regno wrote:
> Il 28/07/22 11:22, Jean Delvare ha scritto:
> > With the following configuration options:
> > CONFIG_OF is not set
> > CONFIG_MTK_PMIC_WRAP=3Dy
> > CONFIG_MTK_SCPSYS=3Dy
> > we get the following build warnings:
> >=20
> >    CC      drivers/soc/mediatek/mtk-pmic-wrap.o
> > drivers/soc/mediatek/mtk-pmic-wrap.c:2138:34: warning: =E2=80=98of_pwra=
p_match_tbl=E2=80=99 defined but not used [-Wunused-const-variable=3D]
> > drivers/soc/mediatek/mtk-pmic-wrap.c:1953:34: warning: =E2=80=98of_slav=
e_match_tbl=E2=80=99 defined but not used [-Wunused-const-variable=3D]
> >    CC      drivers/soc/mediatek/mtk-scpsys.o
> > drivers/soc/mediatek/mtk-scpsys.c:1084:34: warning: =E2=80=98of_scpsys_=
match_tbl=E2=80=99 defined but not used [-Wunused-const-variable=3D]
> >=20
> > Looking at the code, both drivers can only bind to OF-defined device
> > nodes, so these drivers are useless without OF and should therefore
> > depend on it.
>=20
> I would prefer that you solve this warning by removing of_match_ptr() fro=
m both
> drivers instead.

Actually we could do both. Once the drivers depend on OF,
of_match_ptr(_ptr) will always resolve to (_ptr) so we can indeed
save the preprocessor some work.

--=20
Jean Delvare
SUSE L3 Support