Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Jul 2022 14:40:11 +0300
From:   Abel Vesa <abel.vesa@linaro.org>
To:     XU pengfei <xupengfei@nfschina.com>
Cc:     Kernel@nfschina.com, agross@kernel.org, bjorn.andersson@linaro.org,
        konrad.dybcio@somainline.org, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        mturquette@baylibre.com, sboyd@kernel.org
Subject: Re: [PATCH v2] clk/qcom/gcc-sm6350: Remove unnecessary semicolon
Message-ID: <20220728114011.2fztt7htj6ekwiz2@linaro.org>
References: <Yt5FAJiEv0WWuDNV@linaro.org>
 <20220728090719.3056-1-xupengfei@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220728090719.3056-1-xupengfei@nfschina.com>
Precedence: bulk

On 22-07-28 17:07:20, XU pengfei wrote:
> Remove unnecessary semicolon after qcom_cc_really_probe call.
>
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
> ---

Thanks for this new version, but there are still some issues with it.

First of, don't use slashes in subject. Use semicolons instead.
Have a look at how other commits look like by running:

git log --oneline drivers/clk/qcom/

Also, do not send subsquent versions of a patch as a reply to old ones.


>  drivers/clk/qcom/gcc-sm6350.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c
> index a4f7fba70393..69412400efa4 100644
> --- a/drivers/clk/qcom/gcc-sm6350.c
> +++ b/drivers/clk/qcom/gcc-sm6350.c
> @@ -2558,7 +2558,7 @@ static int gcc_sm6350_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>
> -	return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);;
> +	return qcom_cc_really_probe(pdev, &gcc_sm6350_desc, regmap);
>  }
>
>  static struct platform_driver gcc_sm6350_driver = {
> --
> 2.18.2
>