Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Jul 2022 13:28:25 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Olliver Schinagl <oliver+list@schinagl.nl>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        rust-for-linux <rust-for-linux@vger.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/13] [RFC] Rust support
Message-ID: <20220728132825.000017d0@garyguo.net>
In-Reply-To: <YuJ8lWGKXEk03u3M@kroah.com>
References: <20210414184604.23473-1-ojeda@kernel.org>
        <fae4873e-2ff9-df35-0ab9-34bf4417b717@schinagl.nl>
        <CANiq72mRxM-7griYF+0FWqYoSoNL8ad=L-i6a2-GsaCeb0C6qQ@mail.gmail.com>
        <ba8cb315-9d73-2f45-8bf9-d9473d369dca@schinagl.nl>
        <CANiq72kz+Txauo+103_-fN_J8PhhCdJUH5XepShUQmJzW6a4tA@mail.gmail.com>
        <5c0bb1db-5589-32ca-ac22-4aafb3c15751@schinagl.nl>
        <20220728112114.0000003a@garyguo.net>
        <YuJ8lWGKXEk03u3M@kroah.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mq9DNAtK9HvXCbfUMDxtqkQ3lAxAVKRG0PLmH/AJaChHGRc8WfiDwL6YR2qV?=
 =?us-ascii?Q?saoUKhEH7S61ftXBakMyZljlD/8nlEbQ+DHQEXkPCjY7kE0KNe96j1dTm8fB?=
 =?us-ascii?Q?QyLRPrWaDwm4a0jC072OF1v5FaEv2zTvEcMUdL3UT2qg8l/REFZ8Jw/vI6y8?=
 =?us-ascii?Q?/yfwR91Vv/EwbhzHdpsIdjDGCgIE84HwbSCqVcxmM9OWaasg95pgc3SptArP?=
 =?us-ascii?Q?NLwitthtPf/X+20LP2M+sjkdBk+YLWYAdc1t8co80XZ+6FBKDHT5lBbcGA5U?=
 =?us-ascii?Q?f39rvhsSTnQjP3znZcE0VgEsthZoyBN8aKREDoxtPrSM9fCeFIkiXQ2gBRf4?=
 =?us-ascii?Q?IlEjS1lqTXFWDfoSWYxOtKVE+/biYOSMwk1wHRJDs8rg8NgI0XmnN7h835B/?=
 =?us-ascii?Q?/rsPv2LD3SPli2cdiyRaQnED9VB84fcwCd1T0i3SkkZe8aK6StPHi3Rlj47v?=
 =?us-ascii?Q?GBHKh0lxNrmlWgILocl1DDIO8lrjkjscftSqU7ad/zmF16uxbPLxoMP01cG5?=
 =?us-ascii?Q?J5a9d9ffSKv1N96OHedcJEo7bPVyjR9EIxk81iWFZk17QEtPkIsFcGVjtbrU?=
 =?us-ascii?Q?XLCoGxKhNOwVLB3eg667mH+XesZOY3qDxlzMNslONzCEchnNBRlkfwEyANry?=
 =?us-ascii?Q?agSb1cfbZJpKmE2b17eOcT0xts0+E+4HIDr4pI6u+Hf+ewGo3vB3k8PB1gX6?=
 =?us-ascii?Q?9pYwcgzRIzwjwL5FGwGn+mvWv3VYcMBiQAsRGhArIa6p/0o6OuQ3hp9Ko7ls?=
 =?us-ascii?Q?NWCjPmPNYxLmr8c9HCsCBLKQBbwtyUnFAJhsHXpD00iMtaTCcObGMafnt+VJ?=
 =?us-ascii?Q?xDc4sTBNG2TxEoI34QAWrxjfCcubvgw2tTs0W4il5G//W6g7UNu2L8ZyChwH?=
 =?us-ascii?Q?mBLvtcCkPWkc4Z+/k1erB1i7xNFRLhxawhza5RU4v0EtwkNFcs9JKUjB/kjD?=
 =?us-ascii?Q?XpWIK+GuK1hQycNhVjq8asHIB/Cz4ud1X95oWC/rSn8A/arupYYKSa1GCQki?=
 =?us-ascii?Q?8T4a3NqzNACVLokGMnP3on+glUXDidjxoWeuiu9FlEX4vOjyFHmldxU/jrCp?=
 =?us-ascii?Q?li4ecNhMOqyT4f+5sbvVZRfBVhTqhEujztaQcd3N5be81RnXYfZZFLYEN2fY?=
 =?us-ascii?Q?tc7zglL3MihLoKikA4KZpMH8ZecEJDa2ICRvG+WVlDzaiTN7Sk2VSFiJQzae?=
 =?us-ascii?Q?8HBI0dP1Xg00A9kek7N+Ot7p8zLayaLWnHMEB7Rw9K09Qy4tf3VboKVWhPOQ?=
 =?us-ascii?Q?bEbydNRYFNlcfImDlEAdFw6+1vTU+0zs7dNccm525eLxq5Fe7ReFpjAtQXT3?=
 =?us-ascii?Q?nUlKQ6X704YoppELliFYILstKhKZMfKPuTOThDH0fSXVDj3KVxM7ji3mVkE8?=
 =?us-ascii?Q?mRFV3i5yBdpD5khGD7Qs4FFentGw7SWB5bdHmHQkezX4FlfxePw6VlEf7/N/?=
 =?us-ascii?Q?Xe/iLvynJd+iDNAkTjK40OvFA70xBt91pRJXPIrWxy4bMdKuVoEPz5qQHFyr?=
 =?us-ascii?Q?Jpp59QOkrB4UXS9JRpxzgeoS91fiWjk4Spc/+d1NVGjfKfRwxPSoI+CAb5tM?=
 =?us-ascii?Q?k+q2yAywR7JVYVjvglUi0228ANNAuyRML1IqjBrs5vGJCzUllEhUVNnfEacw?=
 =?us-ascii?Q?TbP6sYbJGd+KEKIlqgJzwIdMcGzaKSEJNFubDerpw2Bg?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 418244e4-3c1c-4ac4-72d5-08da7094afb0
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 12:28:33.2500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QmDa1g7VOvTzk2bq5h0gdXn5k+r/8KrD4gvpFZwYWPAcdTEwK+y1q52W5ojmMHBrrWid4LxY0RWELTXPkZYWAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB4051
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 28 Jul 2022 14:09:57 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Thu, Jul 28, 2022 at 11:21:14AM +0100, Gary Guo wrote:
> > Rust requires braces around branches of if expression, and C
> > doesn't. So in kernel coding style you often have:
> > 
> > 	if (condition) do_something();  
> 
> That is not a valid kernel coding style, and our tools should catch
> this and prevent it from being added to the kernel tree.

Thanks, I stand corrected. I do see those patterns occasionally so
presumably that gives me wrong impression.

	rg '\bif \(.*;' $(find -name *.c) | wc -l

gives me 3362 results though. Most of them are from fs and driver
directory so presumably they are vendored or legacy code.

Best,
Gary