Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Liu, Chuansheng" <chuansheng.liu@intel.com>
To:     Peter Suti <peter.suti@streamunlimited.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Javier Martinez Canillas <javierm@redhat.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] staging: fbtft: core: set smem_len before
 fb_deferred_io_init call
Thread-Topic: [PATCH v3] staging: fbtft: core: set smem_len before
 fb_deferred_io_init call
Thread-Index: AQHYoYuplkHDyCTFCkGJGaJymTDkcK2TuxOA
Date:   Thu, 28 Jul 2022 12:49:15 +0000
Message-ID: <BL1PR11MB544569ACF9F4EE383F07959597969@BL1PR11MB5445.namprd11.prod.outlook.com>
References: <YuDlfLeossnntH/C@kroah.com>
 <20220727073550.1491126-1-peter.suti@streamunlimited.com>
In-Reply-To: <20220727073550.1491126-1-peter.suti@streamunlimited.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FVP69A9eTxtmG2HSy2CS5DR+N1TWFL0sC6gad9RSVEXvZb4K7wcHkSHGJqS8?=
 =?us-ascii?Q?GReGHmjHbTZza6G64ebRdwk0FN95/sDOX/xh0zPcBPg3PzQYuWu5K2FMjbSU?=
 =?us-ascii?Q?J89EgGfECrxWC6SNud31sntI0lvN6It/hJlhu0X07FFeS8aXoBNJDK8mQALk?=
 =?us-ascii?Q?zdK0guZcYvQLIAIJ0V9ItVinlXjihRU5kAUdKS+t2yZRIoUjEhCtCOnj1vE+?=
 =?us-ascii?Q?WFO7C+U+dHoQTJ8w5u3fh0s/DnLo3GecVBbMoVzRJqujv3X8Uq05RhY0LPUt?=
 =?us-ascii?Q?YDN6stkAK6I0Osyqf2U7cSBZmGD2MZAgNy7gmLa3K3HZjHNn0pa9cP5vcz+N?=
 =?us-ascii?Q?Q2g1novqAeE0qfPZzDStx3MfaB97m9jKN6jTJqZ2OqccAo1M4h4vdxB1PBHH?=
 =?us-ascii?Q?B12h2LcBJgEovroT+3Xrc2F+a0aa/vIjY98qNBYYJYSC+Q4yUlmTW4Ly4SV/?=
 =?us-ascii?Q?blrcUHduaXsqR1l2EZwVp/JrveMIkUqt8EvW7bwwK7M7P7NosZS8Vg29/+C6?=
 =?us-ascii?Q?8jeKX5oZHUxoG9VH1T8t5/gCJkc2Itp8xsw8uOJVXxFunrLxr6VbUueprvHm?=
 =?us-ascii?Q?bG3Gz/HlOzHDm+dk9miW9Tm9Shuj0g3Fd8y5+RplVjneOcrw6A32SvP0e4Hq?=
 =?us-ascii?Q?eyWwffd2nHKalC6HhVWuyhuD4rQy76U149k6T1m+vStBCGIfFN0LwHrGvz2Z?=
 =?us-ascii?Q?7xmfnY9t3cJ1FT9HTcRLaodsdu0xhciipxDbW91x5FdSWJHjx2Dv7WBws1Xp?=
 =?us-ascii?Q?pwbSc3YjQZAnDqm4rMX67W4JkFUDViwXnfWJn1+YjQYSQA0YXRapY4t2A608?=
 =?us-ascii?Q?qcI4Zmh33S5hMBflwIWAQK19AFEoSyg+Vv/AyNL7/DCchmUDqVgeuR2NY3zP?=
 =?us-ascii?Q?HJNsI3+Gg2DAIxENMs/PXP4XxKV0WcaHilCscZHXwzzSUCEP/sP4kotVcWyy?=
 =?us-ascii?Q?pA0th9+3w440Y2RYyoH8lg1IXW1BJXe5aKJAvOdEUUT37mZfs5XUvBILIwMN?=
 =?us-ascii?Q?WQvefOyrJRLXZtjHEK5NVVElNk8jopinNKdbX4uh/GUcmQ76feuR3zqjUxew?=
 =?us-ascii?Q?tHEqshvC1+jg8yv+E4aIf4r7Ig30tyFbRV8tnwaPUzttLM9dIt7I3DLkB72T?=
 =?us-ascii?Q?GTXw97U5X/oZv+9kTauaKOsBmn9ow68bFm+vZ3SkZw8SOeeNFgAgDECYy//n?=
 =?us-ascii?Q?9NdPrhR785H8hta+V2YT7CUnjbCILUlmHqGJhqUjVxtd5mR8Sp10VbheVfUn?=
 =?us-ascii?Q?/DF9eXNTf5N5AJt4l/OtBDvWF2K8FXBxbfP5aHV9evX/sSbHOlpQ0X4IlUev?=
 =?us-ascii?Q?PbzY7f3bRxdeysKLnhpUPf6nN5ItaQeIKbWNO/PN8ENRDg3unAOIdt8c5s0D?=
 =?us-ascii?Q?yArJ7fzK2ddURs0EfLMdZyMeXznchVmgf1g+lkPDsA/AKeHxNexJ3tMI6JmN?=
 =?us-ascii?Q?OLx0wq+ZkadupOgKVFN7tpy9pnGKg9E883R3zrrjkD9wo/ITbiOLHOjjYSup?=
 =?us-ascii?Q?BlAuqjULVqcR3UvUIK93GmdLCdPpVc6dxctSA0IFsCY0WNa/PKZylwfujDaY?=
 =?us-ascii?Q?6Wxl/7xRcbWR7qJzaJmlJT5ysqGO3QOql+klpAtE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5445.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: beaf851e-9e22-487c-d2f9-08da7097946e
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 12:49:15.8853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qka/pNoPAkDHVqlgcgkDMsiHRW/MtN8CVYBmvwZM9o+FZJNFtijrqKKbOW7TQmrPtnLkwdgL5UQnczt1l0szVVdV3smQOSdeGkxDPZd8bqg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6134
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

> -----Original Message-----
> From: Peter Suti <peter.suti@streamunlimited.com>
> Sent: Wednesday, July 27, 2022 3:36 PM
> To: Liu, Chuansheng <chuansheng.liu@intel.com>; dan.carpenter@oracle.com;
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Thomas Zimmermann
> <tzimmermann@suse.de>; Javier Martinez Canillas <javierm@redhat.com>
> Cc: Peter Suti <peter.suti@streamunlimited.com>; dri-
> devel@lists.freedesktop.org; linux-fbdev@vger.kernel.org; linux-
> staging@lists.linux.dev; linux-kernel@vger.kernel.org
> Subject: [PATCH v3] staging: fbtft: core: set smem_len before
> fb_deferred_io_init call
>=20
> The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before
> initializing info->fix.smem_len.  It is set to zero by the
> framebuffer_alloc() function.  It will trigger a WARN_ON() at the
> start of fb_deferred_io_init() and the function will not do anything.

Please show us the WARN_ON() call stack, then everything is clear. It is th=
e driver itself issue to be fixed.
I saw Thomas made such WARN_ON().

>=20
> Fixes: 856082f021a2 ("fbdev: defio: fix the pagelist corruption")

Don't agree with such description.

Best Regards
Chuansheng