Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp464077imn; Thu, 28 Jul 2022 06:14:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tObigsfYYQ+rmSpJ7/QeMwLfD5zOweGXgGhykVkysz2dgFN2U45rtSLFearyexxUDAlhhM X-Received: by 2002:a17:90b:1c04:b0:1f2:96f8:7db with SMTP id oc4-20020a17090b1c0400b001f296f807dbmr10071758pjb.88.1659014093605; Thu, 28 Jul 2022 06:14:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659014093; cv=none; d=google.com; s=arc-20160816; b=NpKNaohjQNGj32rukdy1/LGZ/t0My+SDCjRTuYQnW6c2To1RvTLkX+cCApxPUX95Tl gnb7xsbtsypxlh3WwBeA+iS7yAHrr9VggrkwY8/Gf69x70nm9aBBQwc+o53Tf5LbPZ9p BFW/LIWmY9diee2Kh9ctBp3anvSZJpF7is1Uhm+oH5DJsy/fBkqfkWfFhfZonGCQLsDn QQ9FfDgHO2RbjLCfpBqvHPMV6knaIQgQaStvd2Nlmlduf8d+yJrIKpAuc/c7WrLyGBVZ qOkP7Kwa0Z1oq4rLIjQ3MecSmrfceq8ZUj2O4iJtkb6FDsgzl0esh2K2ecwPtZyPVXCF 340g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QEAZj/APgtxfKUV/xdABHhUWobi+1OHJAfcrFqm4qEc=; b=FiLMNVtya7TYZYvc4R8gsw53GvqZW0RScoPU0qQCI8ZF1SAdhbsN+xb4UblFcMR/wZ GfWEwer0GQRGJ1zR6kjplOhy7+Fn5BgIqIn+n511DDq89jhVitA+wXR/W6wa/AFQnKRN Bz5TXWL9qMcpWOkKy9qPektHJBOnl5QSzHTJZujkksnbXwV1TLS24bei6qunKkFIO7eE wNbgZNC5mUuOv/T0C3GVs7CBIb4DGRbMQ6OGXeaFcm7ikyulFej+KzKY7hnnDNXLWbZA bbNw7sdUYQSLBWWPywlLF3RUThwHQvmSMWQLil9LkTJq45SVZQ+HF9NtS6H0ZXvVCECX YWXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WjTTZak1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f14-20020a63554e000000b0041b5b1796c0si940035pgm.808.2022.07.28.06.14.33; Thu, 28 Jul 2022 06:14:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WjTTZak1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237206AbiG1MKF (ORCPT + 99 others); Thu, 28 Jul 2022 08:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234550AbiG1MKD (ORCPT ); Thu, 28 Jul 2022 08:10:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6218691D4; Thu, 28 Jul 2022 05:10:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 82BE461C1E; Thu, 28 Jul 2022 12:10:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CF29C433D6; Thu, 28 Jul 2022 12:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1659010200; bh=QuAukCkxiWR/SUA+vxyoVL+LmxWsioU7cNOrz2AK0co=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WjTTZak1v6sCeOffSGHiVS8RZ9mOzk4vS4sJm+ZXDR+G2DE+ksjP6ZyOhr/yJuu39 JqJXlCwjIZT7AfCJJJAFZLyjYHWOnvnF2m0Gmu1BmGCRpOOyWumP0D7OQal6cju5cw nZOCMXxkYQrYPd/LwAsXSzx7FOXHRkDH5TEh+/bA= Date: Thu, 28 Jul 2022 14:09:57 +0200 From: Greg Kroah-Hartman To: Gary Guo Cc: Olliver Schinagl , Miguel Ojeda , Miguel Ojeda , Linus Torvalds , rust-for-linux , Linux Kbuild mailing list , Linux Doc Mailing List , linux-kernel Subject: Re: [PATCH 00/13] [RFC] Rust support Message-ID: References: <20210414184604.23473-1-ojeda@kernel.org> <5c0bb1db-5589-32ca-ac22-4aafb3c15751@schinagl.nl> <20220728112114.0000003a@garyguo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728112114.0000003a@garyguo.net> X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2022 at 11:21:14AM +0100, Gary Guo wrote: > Rust requires braces around branches of if expression, and C doesn't. > So in kernel coding style you often have: > > if (condition) do_something(); That is not a valid kernel coding style, and our tools should catch this and prevent it from being added to the kernel tree. thanks, greg k-h