Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20d86df48af5e0f0f17a1b1bc6b365d1c158280f.camel@xry111.site>
Subject: Re: [PATCH v2 4/4] LoongArch: Support modules with new relocation
 types
From:   Xi Ruoyao <xry111@xry111.site>
To:     Youling Tang <tangyouling@loongson.cn>, loongarch@lists.linux.dev
Cc:     linux-kernel@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
        Huacai Chen <chenhuacai@kernel.org>,
        Jinyang He <hejinyang@loongson.cn>
Date:   Thu, 28 Jul 2022 21:30:42 +0800
In-Reply-To: <1c1b5d2f-84f0-534c-ace2-2da48b5a7419@loongson.cn>
References: <c596e7a73953a1c49e8f5e94ec2db642f72e7813.camel@xry111.site>
         <93087353ec0d23c56345d4c05e3d9719b284942c.camel@xry111.site>
         <1c1b5d2f-84f0-534c-ace2-2da48b5a7419@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-07-28 at 20:41 +0800, Youling Tang wrote:
> Unaligned is handled more efficiently before overflow checking, while
> being consistent with apply_r_larch_sop_imm_field.

Will move unaligned before overflow in V3.

> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0*location &=3D ~(u32)0x3ffff=
ff;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0*location |=3D (offset >> 18=
) & 0x3ff;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0*location |=3D ((offset >> 2=
) & 0xffff) << 10;
>=20
> It may be better to use the loongarch_instruction format to modify the
> immediate field of the instruction, similar to the following:
>=20
> union loongarch_instruction *insn =3D (union loongarch_instruction *)loca=
tion;
>=20
> offset >>=3D 2;
> insn->reg0i26_format.immediate_l =3D offset & 0xffff;
> insn->reg0i26_format.immediate_h =3D (offset >> 16) & 0x3ff;

Will use union loongarch_instruction in V3.  Why didn't I notice it
before? :(

Thanks for the review!

--=20
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University