Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <615b5bc79c9e48409361bde1af9374cacb06ec9c.camel@xry111.site>
Subject: Re: [PATCH v2 3/4] LoongArch: Stop using undocumented assembler
 options
From:   Xi Ruoyao <xry111@xry111.site>
To:     Huacai Chen <chenhuacai@kernel.org>
Cc:     loongarch@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Youling Tang <tangyouling@loongson.cn>,
        Jinyang He <hejinyang@loongson.cn>
Date:   Thu, 28 Jul 2022 21:10:34 +0800
In-Reply-To: <CAAhV-H5nuP2xYREtZuJnq3Sr+JpVbOzLDw+N1ep5yFSUd1+nFQ@mail.gmail.com>
References: <c596e7a73953a1c49e8f5e94ec2db642f72e7813.camel@xry111.site>
         <e95cfe70e2e5faa5b9cdc9452bdb3ab8d664aff0.camel@xry111.site>
         <CAAhV-H5nuP2xYREtZuJnq3Sr+JpVbOzLDw+N1ep5yFSUd1+nFQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-07-28 at 20:25 +0800, Huacai Chen wrote:
> Hi, Ruoyao,
>=20
> On Thu, Jul 28, 2022 at 8:03 PM Xi Ruoyao <xry111@xry111.site> wrote:
> >=20
> > Now we can handle GOT and GOT-based relocations properly, remove the
> > undocumented `-Wa,-mla-{global,local}-with-{pcrel,abs}` assembler
> > hacks.
> I think "-Wa,-mla-{global,local}-with-{pcrel,abs}" may be regular
> options rather than "hacks". If I'm right, the title and commit
> message should be updated. And we can send patches to binutils to make
> them "documented".

How about changing the message to:

   GCC 13 no longer generates la.global and la.local in assembly, but
   produces explicit PC-relative relocations to local symbols and GOT
   entries for global symbols instead.  As the result, -Wa,-mla-* are no
   longer sufficient to control the code generation for symbol address
   loading.  As now we can handle GOT and GOT-based relocations
   properly, remove those options to use GOT for global symbol address
   consistently.