Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Jul 2022 16:39:03 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc:     Peter Suti <peter.suti@streamunlimited.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Javier Martinez Canillas <javierm@redhat.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
        "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: fbtft: core: set smem_len before
 fb_deferred_io_init call
Message-ID: <20220728133903.GU2316@kadam>
References: <YuDlfLeossnntH/C@kroah.com>
 <20220727073550.1491126-1-peter.suti@streamunlimited.com>
 <BL1PR11MB544569ACF9F4EE383F07959597969@BL1PR11MB5445.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BL1PR11MB544569ACF9F4EE383F07959597969@BL1PR11MB5445.namprd11.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6m5bs2U2UflaMvM6agpm12wyA3yswyLiSIeUubLasNxvgQv5m9uagCbTyO0Y?=
 =?us-ascii?Q?U3KlMdDIoJYi3c2ISEJlJmSIHMObWm4BHV+4xolN7+YrzOnN+k1cjY04UyLO?=
 =?us-ascii?Q?b3yrGtPwzJ+jh09DYzX8NWJ1KUYWyUHaLNqDBxBaPUv+QZMhn+etOzJcGY6U?=
 =?us-ascii?Q?lBJqRyZmYBF+x/tWTogmhKHuDy5e3J63irdXv8Ywd4O7yeyVCUKp4UPp5a5Y?=
 =?us-ascii?Q?f/ajDmAB6mlxM2Iaf1AgeFSl65HBDClJP43UcfDbjUc2dRKt+A7XqObhoaZ/?=
 =?us-ascii?Q?djgj7OJmg/QSlfNVoB/dXW3tjYT8xTbef7WdoFGce6XePwW73qddTisqHbr4?=
 =?us-ascii?Q?pBTmG8kxKNwCGQKHMw7nehMKrTnnZWW1haBwOzm+CKn3GMODEs1jACKnZs/Z?=
 =?us-ascii?Q?ZxagtOEcPK+BVi3EYupAEEqj731bqzFn27Ygj6dH82zHuysr7fr7rwgOTC8K?=
 =?us-ascii?Q?phNHDWOjKh865XjYLYFf0EjNYJx4/rSBlmINyHPJ8SHGgUBQLcxGSLcCCbS2?=
 =?us-ascii?Q?eulaVZ645nbu0z7PS2zjYvQr8pxJ/vP0cj6LwdO3JEqfcP4AR0768wd6G1YF?=
 =?us-ascii?Q?GTUZDtGccpF/zblCwryL9fX2cN7VRkh+J5rALw/cBYA6bN0m5oJmLRl4Sc63?=
 =?us-ascii?Q?cWK5hM3eWC+jhvbk8A7d1YiAmvbNs4guqBfRYKO/EgvSqvY7C9H8gG+VNztJ?=
 =?us-ascii?Q?JNvSxGerTyUqE/gHPoKPckHz8DgQ2Ce9zI538h43Zg6I2LMbVXXxMkDamueZ?=
 =?us-ascii?Q?MTW0C1c/I+GtKKnQZRijJECiZQCpBMr+ZPVfOIt140GJufkqp7QNRmBOwBOR?=
 =?us-ascii?Q?Q5ZezHICCvbFGrqd7l2rYTERdxNuFVy+oBQ4dUCJ+T6HB3MHVQuGIzNffjIB?=
 =?us-ascii?Q?Z0IG2T2HRMKZzAUQcxuW6MEolFKd+hoGh3cSjN3tp3bXdXXs1nmb3uDAyLju?=
 =?us-ascii?Q?Dw0q4VsgPHiuwP6Sdkja8PoLxBS4Soutlbh8SOc/v4CV/CU8iSsKVpDpBYHP?=
 =?us-ascii?Q?Ze3eAKGO6KLB2oY7+CW+A5Q0y03pL7BIyLxktY5yrcdlLqkG1Q7FfhMTtDda?=
 =?us-ascii?Q?UQlFRDJSAlwgSZsOlM7g4/K2+801yXeYINiIJu8b5+ss14C92QVkL49GzkAz?=
 =?us-ascii?Q?nYiprefFHYY4T8+CImnOBKWvvUYdHMTMp/rDhMOYeO9VRp2hLzvycZwo8Rf/?=
 =?us-ascii?Q?e5qyybVPbV96BFRIcu7JENspOThMndNTbE4vzjam/d0sGYUP0CTu0NDw6S/i?=
 =?us-ascii?Q?Wp5MbJfOWEx0AmmGKpORcZjwddNcFnD930kw6ANbVEk3vadQEtRG3xOPoqio?=
 =?us-ascii?Q?Xy6NCjDlyxmaSkXOL8JOwCrUBGXkpwne/4alKvAhxFyiWkGzKUGqw04syFWx?=
 =?us-ascii?Q?lsGadcwXvntlJNg0GqDzrrFY5KtVzzC2hEcB9tpBJ57D569u9SiEw1Wzcjf6?=
 =?us-ascii?Q?25o2mIrT4bRIqxaFzQw/ftJ+cvWtcQPHDT5XKsc9mZWuHLeq9PRRgArlOvsU?=
 =?us-ascii?Q?xLdvUs22qKyajCOpG2mJr5UoveAqxbaz9R+g+6YdXVP/JhmRsTOFkW9ZpCax?=
 =?us-ascii?Q?boeaphX85hzTEztWVW49RXGhyZU8oVlOvwJB+rp8hiSZ87QbHcqY6v+T+tGS?=
 =?us-ascii?Q?7A=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f665f8ac-3291-4ed9-4b42-08da709e958a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 13:39:24.7201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GfN0UJ98FJXAXtioNFkJ+PX8E7g+F0XxA4Z7EasJ9wV0ODUilo7nmExvlgkYQlNgf1xTif10d1XpjWGDgbvfOAezzkAJv8FGBrn6LqIzd9U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2185
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-28_05,2022-07-28_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207280061
X-Proofpoint-ORIG-GUID: qgLaJsKG9qwECGt38vlcjaRT4wBeBLK3
X-Proofpoint-GUID: qgLaJsKG9qwECGt38vlcjaRT4wBeBLK3
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 28, 2022 at 12:49:15PM +0000, Liu, Chuansheng wrote:
> Hi Peter,
> 
> > 
> > The fbtft_framebuffer_alloc() calls fb_deferred_io_init() before
> > initializing info->fix.smem_len.  It is set to zero by the
> > framebuffer_alloc() function.  It will trigger a WARN_ON() at the
> > start of fb_deferred_io_init() and the function will not do anything.
> 
> Please show us the WARN_ON() call stack, then everything is clear.
> It is the driver itself issue to be fixed. I saw Thomas made such
> WARN_ON().

I don't understand the confusion here.  The code is very simple and the
description seems very clear.  No need to redo the patch.  I think
Peter tested it before the WARN_ON() was added so he probably didn't
see the WARN_ON().  I told him to add that because it's pretty obvious
what will happen just from reading the code.

> 
> > 
> > Fixes: 856082f021a2 ("fbdev: defio: fix the pagelist corruption")
> 
> Don't agree with such description.

I don't see how you can disagree?  Before your patch the
fb_deferred_io_init() did not use info->fix.smem_len and now it does.

regards,
dan carpenter