Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <52b9d7c9-9f7c-788e-2327-33af63b9c748@openvpn.net>
Date:   Thu, 28 Jul 2022 15:16:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco)
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
References: <20220719014704.21346-1-antonio@openvpn.net>
 <20220719014704.21346-2-antonio@openvpn.net> <YtbNBUZ0Kz7pgmWK@lunn.ch>
 <c490b87c-085b-baca-b7e4-c67a3ee2c25e@openvpn.net> <YuKKJxSFOgOL836y@lunn.ch>
From:   Antonio Quartulli <antonio@openvpn.net>
Organization: OpenVPN Inc.
In-Reply-To: <YuKKJxSFOgOL836y@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Andrew,

On 28/07/2022 15:07, Andrew Lunn wrote:
> Also, using a mainline driver out of tree is not easy. The code will
> make use of the latest APIs, and internal APIs are not stable, making
> it hard to use in older kernels. So you end up with out of tree
> wrapper code for whatever version of out of tree Linux you decide to
> support. Take a look at
> 
> https://github.com/open-mesh-mirror/batman-adv

Yeah, this is exactly what we are already doing.
We're just trying to keep is as simple as possible for now:

https://github.com/OpenVPN/ovpn-dco/blob/master/linux-compat.h

Thanks for the pointer anyway (I am already deeply inspired by 
batman-adv, as you may imagine ;-)),

-- 
Antonio Quartulli
OpenVPN Inc.