Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84923720-30a6-1a49-48f6-96e078a46743@linaro.org>
Date:   Thu, 28 Jul 2022 16:10:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 3/3] dt-bindings: phy: add definition for MSM8960
Content-Language: en-US
To:     Shinjo Park <peremen@gmail.com>
Cc:     David Heidelberg <david@ixit.cz>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220728111740.30595-1-peremen@gmail.com>
 <aef9bae5-b72b-d520-a8e5-8f6a838775eb@linaro.org>
 <CAAs2AW7A4RfxAaKPsmJjA1s7s5_rnM2O4XAAFC=7x1Npttg5rQ@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAAs2AW7A4RfxAaKPsmJjA1s7s5_rnM2O4XAAFC=7x1Npttg5rQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28/07/2022 15:54, Shinjo Park wrote:
> Hello Krzysztof,
> 
> Sorry for any confusion during my first patch submission.
> 
> PATCH 1:
>>> Change the reference of sleep_clk to the same as qcom-apq8064.dtsi.
>>
>> You add label, not change something.
> 
>>> - sleep_clk {
> 
>>> + sleep_clk: sleep_clk {
> 
>>
> 
>> Since you touch the line, make the device node sleep-clk (device node
> 
>> names should not have underscores) and mention this in commit msg.
> 
> 
> I can change the line into "sleep_clk: sleep-clk". And the commit message
> would be "Change the device node of sleep_clk to sleep-clk and add a
> label"? Another problem is that in the same .dtsi file there are other
> device nodes containing underscores (cxo_board, pxo_board). Should I also
> change these in the patch?
> 
> PATCH 2:
>>> +                     phy-names = "usb-phy";
>>> +                     status = "disabled";
>>
>> status is the last property.
>>
>>> +                     #reset-cells = <1>;
> 
> I can move #reset-cells one line up and make the status last line. On the
> other hand, the same definition is also used in
> arch/arm/boot/dts/qcom-apq8064.dtsi (also the clock definition mentioned in
> PATCH 1). Shall I include another patch for that file in the next revision
> of this patch series?


Yes, you can rename them in other patch as well.

> 
> PATH 3:
>> 1. Thread your submissions.
> 
> Shall I use this thread for all follow-ups for my first and second patch?

No. One patchset, one thread.

https://elixir.bootlin.com/linux/v5.19-rc5/source/Documentation/process/5.Posting.rst

> 
>> 2. Use subject prefix matching the file.
> 
> If I understood correctly, then this should be "dt-bindings: phy:
> qcom,usb-hs-phy:"?

Yes.


Best regards,
Krzysztof