Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fbf213f2-f118-ccfa-3faa-ec8b2182595b@intel.com>
Date:   Thu, 28 Jul 2022 06:47:01 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] x86/sgx: Improve comments for
 sgx_encl_lookup/alloc_backing()
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>,
        Kristen Carlson Accardi <kristen@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        linux-sgx@vger.kernel.org
References: <20220720182120.1160956-1-kristen@linux.intel.com>
 <YuJBjq/4dALm//rf@kernel.org>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <YuJBjq/4dALm//rf@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/28/22 00:58, Jarkko Sakkinen wrote:
> On Wed, Jul 20, 2022 at 11:21:19AM -0700, Kristen Carlson Accardi wrote:
>> Modify the comments for sgx_encl_lookup_backing() and for
>> sgx_encl_alloc_backing() to indicate that they take a reference
>> which must be dropped with a call to sgx_encl_put_backing().
>> Make sgx_encl_lookup_backing() static for now, and change the
>> name of sgx_encl_get_backing() to __sgx_encl_get_backing() to
>> make it more clear that sgx_encl_get_backing() is an internal
>> function.
>>
>> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> The rename is unnecessary.

Well, it was done to address some reviewer confusion:

	https://lore.kernel.org/all/YtUs3MKLzFg+rqEV@zn.tnic/

I wouldn't call it unnecessary.  Heck, I'd argue that the one of the
main reasons that this code leaked memory in the first place was the
naming and lack of comments.