Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v4] irqchip/ls-extirq: fix invalid wait context by
 avoiding to use regmap
To:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        linux-kernel@vger.kernel.org
Cc:     Lee Jones <lee.jones@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Arnd Bergmann <arnd@arndb.de>,
        Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
        Biwen Li <biwen.li@nxp.com>
References: <20220728144254.175385-1-vladimir.oltean@nxp.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <501b52ba-7691-0263-c007-38174c7e5c22@seco.com>
Date:   Thu, 28 Jul 2022 11:25:23 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20220728144254.175385-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTFOVWFiU3V0NDZ6WDVMaG8xeHRvVXh6b1Fsb1F6Z1BRMkllSkY4bVdpazc2?=
 =?utf-8?B?TEpYakpvc2xLWDNzZWovZlg4MklCSWxMQWNtZTI4eUNhZkRhWjI4NERPeWVG?=
 =?utf-8?B?d295d09yMWQ1NHV0K1FzeE5kYmJvL0ZFcGJweUtVU1VkZFJ0cXpWZ1dnZUY1?=
 =?utf-8?B?dlNyYms2dDdLcENidmZQSWtFdlhWSVExR1JPTi9kWDhaYVBOM0tLeS9sVXkv?=
 =?utf-8?B?WTRWS0s1Q2ZsVmY3cHF3UzBYYWl6WGJSaE41YXY4QzloenJhY1E0aHZiTFRx?=
 =?utf-8?B?a2ltNjMyUWhtWnlTUWdPSWdZR0JvcHhtc1MrVlZUUkR1NjA2eGt0eWpXbW0z?=
 =?utf-8?B?Y3hhRWVXYkRGRWozUytRSWNmKzloc2FXYnNMZnN0WERDUHAxNzc2UTNEaFJ2?=
 =?utf-8?B?MFBaVitRWGF3NzBWWTcxbUIxN1ZMRml3MzZiTi81b2g1bUQ3QkhvWGtJc0hR?=
 =?utf-8?B?b1AxMGxZSnJaVzBHaUFVL3cvNjdxQlZEdlNWSzNvclBPSkl2TVNPUUhpY2dI?=
 =?utf-8?B?YnEwa0dOdEVYNERNQ2gwcHFWdEVMaWJLdkZ5bm4wU1ZhM01sVEpYa2Y0NWs0?=
 =?utf-8?B?eUVJRXZvMlk0a3gwSHAya3hEemYrRTFBTmNKd0djZElTWUo3VU01Q0tTWVEv?=
 =?utf-8?B?dUxZNWpWaU4xcldFMVZvZ0puaFdPT1paTnhPaHFINnBnNTBGbGN6YUZwNXU5?=
 =?utf-8?B?aVdqQmUyYTJ3cHBaRkw1eWY5Q0xlSjFGMDBBTTdJaHlkQXVJOWdvcW1Qc2g0?=
 =?utf-8?B?K29tMGFxSzNCbTRxSFFrS29BMlVhQnpsZXo5cDBoUGZPWHo4dk9KVWQvWFM1?=
 =?utf-8?B?SXZDcnArMmJyV0tJcGd4U3QyNThRR0w1MldhQWFrMlQrdHF0a3BFRVVWOEhq?=
 =?utf-8?B?QUdXWC83cTJlaTBrRnpGQnFzdVN5VG9Sd2hRb3pPemRxV2Q5d2ZGZkZvZTdI?=
 =?utf-8?B?VllFQjkzS1VCL2hQQ0hGZTViNnZTOWVmNDdEanVzSEV5d2RFQjJoN0FNY2pH?=
 =?utf-8?B?dGR1dzdQY2srODFCak4vdHZpb3FXd1RuZ25QcG1kd0lyVndlTGoyVHlWdEJm?=
 =?utf-8?B?Tkgzb0p3MjhFNG1HTHp4aVcyM29xd3Y4Q2FDMk1rNzNySWk5VFNCalBvQ0R0?=
 =?utf-8?B?ZlVNRjI0YmJPTUlSbm9uMmRTakhMVGlxSG5oancrT01ycjFLL05sem5uelQ1?=
 =?utf-8?B?eHpIbm1ZTmtoMk9XSjhIdWswVWhmRWFRWDVSRHBaeER3MU82V3NwRWtteUo3?=
 =?utf-8?B?OWlSK1RGMWhvdUdqTWorR1dST3VhMTFGcS9uU0Rmb2RFNk9JSTd2NElGYkdI?=
 =?utf-8?B?VHlRWStSZ0RPcnY0QnZpUTM3TlJWYkZqR0lmZVZtaGRMMzRPNVVLU0dESmxt?=
 =?utf-8?B?eGNadWNMWlBTd05RL0JsZEN0R0RkR0Z4L2JReXRzUVBtUkVZa2xKTDNmcUNv?=
 =?utf-8?B?ZUxXU3NQU0NwbS9qZ01UeGFkVHpTTUFkTGY2WDJWUmc2ZWEvekJRWlpSUk9K?=
 =?utf-8?B?VFFrdzNidkd5UmxqU3RTTE52SWtvdGVKeFVKWkRzcVExMVRuUjJ4QnVYWTN0?=
 =?utf-8?B?V0hYZ2pmVlBOVmhGekVDSFFuWmI2SCsweXFpTitmQ1doSnVkVm1uN01zVzlu?=
 =?utf-8?B?NitGczhJWjcwMTlUVm13REhZaDIxY2txRzY2Z2ViR0Z0cXpqNzFTRm01K0dG?=
 =?utf-8?B?cUoxZUNXQ2U3VUxJWlhZamtkMWxJU0hoZjFnYXdENVFlN0dsY1hjUEhoZXFF?=
 =?utf-8?B?VUpJa0U5NEg1SWsxN2N4T3RwQmRIaHNmS2c4UXlvR2NMWEt4MEROTjNCOEZX?=
 =?utf-8?B?aEV4eldMVWpXNURrdEZ0NHA0QUVUYlRqQVNXb2k3cUZQTEVEUlcvbzB0bHVV?=
 =?utf-8?B?UmlkMkoxaEZBYW0rdGNycnVhdjdjOGpvQ3MycHpqVVpjQ0NSeTYwYUlkbDdy?=
 =?utf-8?B?Z2JYbmhoQmZoUGtMakhMQ2lvVzZUMkxCVWpVTmEwU29SVjY4S01qbncxejZk?=
 =?utf-8?B?VllNeE03V3UxVmgrWkNGSGwySUJVeEthODlaNHhsV2V5aytuZlZXUHN4MCtU?=
 =?utf-8?B?am9Oa3dRR2VuRUcydXBiZUtGbS9Mak9PN0tWVXNKNWVieVZGdnYySWY3cU85?=
 =?utf-8?B?ajIzWjZoM2FIMWdZTDUwNWlBVEZhSHRKWTU4YTFTSDRZVWVySUdPT2xKd1ZM?=
 =?utf-8?B?Mnc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35b22333-9487-43b9-886c-08da70ad6823
X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB4973.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 15:25:30.7189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XDtbJQBQwDPzCozHy9NcIFoh8BURETifcUTQgISVjF/4MlDjPUCvKE9p+QSoTZDOL5WfI8PEUgLydNbXpoKSKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB6352
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/28/22 10:42 AM, Vladimir Oltean wrote:
> The irqchip->irq_set_type method is called by __irq_set_trigger() under
> the desc->lock raw spinlock.
> 
> The ls-extirq implementation, ls_extirq_irq_set_type(), uses an MMIO
> regmap created by of_syscon_register(), which uses plain spinlocks
> (the kind that are sleepable on RT).
> 
> Therefore, this is an invalid locking scheme for which we get a kernel
> splat stating just that ("[ BUG: Invalid wait context ]"), because the
> context in which the plain spinlock may sleep is atomic due to the raw
> spinlock. We need to go raw spinlocks all the way.

Could we just use use_raw_spinlock in the regmap config?

--Sean

> Make this driver ioremap its INTPCR register on its own, and stop
> relying on syscon to provide a regmap. Since the regmap we got from
> syscon belonged to the parent and the newly ioremapped region belongs
> just to us, the offset to the INTPCR register is now 0, because of the
> address translation that takes place through the device tree.
> 
> One complication, due to the fact that this driver uses IRQCHIP_DECLARE
> rather than traditional platform devices with probe and remove methods,
> is that we cannot use devres, so we need to implement a full-blown
> cleanup procedure on the error path.
> 
> Fixes: 0dcd9f872769 ("irqchip: Add support for Layerscape external interrupt lines")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---