Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Arnd Bergmann <arnd@arndb.de>,
        "Z.Q. Hou" <zhiqiang.hou@nxp.com>, Biwen Li <biwen.li@nxp.com>
Subject: Re: [PATCH v4] irqchip/ls-extirq: fix invalid wait context by
 avoiding to use regmap
Thread-Topic: [PATCH v4] irqchip/ls-extirq: fix invalid wait context by
 avoiding to use regmap
Thread-Index: AQHYopBXddIttVt6zkGyOalTC33MGK2T52GAgAAAzYCAAARPAIAAChgA
Date:   Thu, 28 Jul 2022 16:19:50 +0000
Message-ID: <20220728161948.gzc7kekygrfdumq6@skbuf>
References: <20220728144254.175385-1-vladimir.oltean@nxp.com>
 <501b52ba-7691-0263-c007-38174c7e5c22@seco.com>
 <20220728152815.6h4ytx52ll2gzjj3@skbuf>
 <532c8141-2a8b-6842-c9a2-cc4d17afd73d@seco.com>
In-Reply-To: <532c8141-2a8b-6842-c9a2-cc4d17afd73d@seco.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bBIugu6MsAq0DUKP7fyQy5lpJxIrkL+r2sPJd8pHlPV2kaxoSs2zdjfF87Tv?=
 =?us-ascii?Q?iJh5cJvD0xZG7MVo6D4axGS6yiqjOAKxKHKHLAOQ1tX7o+TAux2vCKDKbmAb?=
 =?us-ascii?Q?7qMz6KMHi0EBUIWaHmAo678wgLP4nFHoedtw/nOSxlIfyJOA2sTvVJIIPlYR?=
 =?us-ascii?Q?8jjEi4oVSRfvbnAfbYQT9oSsFLeyhKCuE/3e5Fd6P7x29YC6X2myrbsdbzWP?=
 =?us-ascii?Q?22lvkRX/dw/YegEWle+/GVWtf88G6+y5sex5K6sc504aUiZYrUx+EDRcg2VF?=
 =?us-ascii?Q?HmFU7C8fROIloYdThrjpPAJZYGYglzuWwz7yH+ZI5p0YsZQ7WDyMAHcj5ifA?=
 =?us-ascii?Q?vb1BVORapaBOkQz0RckB1qxPvkSIgiWwkf4MJ/QyTq1Zb8Cs/vTTorLbIhwN?=
 =?us-ascii?Q?l9BntksdorLCoUe+3emTEXeM+4LgD7mYpwRnNJd4G4+ePO4NwX41RaWJQPcY?=
 =?us-ascii?Q?zunnqKWPNZoJuFmokIEDYbA9DCfPkGrZpi8MJyXALQyVcY6kmgSRMUm1JGxh?=
 =?us-ascii?Q?UlYUvgmuMaX0ZgyPxjUE5+k8jJeYOiFQLyXwjU9RONX2vsMd7IqRkPa4PdOl?=
 =?us-ascii?Q?aLktkPCrNGUbfrvoUshS4SKeM/aQk7Y9jF5ToSXaJ2uGzv3/Eo8g49t4b1Bc?=
 =?us-ascii?Q?0tfkawFfPJfk0FcaagaXqfSiKf3em9BKxCmzYXCZcnKIGtp/3IyEBk6k3EaN?=
 =?us-ascii?Q?NuGHKc6lhv5wG5jE1xrTTdnYHRMvFlOfPUuP1Yv0xMuSr0Fnglpea18BHhIq?=
 =?us-ascii?Q?3uGzSJzQMh9bi5Yhw6ml1G9um3SAEwDAhtzYogKKftU791a3GxujH5jfKleV?=
 =?us-ascii?Q?x6BsLlC5X4eq76S3S1s5z2aIp9cAw92fxPGTLrt+tc25yvTaiN8JzfMiDH+2?=
 =?us-ascii?Q?x+flUVX3tBrGqksF4APYLKvkoY23JQdtbf8Z3vZIC5jAOhVF23D59iDrL4k8?=
 =?us-ascii?Q?ryehbdJ6NwVO8wZtcs3Zo0XyXi+csqA2kWNS3giR3HjUlG8k19UPRlTpJO2h?=
 =?us-ascii?Q?rJF91kW0file3YJuVVkzR7WB0DGr5mbqJjQw8ZxzCwoA1HGQhPhvnMmFWjQ1?=
 =?us-ascii?Q?dQVgnohPcIo+KpF06dJWpZIxAdo30TdPzv7/LRYz6QiYvff66xEkgdkp4NB7?=
 =?us-ascii?Q?XBUx22+GVINERKzhBR0SS8puldUEd2+pmYUn4XudmCfPM0GiE8UdaLQMpFlh?=
 =?us-ascii?Q?C5OSp5xJykln/SYEJCl9DFmSiu6wHaRWBxrzGazTBmfXbfkue1faAjSIGdVR?=
 =?us-ascii?Q?EsFTvZoU2Uw6PYCjPqKBH4xa4dFkW4TeG4ntnjjSiRrpmeuxmuYlmh1DUbBM?=
 =?us-ascii?Q?R0NafqrihpGZ4LSrBrb3OP1zS/9vI1iwfKYZe/F6lOVkYgpS8xfZjOStLzwh?=
 =?us-ascii?Q?cUAwdpB5RNxAFKr1MForxgDcrekaQZlSDOsrM+N+Zz9+aBl20UmlmpPnpLfT?=
 =?us-ascii?Q?FyfITNrghfwGoYby9ToDzFzZMI2eElLRUa0ZWgiQmp333QisUdV1aKn5M7Y5?=
 =?us-ascii?Q?/3zLKKqH26ZkzTD/wfeKeWbDOmnl/PRTspKFp1ChsuQPMmNPyrBsvp3RrgVO?=
 =?us-ascii?Q?4s5agAJ6v3kpWKsvXzi6G8MTIImeqOG09/Q1hQX654SuczQuhrL1cpgJFEyi?=
 =?us-ascii?Q?sA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <490D9F14A2B4324F96CAC717341F3935@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5121.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88969825-3540-4a78-16a7-08da70b4ff0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 16:19:50.1284
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BxgWjFtKMvrH6pibva5F16/C+vX1KdJWnJitL3qGXeq0p+oasTDGtn0ku7dEovCYfVkxTHRKf49BV/32BQ6hPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6263
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 28, 2022 at 11:43:40AM -0400, Sean Anderson wrote:
> > All of this should be rewritten to use of_device_is_big_endian(), and
> > reduce the whole thing to two cases (I don't think native endian makes
> > much sense anyway). I also wonder what the result is if none of these
> > properties is present...
>=20
> I think regmap_get_val_endian would be better here.

It needs a struct device.

> >> +
> >> +	priv->regmap =3D regmap_init_mmio(NULL, base, &extirq_regmap_config)=
;
>=20
> It could also be done automatically if we pass the syscon dev instead of
> NULL. The only downside is that some regmap error messages will use the
> syscon device

How do you get the struct device of the syscon?

> > Finally, what is the actual benefit of using a regmap here? It seems
> > like a very roundabout way of performing a RMW on a register whilst
> > holding a lock... Passing NULL for a device to regmap_init_mmio() also
> > seems to be an extremely rare idiom (only 5 cases in the tree), and
> > this doesn't seem completely right to me.
>=20
> The benefit is that you don't have to write (yet another) set of
> endian-converting read/write functions. The above (non-NULL) usage of
> regmap_init would also address your criticism here.

I don't have a particular attraction towards using regmap for a single
register either, to be honest.=