Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp644579imn; Thu, 28 Jul 2022 11:21:59 -0700 (PDT) X-Google-Smtp-Source: AGRyM1txX15IloaM0gnQlrDyYeLpPnLEZtfagQ9aQ5Apcc6+8OPnXrle09TzuWEBFpaPaX9ds5bV X-Received: by 2002:a63:4d4f:0:b0:412:a02e:2896 with SMTP id n15-20020a634d4f000000b00412a02e2896mr18931pgl.337.1659032519142; Thu, 28 Jul 2022 11:21:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659032519; cv=none; d=google.com; s=arc-20160816; b=veAYMAX/rac0kr58/rJelj2O2o5/9P9vH3OF5okRU8Azjize+C8dAqyEHFvDM/WraM t7jEJc+ow7fwfU9VaX6MYYDHygHJAII9XFYxPjHcZOBI23dODe50XVAns6XYq/Da659u cJOwBt2qv/ZRYtZRe3cGrFR9u6nzE9lqnZ5LOn40O1/kzkLWLLqh1OGCndQWboQapgpk i1SRVKNcJmKcoAxVHc/aBlcY620tb0lri1AwFEzH6zhzfxjspJhsIUnv5xj/Q6/xbUex WdVHTQA1x8jfzu24PWqS7xc3KP0kCgh8Sq4faNQSwHqahDcPo2sgGexiiX0SDtDkSH6q Oo7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=VbEpbcnRCKhYT7BZ0HSKVgFvbMAakayClnOZvBHVLDM=; b=uC0sBGVGGmIFVosGrUh0cnZn6Z6O+rGi2TFP/R9MMlOF3ss423WeFl7WzUXOwVtkv0 A4YKrQ6EwbwpZ2nRnflRM2WJdTa2Sh5IUCpzfnpB7vGaGp73H324pJGkOEdrSvBYs02I GRiUzVAAbfZgljqAVhwjY29NTMoi40Z2XWGd5wqI6vkxrp2eREFYDANu7oQk3hgErnLK anSfl8gme7vyT+yiEwwDV7vXqDgZE+KUAyg5oZdhoIre8sQzm0GQPdw8Dic19Ml55n0Q rdMAM9Mj6JGuWMDpipP4TH3lprKZtLzuoUbTfWO3YMlSIvbKKXhbVq65wS6m1QhMgh2q w0CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=i00rVjg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bk10-20020a056a02028a00b004129de98629si1708852pgb.784.2022.07.28.11.21.41; Thu, 28 Jul 2022 11:21:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=i00rVjg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232681AbiG1R1b (ORCPT + 99 others); Thu, 28 Jul 2022 13:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232571AbiG1R12 (ORCPT ); Thu, 28 Jul 2022 13:27:28 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FBCABF44; Thu, 28 Jul 2022 10:27:28 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id x10so1669264plb.3; Thu, 28 Jul 2022 10:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc; bh=VbEpbcnRCKhYT7BZ0HSKVgFvbMAakayClnOZvBHVLDM=; b=i00rVjg3DaYMhQYt2uaTPpDZXUdlQ+KaCLpjoz3IEIhO1KJkqSkwWpy1/U7Uf/F/aD nmFgTkH1TiexdN5J0xFNoxsNwasPcbARyEDdluyAxzkqtOoUZni9gh2nJsVmmZVUf4Xt cV/aq3fSAIIAqz8k9rp+jo+k1XdHNaYlqrx0nfsdz0stk4DaDTrhBl4iyUw7qpidmOac GGvOSFwVaZrE6LDxLSV1yebcuuUAeZ3zPpMZWUBNFispkFDqlVx2Rk5aLw7LNWPr+Tw7 ldPZYan//l8svd7n01XrDz4bRjQrKC3gazwQ+N+G9xjNJxI+R0+fooIua330gEkmXpku 6JWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc; bh=VbEpbcnRCKhYT7BZ0HSKVgFvbMAakayClnOZvBHVLDM=; b=YnsCkskJY6Q5ebe6ZSvcmHnQMwriBaQ+jnMKwm+BEp9S90a0anBmTsnHePxanFAK6A mayuBBCLRAzNBgU1SveLqaIG+P7n/unFD+bXj9Z/kpESOX9iEgZMkhDBS/XPls+dpIz+ EeZ7MIm0guE+YELKT0Ib8VWNEN2Dgprm3Z0Y9R/QHSYlG5Y6sytLQnh0AUY0lwAJYdVI NVU3tcyW9/HUMiTA03ypNwrgfhBoJ0aN8nxCB5rr2xGtoykq3f1o1stpZpakiQoOO8x/ y9HKll6k6qynWjh3HT/IDTRSahR1A4bNXabaNQbIsLsASMR7tI9BSzZmbRg7d7xbJTyP xbxw== X-Gm-Message-State: AJIora9nqhHEqt+oODMkXzH8nk2IGOYljrdEjRl3djZKTnHkzmJGThDU y6kvt7yP6ph4myQn1q8z0KI= X-Received: by 2002:a17:902:bd8a:b0:16c:dfcf:38ba with SMTP id q10-20020a170902bd8a00b0016cdfcf38bamr26699504pls.35.1659029247629; Thu, 28 Jul 2022 10:27:27 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id m5-20020a170902f64500b0016cd74e5f87sm1546605plg.240.2022.07.28.10.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 10:27:27 -0700 (PDT) Sender: Tejun Heo Date: Thu, 28 Jul 2022 07:27:25 -1000 From: Tejun Heo To: Waiman Long Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Zefan Li , Johannes Weiner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] cgroup: Skip subtree root in cgroup_update_dfl_csses() Message-ID: References: <20220728005815.1715522-1-longman@redhat.com> <20220728005815.1715522-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728005815.1715522-2-longman@redhat.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 27, 2022 at 08:58:15PM -0400, Waiman Long wrote: > The cgroup_update_dfl_csses() function updates css associations when a > cgroup's subtree_control file is modified. Any changes made to a cgroup's > subtree_control file, however, will only affect its descendants but not > the cgroup itself. So there is no point in migrating csses associated > with that cgroup. We can skip them instead. > > Signed-off-by: Waiman Long Applied to cgroup/for-5.20. Thanks. -- tejun