Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934313AbXFFFKh (ORCPT ); Wed, 6 Jun 2007 01:10:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755171AbXFFFK1 (ORCPT ); Wed, 6 Jun 2007 01:10:27 -0400 Received: from wr-out-0506.google.com ([64.233.184.229]:63025 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbXFFFKZ (ORCPT ); Wed, 6 Jun 2007 01:10:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sVrVlhYndVOUQgXuuFdeIrME+kGj3uqQmE07c6W68Ws7FIgWveaqrQRBYsRgXiZOJdSAP73hhxOD+uDSk75cw0YmCkxI7v51pZAdjOJfTeZxZL3LbN3/D0Y6Ndjx1QesQ9uV93gDv2UlvQs/3qwSrJCJW6vQD0aoRZl4/NSlbGs= Message-ID: Date: Wed, 6 Jun 2007 05:10:24 +0000 From: "young dave" To: "Andrew Morton" Subject: Re: [patch -mm] alsa mixer_oss kfree fix Cc: "Linux Kernel Mailing List" , "Jaroslav Kysela" In-Reply-To: <20070531191005.292efbdc.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070531191005.292efbdc.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 585 Lines: 22 Hi, Andrew > kfree(NULL) is legal, and is often used. > Apart from the null pointer, IMHO,there's two problem need to be fixed, I'm not sure. What's your opinion? 1. the label indent should be removed 2. similar code use different label, some use " __unlock" but others use "__unalloc", "__unlock" seems to be misspelled. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/