Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 28 Jul 2022 21:46:50 +0300
From:   Ivan Bornyakov <i.bornyakov@metrotek.ru>
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: microchip-spi: add missing module author entry
Message-ID: <20220728184650.6wa5zwbrciatfsba@x260>
References: <20220728075012.3136914-1-conor.dooley@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220728075012.3136914-1-conor.dooley@microchip.com>
Precedence: bulk

On Thu, Jul 28, 2022 at 08:50:13AM +0100, Conor Dooley wrote:
> Add the missing MODULE_AUTHOR entry for the Microchip spi-slave FPGA
> programming driver.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  drivers/fpga/microchip-spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/microchip-spi.c b/drivers/fpga/microchip-spi.c
> index bd284c7b8dc9..7436976ea904 100644
> --- a/drivers/fpga/microchip-spi.c
> +++ b/drivers/fpga/microchip-spi.c
> @@ -395,4 +395,5 @@ static struct spi_driver mpf_driver = {
>  module_spi_driver(mpf_driver);
>  
>  MODULE_DESCRIPTION("Microchip Polarfire SPI FPGA Manager");
> +MODULE_AUTHOR("Ivan Bornyakov <i.bornyakov@metrotek.ru>");
>  MODULE_LICENSE("GPL");
> -- 
> 2.36.1
> 

Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>

Yet, I'm wondering in what situations MODULE_AUTHOR is needed? I've
submitted a couple of other drivers without it, should I fix them?