Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c690a60-103d-47c6-022a-5f2588c1fd87@openvpn.net>
Date:   Thu, 28 Jul 2022 21:16:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC 1/1] net: introduce OpenVPN Data Channel Offload (ovpn-dco)
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
        David Miller <davem@davemloft.net>,
        linux-kernel@vger.kernel.org
References: <20220719014704.21346-1-antonio@openvpn.net>
 <20220719014704.21346-2-antonio@openvpn.net> <YtbNBUZ0Kz7pgmWK@lunn.ch>
 <c490b87c-085b-baca-b7e4-c67a3ee2c25e@openvpn.net>
 <20220728092848.36c6ccd5@kernel.org>
From:   Antonio Quartulli <antonio@openvpn.net>
Organization: OpenVPN Inc.
In-Reply-To: <20220728092848.36c6ccd5@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28/07/2022 18:28, Jakub Kicinski wrote:
> On Thu, 28 Jul 2022 09:41:11 +0200 Antonio Quartulli wrote:
>> However, I guess I will still fill MODULE_VERSION() with a custom
>> string. This may also be useful when building the module out-of-tree.
> 
> Please use the kernel versions for versioning the out of tree code.
> Whenever a new release is cut upstream you bump the number
> appropriately in oot, and adjust whatever compat code needs adjusting.

Thanks for the hint about the versioning!
Will definitely use the kernel version once we are hooked.


-- 
Antonio Quartulli
OpenVPN Inc.