Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220728190810.1290857-1-robh@kernel.org>
In-Reply-To: <20220728190810.1290857-1-robh@kernel.org>
From:   Jassi Brar <jassisinghbrar@gmail.com>
Date:   Thu, 28 Jul 2022 15:17:01 -0500
Message-ID: <CABb+yY2jV7c8oX7=F=nocfvGrOMHJAYov7zS2nT0=qFoNyoxJQ@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: mailbox: arm,mhu: Make secure interrupt optional
To:     Rob Herring <robh@kernel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 28, 2022 at 2:08 PM Rob Herring <robh@kernel.org> wrote:
>
> The secure interrupt is only useful to secure world, therefore for NS
> users it shouldn't be required. Make it optional.
>
> This fixes a warning on Arm Juno board:
>
> mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index bd49c201477d..d9a4f4a02d7c 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -57,6 +57,7 @@ properties:
>      maxItems: 1
>
>    interrupts:
> +    minItems: 2
>      items:
>        - description: low-priority non-secure
>        - description: high-priority non-secure
>
Do we also want to specify that only the secure-irq is optional
because irqs are directly mapped onto channels in the driver, and only
omitting the secure (last) irq will work.

thanks


> --
> 2.34.1
>