Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp725323imn; Thu, 28 Jul 2022 13:58:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sFGLU2WHn58DTvrV+fr1iTNB4XW9PRZ/x2R6v1C4puuw0y6ouQ8ZXEeF4MNw+IU1LBwLTT X-Received: by 2002:a17:906:9754:b0:72f:58fe:41ce with SMTP id o20-20020a170906975400b0072f58fe41cemr499711ejy.467.1659041921398; Thu, 28 Jul 2022 13:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659041921; cv=none; d=google.com; s=arc-20160816; b=lg8S4VVydnBa+N7FADNB2LCeM5L1YyEkTDlhN72aRXaLfF49BXGChAqeAhK0LpVXkt DM1XGHsRyO25gFyIRJsOJSO92iYYcpbWx6oXwlOHC0j0v/0P/I/96RtibEjPQTf01Hbq Av2YOVq+VO55jZ2fbh5w6zS7B36qhYIE6NFozPlG+dV3jirIEbhEdaxYjT/cv3z1IaI1 eXolv5FjFFcPbIPsTEPVEmq957b8ZrJ7mXP4QsXQr5VhckLo9Czz22HFYeMe/7TjM5Fc OP3MyMXA3CJqYpUcaxTaopYren8MFrjU9SwoEo8CrgUv73JFcXciin5Yljl1rivsIcnQ Eh5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=tBgWuFGynz0MwF7NkUQh80/bl2FBIhfWqEjn0ehU7tQ=; b=TC+9HPQqfyzknR92xd6N+8lRl3dXmkfg+2urmWUIdyc4z9bWfK6qaPjSVRLz2Cq8kF fDX70r1Y60SYRcAUsEJrNu6oMRRmPmUQ0CTeh6X3krEQO1GctSPWuw50ttFFPB1LpaSu WBXrTpmn8v7YhqMI4eyxFWiq91CgARvgVpGfERzSzqYpJjqyn1OUiZUYifI/0B3Sz5d2 TCH44bxzj7vbmE+XZx2+djizIL6QpEXbFlQWnfw70BOmsMNc283xVCZlOiLZzit7fjVn mCw/SjmeEYMopwJJ9sxCn5Rqv528E8g8UI+NYZGDHwTdzxeYO1BnFm26yKH09C4/kJ4j Jbvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@schinagl.nl header.s=7of9 header.b=FOt8x21Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=schinagl.nl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 18-20020a170906201200b00718bf351c77si1292562ejo.449.2022.07.28.13.58.08; Thu, 28 Jul 2022 13:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@schinagl.nl header.s=7of9 header.b=FOt8x21Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=schinagl.nl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232311AbiG1UpO (ORCPT + 99 others); Thu, 28 Jul 2022 16:45:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbiG1UpM (ORCPT ); Thu, 28 Jul 2022 16:45:12 -0400 Received: from 7of9.schinagl.nl (7of9.connected.by.freedominter.net [185.238.129.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ED5D2736; Thu, 28 Jul 2022 13:45:10 -0700 (PDT) Received: from [10.2.12.24] (unknown [10.2.12.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by 7of9.schinagl.nl (Postfix) with ESMTPSA id D199A185B6D3; Thu, 28 Jul 2022 22:45:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=schinagl.nl; s=7of9; t=1659041108; bh=sRx6mGd0303ZII+oO6mGwJJLQl14UFRwzsiN7PVXODI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=FOt8x21Z6bw3LuZdK6m0JupoRUGI/KDf+41PDQHiRX4C2mZXnipYCEeg/ctcd0Az9 8y4dS87aj1ThxyPSgxiZQoSjYpLZU1UeRCaixGocCeaJqvBxp2pGKF1HPKL08vZMse 9cLLEGyp72ZWDMjxhekSJh2C19xokcit8dgU4SW8= Message-ID: <5bd688b0-7694-0a96-67e6-7137c018c9a5@schinagl.nl> Date: Thu, 28 Jul 2022 22:45:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 00/13] [RFC] Rust support Content-Language: en-US To: Greg Kroah-Hartman , Gary Guo Cc: Miguel Ojeda , Miguel Ojeda , Linus Torvalds , rust-for-linux , Linux Kbuild mailing list , Linux Doc Mailing List , linux-kernel References: <20210414184604.23473-1-ojeda@kernel.org> <5c0bb1db-5589-32ca-ac22-4aafb3c15751@schinagl.nl> <20220728112114.0000003a@garyguo.net> From: Olliver Schinagl In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Greg, On 28-07-2022 14:09, Greg Kroah-Hartman wrote: > On Thu, Jul 28, 2022 at 11:21:14AM +0100, Gary Guo wrote: >> Rust requires braces around branches of if expression, and C doesn't. >> So in kernel coding style you often have: >> >> if (condition) do_something(); > > That is not a valid kernel coding style, and our tools should catch this > and prevent it from being added to the kernel tree. Are you sure? I'm not sure if this isn't true today, but I've certainly seen old code where this definitely was done. Was all of this cleaned up in the last 2+ years? Olliver > > thanks, > > greg k-h