Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220728143215.v3.1.I5b9006878bdabd6493b866b46dbd6149968d545b@changeid>
In-Reply-To: <20220728143215.v3.1.I5b9006878bdabd6493b866b46dbd6149968d545b@changeid>
From:   Doug Anderson <dianders@chromium.org>
Date:   Thu, 28 Jul 2022 14:47:54 -0700
Message-ID: <CAD=FV=U2U5drgkUP57_hszWT+OEKhqcySOAog00NQ09AhtQ8Qg@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: qcom: document zoglin board
To:     Bob Moragues <moragues@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Rob Herring <robh@kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Thu, Jul 28, 2022 at 2:33 PM Bob Moragues <moragues@chromium.org> wrote:
>
> Zoglin is a Hoglin Chromebook with SPI Flash reduced from 64MB to 8MB.
> Zoglin is identical to Hoglin except for the SPI Flash.
> The actual SPI Flash is dynamically probed at and not specified in DTS.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Bob Moragues <moragues@chromium.org>

A nit from my point of view is that I would have expected your
Signed-off-by to be the first tag. As I understand it the tags are
usually supposed to be a top-to-bottom history of what happened. You
signed off on the patch and then people added reviews / acks. I don't
personally think this is important enough to spin a v4 for, though the
last word would be Bjorn.

> ---
>
> Changes in v3:
> - Fixed Author
> - Fixed duplicate Signed-off-by

Technically this should have been:

Changes in v3:
- Really really fixed Signed-off-by

Changes in v2:
- Fixed Author
- Fixed duplicate Signed-off-by

...but that's also not really worth spinning for.

I think this looks good now. Though unofficial (and not stable git
hashes), I've been trying to keep track of some patches during this
dead time till -rc1. I've put your two patches here:

https://github.com/dianders/kernel-staging/commits/qcom/arm64-staging

-Doug