Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79dda8ce-387f-be0b-45b7-b3eb7af0d189@amd.com>
Date:   Thu, 28 Jul 2022 18:05:50 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] drm/amdkfd: use time_is_before_jiffies(a + b) to
 replace "jiffies - a > b"
Content-Language: en-US
To:     Yu Zhe <yuzhe@nfschina.com>, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        liqiong@nfschina.com
References: <20220727025917.22477-1-yuzhe@nfschina.com>
 <20220728033026.15952-1-yuzhe@nfschina.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20220728033026.15952-1-yuzhe@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0s0YnpwQVAxQjBOeVhRMFJnZXFOcnNTZWtXMHRndzEwRnNQWHpMenF5NUVs?=
 =?utf-8?B?VDkyeG96MVJYYko0NVJVb0NUc0lvaXF1MVpEWU51cjJ2d1NHZUh3aEhPV3lE?=
 =?utf-8?B?ZXkwNUUvUHljVmw0VGhqNUVhY1YzZ0xrY1lld2VIMFFTWUkxTU5pMkE3cXRj?=
 =?utf-8?B?OCtwK2VkajNRT1lHSHE0dnNWckl4UXBjQ1Zibk92ZlJzNU91QXU1YVl5cVhS?=
 =?utf-8?B?T1pLSnNuZWtybmNDd24zcXMybVZFZ3NFbllOeTREZGRoTEJwNlBicndwOVZ4?=
 =?utf-8?B?VDhBaU1oajV6elB2TzFhYlY1VU0rRFFqVjJ1aTA3UDVKYmhudzl1NnppY1Yy?=
 =?utf-8?B?RDg4VmlFRzlwckgzRUdKL3dyUUJQalk5dC9peDJ2K0ZwZnJKdDJjRzlyYzhm?=
 =?utf-8?B?ZVhDUTBmcGZnVUV5eXRGZ01HVWJvdHRuR1hlV3dIYmZRZXVKVUJ2WkpKKysx?=
 =?utf-8?B?bjFNbVlNbmhLSUZ4L2o5TmxVeDNjT0RQN3VpRXhwQ0d4ajl4SFR6alZ4bWlt?=
 =?utf-8?B?RjFCTy9ZNGZoVFlod2V5bmcybExRRGZkaFJKZ3h1T3p0T0YyMmE1KzVMTFY3?=
 =?utf-8?B?YUpWdlYzVStZM2ZSRW5md3U3VEM4QzdSeXN2cDFnaXpFWUZYcU9vNGpSWXox?=
 =?utf-8?B?TmtVdXVLNEtkeUJ3YUFmQ3hYY3A1RVdtN2J4cE5uWnFsY1M5Nm9EeC81Q0d0?=
 =?utf-8?B?NjZHWWtaUlZzcSt2Sm5vL3dFTU41U3p0WGQ4eG14MHVHM2J1ZGhQVlRka05X?=
 =?utf-8?B?dzlCVFdTR1pIVWg2S05SSmZRcWl5NUtIUnpUdFRPK1QrMUZRb2svYlVxUlRw?=
 =?utf-8?B?TnVQQjNhQ04xZFBrdXdjL3lDR3JkWHQ2YlVoUnBjUjVwaU1PQUp4RzJsMExJ?=
 =?utf-8?B?NklQbEhJRVdIUEY3QklLZlhtSnlmOWVlOFN5TWJwdmg1NnhuaW1ZQ2VDRFRt?=
 =?utf-8?B?L1U5R3JJV1QxY3dSaFBoRkFZMERFa1FVdEtFNC9CWWFLTEFKVlQ3RjFuMVVM?=
 =?utf-8?B?b0hKY1EyZzlyS2lkZlBjTkRtY0ZyWC9BdGN1ZkFEajA3ZHYzM3hVaWVIT01s?=
 =?utf-8?B?MTQyUFRzenJ1MFFhampXUndwakRFYWN1ZWNLUmtld09sTisvOGRJdk9RYXNH?=
 =?utf-8?B?OFdqQ3ovM3pUbzdUUE1sRU8xV2VTN1E3MnYzVXhIQzhvODJIc0J1QVZUdHFO?=
 =?utf-8?B?WGE2QktnZklqMnRLK3dmeTBVcDFtN2Z4UUdKQ1hQWlhUSVRWejRRQ0gzZVp1?=
 =?utf-8?B?SHFZbkNFYWpMeUluVnVGYjdRYzBiV256T2JpRkNtY21UOWpJUlNsTWYydHF5?=
 =?utf-8?B?NDZCcFBCdmNzQUQ4L0R1d2xMbmNlN0dxWkRzSHRMZnBhSEgyMGtydTc2c2Jy?=
 =?utf-8?B?eEFUOWhRN2luNkxFK1grUlZ0TzE2cW9nQk9RbG8ycERyMHAzbjZGQUV5VllV?=
 =?utf-8?B?QUNnS3dJUXgzWDhPSmRvbTg3YUhHQ200cUtubVpnYjJ5SEhWcUQ4NlMwNVVW?=
 =?utf-8?B?MUk3d1VOdUowMC9xN3B6WE5id1g4Sm5rczZXL3ZzZFhUNXZLOFpvL09HTENu?=
 =?utf-8?B?c3NDWFdia0ViQ2krSjJkVzNPMDFaTjZTT0s1QWk0cHVlNXBodWltNzZEcTk4?=
 =?utf-8?B?bmoyelF3aTZnLzhycTVaNE1tR3Y1dE9NQzlzRGtCQ0o2bGRITDZIdVlQbE5y?=
 =?utf-8?B?YVNyd1Y2TWhzQmVZOTJXMC9RM3psZG1OcENTalBIYXJuL2w3T0xMdjhFVzY0?=
 =?utf-8?B?QUg3MWtvZUk1OXJpald6eG1Nb2FCVEE1b2ZXbXhkZCtzcEFVZEhxMUhtWE1U?=
 =?utf-8?B?djFYSWtRL0YvM3RvZHErOGN0aUd3QUFlRGRPWUNpQnJteXpqMlpnZ1pPL2FH?=
 =?utf-8?B?WWRnSXRVekNMekRkVzlUNVlkNkcyTDAyNTJValExaVVlbFdpOE42Tzhrak83?=
 =?utf-8?B?V2RJOVhLS0Y3NWF3WThhbFJpV3cxWFdqSisreVJ6VWthbUEzcU5EVUI0dVZY?=
 =?utf-8?B?UzlkTzJiZFYwQlpvYmhkUGZ0NFZCTkZBTERXcWNYQ2Vyc2JsemFteWFlWWpL?=
 =?utf-8?B?cHpnS1BBelFMak4rWFU1eldGejRpK0ZwNlBpT1VLSE5MRlpkYWJ3d1R5am13?=
 =?utf-8?Q?oc0QMr8wevYp9/G8WmEGncZsO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae89260a-ef53-40af-0ff1-08da70e5561f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5112.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 22:05:52.2450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hqpzpeLDhYZihmVjbxL1mlMkUa7tvTwXBt4cBvu2o5NgAD9ceVsjTc2286xwBv1e7U+g3zVYapw+Yz6KPe0upA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2513
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2022-07-27 um 23:30 schrieb Yu Zhe:
> time_is_before_jiffies deals with timer wrapping correctly.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>

Thank you. This patch looks good to me. I'm applying it to 
amd-staging-drm-next.

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> index a9466d154395..34772fe74296 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
> @@ -146,7 +146,7 @@ static void interrupt_wq(struct work_struct *work)
>   	struct kfd_dev *dev = container_of(work, struct kfd_dev,
>   						interrupt_work);
>   	uint32_t ih_ring_entry[KFD_MAX_RING_ENTRY_SIZE];
> -	long start_jiffies = jiffies;
> +	unsigned long start_jiffies = jiffies;
>   
>   	if (dev->device_info.ih_ring_entry_size > sizeof(ih_ring_entry)) {
>   		dev_err_once(dev->adev->dev, "Ring entry too small\n");
> @@ -156,7 +156,7 @@ static void interrupt_wq(struct work_struct *work)
>   	while (dequeue_ih_ring_entry(dev, ih_ring_entry)) {
>   		dev->device_info.event_interrupt_class->interrupt_wq(dev,
>   								ih_ring_entry);
> -		if (jiffies - start_jiffies > HZ) {
> +		if (time_is_before_jiffies(start_jiffies + HZ)) {
>   			/* If we spent more than a second processing signals,
>   			 * reschedule the worker to avoid soft-lockup warnings
>   			 */