Received: by 2002:ac0:b7d5:0:0:0:0:0 with SMTP id v21csp19488ime; Thu, 28 Jul 2022 15:29:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR4T9P+ONgNQ+BIlQ8ntG/rn+UAfys/181jaL6sPRRBO1ZHmj+agUSmh66C5C833MkbZ8pqg X-Received: by 2002:a17:902:ce05:b0:16b:e725:6f6c with SMTP id k5-20020a170902ce0500b0016be7256f6cmr937090plg.110.1659047384378; Thu, 28 Jul 2022 15:29:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659047384; cv=none; d=google.com; s=arc-20160816; b=Cf0U7tFjR5kpJT4TxcAsyAuvOAthKXZmm5ASRbJivicOTZOviixcJcnUfPd1X9J4g7 UyCYEoazFZ8VInbvdDQAY0mZxC1iArixgHs4mSd5x3kVSsYGmB8d/U+VdX0m+pjNXQ5B Z0CXt2fO62bkk8gvhT3xcHY9Ixr05VO5ygS7wu028GouPff0V1O3gYo3dY2UjvPLupoJ ItQ/rirrz2c8qi9CMhXfnmqfDdIgy21jExK4S1MyGKeu74TvvG0gQSTxXAKJ70nYP7uu WYPcB018GvApGC3oPfD1IaY83uw8efc5I1n1MDKjGalz/iQKjEalrHPQLxS5cHIX6WcM 0P+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=alEH1WwUjVCElaffThQK0Suy1kY+uR7uRYgblI7vhIY=; b=TRmNpWMm7EH206fCsgD0BXoJpo+T0yEeAHx6y8f2/ipb3Tw+eWrRbwelSkwjOqTQaC vJs4KY+/jAm8kjqXvT0C7P/OlA7txdx2befM9zaQ/sYFTR5c905UQs6tCPMzJzIHxBle 0nPd/4W2kYc1CmC7S5LUVHQ6BovlAs5MtDsd1Oh+rik1ZKC2FxV7/I9cNmMZ56rDeKsz nTQeXYh+pB7Iw+XgfpjMX5o8+LFSqYVhcICaHG+QOcu2hmfQrWewrIx/cOJAQhsRJFcd RMuRmbDXbadrN9zonyMIMT0McUFygAIJIYVRFqZaaY5yUhE58s9ddGfPsAbleOu31XNj 5f9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OpMs15cG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mh9-20020a17090b4ac900b001f2bc3a5877si7571791pjb.3.2022.07.28.15.29.29; Thu, 28 Jul 2022 15:29:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OpMs15cG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231736AbiG1WVA (ORCPT + 99 others); Thu, 28 Jul 2022 18:21:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229614AbiG1WU4 (ORCPT ); Thu, 28 Jul 2022 18:20:56 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3981D78DEA; Thu, 28 Jul 2022 15:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=alEH1WwUjVCElaffThQK0Suy1kY+uR7uRYgblI7vhIY=; b=Op Ms15cG37Mp5ahueu4ZFT91aBVuu61pybdt4tWRkuIM7bySs4MdBR1kl6u2Hx9+D0dgGNWDIk3n+aY wrMBqy8YSvxCbb1efxfD+jbOnArPvuG/95X11McX1vgHmmJpb8cGMctPOLCXLZ2xJS2FYKG/FVwAQ BGL4OVrAPmrgMCM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oHBsA-00Bqex-7A; Fri, 29 Jul 2022 00:20:50 +0200 Date: Fri, 29 Jul 2022 00:20:50 +0200 From: Andrew Lunn To: Marcin Wojtas Cc: Vladimir Oltean , Linux Kernel Mailing List , ACPI Devel Maling List , netdev , "Rafael J. Wysocki" , Andy Shevchenko , Sean Wang , Landen Chao , Linus Walleij , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King - ARM Linux , Heiner Kallweit , Grzegorz Bernacki , Grzegorz Jaszczyk , Tomasz Nowicki , Samer El-Haj-Mahmoud , upstream@semihalf.com Subject: Re: [net-next: PATCH v3 6/8] net: core: switch to fwnode_find_net_device_by_node() Message-ID: References: <20220727064321.2953971-7-mw@semihalf.com> <20220727143147.u6yd6wqslilspyhw@skbuf> <20220727163848.f4e2b263zz3vl2hc@skbuf> <20220727211112.kcpbxbql3tw5q5sx@skbuf> <20220728195607.co75o3k2ggjlszlw@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 28, 2022 at 11:23:31PM +0200, Marcin Wojtas wrote: > czw., 28 lip 2022 o 22:18 Andrew Lunn napisaƂ(a): > > > > > The 'label' thing is actually one of the things that I'm seriously > > > considering skipping parsing if this is an ACPI system, simply because > > > best practices are different today than they were when the OF bindings > > > were created. > > > > Agreed. We want the ACPI binding to learn from what has worked and not > > worked in DT. We should clean up some of the historical mess. And > > enforce things we don't in DT simply because there is too much > > history. > > > > So a straight one to one conversion is not going to happen. > > I understand your standpoint - there is a long history, possible > clean-ups, backward compatibility considerations, etc. that should not > be zero-day baggage of ACPI. Otoh, we don't need to be worried about > the ACPI binding too much now - as agreed it was removed from this > series, beginning from v2. IMO it may be better to return to that once > the ACPI Spec is updated with the MDIOSerialBus and the patches are > resubmitted on whatever shape of the DSA subsystem is established > within the next weeks/months from now. > > In v1 we discussed also the resubmission of the non-ACPI-related > patches, which would pave the way to dropping the explicit OF_ > dependency in the DSA and moving to a generic hardware description > kernel API - without any functional change. Ideally, we want to keep all the ugly DT stuff in DT. We want to ensure that any "generic hardware description kernel API" does not inherit all the ugly DT stuff. ACPI and DT are different things, so i don't see why they need to share code. Andrew