Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ee19c2c1-9e71-1190-b27f-327c8a6942a4@oracle.com>
Date:   Thu, 28 Jul 2022 19:09:56 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v3] x86/xen: Add support for
 HVMOP_set_evtchn_upcall_vector
Content-Language: en-US
To:     Jane Malalane <jane.malalane@citrix.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     Juergen Gross <jgross@suse.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Jan Beulich <jbeulich@suse.com>,
        Maximilian Heyne <mheyne@amazon.de>,
        xen-devel@lists.xenproject.org
References: <20220728125244.19163-1-jane.malalane@citrix.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220728125244.19163-1-jane.malalane@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1JscDdLZkIvZXVCUmY1S1RKdzIzU0xQamdaUGpJZ2lteWlxb0JEVGdoLzlz?=
 =?utf-8?B?bHJpSUYzREZJQWN0ZnVTQzZuWE95ZUtoRWR1QkZraW5QSVdyUUtYWXgwallq?=
 =?utf-8?B?VEhFQWZNNTN0QUEwUFBVMXR0SE5OazhmMkpZY1RDc2xqdlNkdkp2UEJhNmV4?=
 =?utf-8?B?c2R0akQ3SmdHWWJ3c3VlMitZT3ZVSG14cll5bnFSb0p2enlSSjFoOXlFbkVi?=
 =?utf-8?B?UGRMcE9nMGpFV29RWERTNXlNT1FjbkZJZkRYdnc0UW9ORVE3YThSOUtkbkkr?=
 =?utf-8?B?b0diN1RiNTU2UzRlRDNjOElOK2dPZjF2d3pLdjZKL3hKUk5aSjRvNDhITTh5?=
 =?utf-8?B?SEh3QmNlM1BYdFd6byt3QjMyMXZIclJSMmZ5NExTSGRCTFJBMCszcU1QNW5Z?=
 =?utf-8?B?S1FxT3lGZTRIWm5mMTlGa2E0SmZuY0hkRG02dGl4bGJidFk2T2d2V2JiZCtU?=
 =?utf-8?B?OTF0MVRoYU5yT1cwLzdNWGVVRXdPQjRBQTFhMVpzR1h1Q0xobzdsYVl1NnFE?=
 =?utf-8?B?ejFlWnFjRzdLWkNNbVFWSnV4V2lTalpScUxsNUpFR091RnU5Wno2OUJWczNC?=
 =?utf-8?B?YTVCS0JTTFE1TXpDZkw2U2x6WHJqY2JOZzFUc2kraXNmSXBGVXFEd0JlRUs2?=
 =?utf-8?B?ZEYzeVFuOHJXVy9jOWpidUYzUTNZZ2NtalVQc2F6bzJrU25NaU14VzJWSFR6?=
 =?utf-8?B?Uk9xT0R3NVd6WTM3NHlSVmJTMll1V0FETEpxaDEyMVZXaTJwN1VMWm1PVnpl?=
 =?utf-8?B?aEpVdUZTLzQ0dDNwVUlLZlNUMFRRUDhtM1ZlT3FuTEhPTThJU2U0U0hQSWxz?=
 =?utf-8?B?bFU3T2JTTi9xNjdiMWxWay90aDQycXErOEtxbnNCRi9HWXZEd1creDdqMjI0?=
 =?utf-8?B?cUdwZVBCYjRZeU5MNVdOb3ExcExibnVjTWNObTVPdmpNbmtYbmc1bUVUYjFC?=
 =?utf-8?B?Q211SnVOazBWTkVhWi9CNFpoSEVNek5tbGdVVTZOZURFWW9hak9FTTlSZ1Nl?=
 =?utf-8?B?YStVS3QyYUpVQ25GZXlyK2tSakF0WUx6dWFFWHh5VUhBU3FsQXJkcDhZZ3Na?=
 =?utf-8?B?bzBTd29CY0l1M1dNTjJubXFCVTFuaFpTd1EzZU5DbEFoSERNNlJwdG5RNzFX?=
 =?utf-8?B?eW81V3dURlZGeEtQWGV1azFsbFMyS3F3QThKNllyL0E3RnlHNEVFRHhwZThZ?=
 =?utf-8?B?eGpwMndPTlFFeGc1QjZQZkFIVGsyQTUyTTlqRnBCdm9pNzgxZ3JiUlZJcXR6?=
 =?utf-8?B?bFhCNEQ5VHA2TmxkOCtuS0tRQmxnZDdGbnZ6N051MkxHNjBTK2pCY3gxSmFp?=
 =?utf-8?B?SlYxZVZaQWZJaUZ0WjlUVkdBZnRwMmFNL3BnWXJ1Zm5MV3lUWXE3RnU5a1V6?=
 =?utf-8?B?UnRPdXo3eUp3aUtJT05OZUphT1Z5KzZxbFFva3BET0laZTBpaTc5TG4vek1C?=
 =?utf-8?B?OHJGVW94L25nKzRqZ3NBY3V0Ymd5eHM2UXlsMXhaMEZSZG1xLzZxcEozWVhs?=
 =?utf-8?B?b1hLWFVmb1RQOHhlTFlUUGFYSFhTNUhKekNubllxMzFEUUZydDNNWWhHSkVl?=
 =?utf-8?B?NDlzNG5YWCsvMysrZnc1emk0ZkIrZHVMa09TTm9qbGxaUUQ5Y0xOR0dQNUF5?=
 =?utf-8?B?YjZwTEpoMFpsOTlhUEQxS01JWjI0dklTVG9mOGp1Y1JDZzZXSlo2N1FPaG5N?=
 =?utf-8?B?bkpnSjJoQzV1QzNFdnJORVNMb0hrMHkvWjVsSCtrOHRxMmsrbEdqQTA0M1dT?=
 =?utf-8?B?Qm5nSWMvb0g3TGtiKzZRa2ZNdTA2QnVuQ2xTais1U0JobHJWM3FqUHRJUWJQ?=
 =?utf-8?B?VHJRY2VxN24zV1RqVlUvS01IYyt5Zi93NzY3L3R4VER6VksxVlJlT0ZNQzl6?=
 =?utf-8?B?QjNUZTZqOXRvWXYreHMzNXZsWFUxZUVBR3g5Mi9mVjRTZG9MaUZEN1FlRFhQ?=
 =?utf-8?B?SXNsYmNualdYZFcvQ0N6aTlLaHpBbTNDWk8yVDVnRi9sZGhPem5ybEdrbmsy?=
 =?utf-8?B?eTJoSWZkQVN6blV1RW8xb2NGODYrQWtnb3JBVnZZZThRcUQ5YWVrRjF6ck4v?=
 =?utf-8?B?Q1hxSWlmbjMvblNtRWxHMENzeUZ0T1VSbFZuRElsTUo3NFNFeGV3anVuK2or?=
 =?utf-8?B?eEp1MjVCNkt5Z3pJdzZ2bkFuK3YraXQ3RWhKbW1MdGkrVGhzNC9NanR4eVMy?=
 =?utf-8?B?UEE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9270724a-64df-49c1-3e02-08da70ee4b3b
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 23:09:59.4453
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MmRnvOExXnrvRn9eeAe7BwOC+cXoBjWoIv8Ql9LOoG/VlnM2a1XPb1ATpCNWWdXP6OMK3nwerGR9ZLh21M2Em7mry6jJoFKcAaMGQzluzCQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5329
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-28_06,2022-07-28_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207280103
X-Proofpoint-GUID: ctTXCaCEqhwEuIkVB_W0YPIKmiVz2MNv
X-Proofpoint-ORIG-GUID: ctTXCaCEqhwEuIkVB_W0YPIKmiVz2MNv
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/28/22 8:52 AM, Jane Malalane wrote:
>   
> +/*
> + * Setup per-vCPU vector-type callbacks and trick toolstack to think


The comment should be adjusted -- no need to mention toolstack now that that code has been factored out.


Other than that


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>


> + * we are enlightened. If this setup is unavailable, fallback to the
> + * global vector-type callback.
> + */
> +static __init void xen_init_setup_upcall_vector(void)
> +{
>