Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965131AbXFFGzR (ORCPT ); Wed, 6 Jun 2007 02:55:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757754AbXFFGzE (ORCPT ); Wed, 6 Jun 2007 02:55:04 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:57828 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757434AbXFFGzC (ORCPT ); Wed, 6 Jun 2007 02:55:02 -0400 Date: Tue, 5 Jun 2007 23:54:41 -0700 From: Andrew Morton To: Adrian Bunk Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [-mm patch] kernel/sched{,_fair}.c: make code static Message-Id: <20070605235441.7b132e27.akpm@linux-foundation.org> In-Reply-To: <20070605215056.GJ5500@stusta.de> References: <20070530235823.793f00d9.akpm@linux-foundation.org> <20070605215056.GJ5500@stusta.de> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 26 On Tue, 5 Jun 2007 23:50:56 +0200 Adrian Bunk wrote: > This patch makes some needlessly global code static. > > Signed-off-by: Adrian Bunk > > --- > > BTW: Please don't #include C files in sched.c Yeah. > -long div64_s(s64 divident, unsigned long divisor) > +static long div64_s(s64 divident, unsigned long divisor) "divident" does appear to be a word, but I suspect "dividend" was intended. Why is this function lurking in the CPU scheduler rather than in lib/somewhere.c? Doesn't an unsigned divide give the same result as a signed one? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/