Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220728032000.127-1-xieyongji@bytedance.com> <20220728032000.127-3-xieyongji@bytedance.com>
In-Reply-To: <20220728032000.127-3-xieyongji@bytedance.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Fri, 29 Jul 2022 10:33:22 +0800
Message-ID: <CAMZfGtVGjn1bkC345EykA0b86HoR2m6tmc_JYs7GnEvBCh9ETA@mail.gmail.com>
Subject: Re: [PATCH v4 2/5] vduse: Use memcpy_{to,from}_page() in do_bounce()
To:     Xie Yongji <xieyongji@bytedance.com>
Cc:     "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>, xiaodong.liu@intel.com,
        maxime.coquelin@redhat.com, stefanha@redhat.com,
        virtualization@lists.linux-foundation.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 28, 2022 at 11:20 AM Xie Yongji <xieyongji@bytedance.com> wrote:
>
> kmap_atomic() is being deprecated in favor of kmap_local_page().
>
> The use of kmap_atomic() in do_bounce() is all thread local therefore
> kmap_local_page() is a sufficient replacement.
>
> Convert to kmap_local_page() but, instead of open coding it,
> use the helpers memcpy_to_page() and memcpy_from_page().
>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> Acked-by: Jason Wang <jasowang@redhat.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>