Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: idfb84289:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-758-ge0d20a54e1-fm-20220729.001-ge0d20a54
Mime-Version: 1.0
Message-Id: <62143648-8a90-4ff4-bfe1-f311b40cd50c@www.fastmail.com>
In-Reply-To: <20220501105644.355062-1-zhangjian.3032@bytedance.com>
References: <20220501105644.355062-1-zhangjian.3032@bytedance.com>
Date:   Fri, 29 Jul 2022 12:07:39 +0930
From:   "Andrew Jeffery" <andrew@aj.id.au>
To:     "Jian Zhang" <zhangjian.3032@bytedance.com>,
        openbmc@lists.ozlabs.org, "Joel Stanley" <joel@jms.id.au>,
        =?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>
Cc:     zhangjian_linux@163.com, "Mark Brown" <broonie@kernel.org>,
        "open list" <linux-kernel@vger.kernel.org>,
        "open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-aspeed@lists.ozlabs.org>
Subject: Re: [PATCH linux dev-5.15] soc: aspeed: abr: Add sysfs attrs for flash toggle
Content-Type: text/plain
Precedence: bulk

Hi Jian Zhang,

On Sun, 1 May 2022, at 20:26, Jian Zhang wrote:
> Implement the flash toggle function in soc ast2600.
> Add two sysfs attrs named "access_primary" and "access_backup"

If you're proposing this patch for upstream then it needs to be based on
an upstream kernel tree, not the OpenBMC kernel tree. You also should
not use e.g. `linux dev-5.15` in the patch subject prefix, as that would
be inappropriate for an upstream patch.

As you're adding sysfs attributes you'll also need to add the
corresponding ABI documentation.

Cheers,

Andrew