Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ryan Chen <ryan_chen@aspeedtech.com>
To:     Andrew Jeffery <andrew@aj.id.au>, Joel Stanley <joel@jms.id.au>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
CC:     BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings for AST2600
 i2C driver
Thread-Topic: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings for
 AST2600 i2C driver
Thread-Index: AQHYaPENO2grG+HzSECGUwldbn2ojq2VE+oAgAAINMA=
Date:   Fri, 29 Jul 2022 03:03:43 +0000
Message-ID: <SEZPR06MB5269DFE2CF762B62846D315EF2999@SEZPR06MB5269.apcprd06.prod.outlook.com>
References: <20220516064900.30517-1-ryan_chen@aspeedtech.com>
 <20220516064900.30517-3-ryan_chen@aspeedtech.com>
 <5d863bc1-4f27-48b6-89ab-c3f02bc09057@www.fastmail.com>
In-Reply-To: <5d863bc1-4f27-48b6-89ab-c3f02bc09057@www.fastmail.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eU4zD2mCpKz7DF7M2ZdLbJLAHNBxPQVa7vYESJkqoAmjOs2ZUUc4I0TSSWfm?=
 =?us-ascii?Q?4351kWN3I/3DFrPaUpL88vNhq1x6lWxtw+WySJugnDCCPUsK1qhtav2U+SAi?=
 =?us-ascii?Q?A0R5pG7CH7oHkC8c1GM6slx0qjBDIcAN8Z4xSXJ1lLuw5rbZQATg4OdCXhn5?=
 =?us-ascii?Q?SyAl4Q75FA7BU9BUu818F1L4FZkMBeubyXS7G6/rZgq44S805Ok+GhkfQGUu?=
 =?us-ascii?Q?uf0XvB9Am0t7Nil16Td8m1qAqOFR8Apz7BzbDHw0SUY5aLDngmQ0/StCRtRn?=
 =?us-ascii?Q?I1CZyrOn5XEKPd+o+HbzDfgTcNwnLAp/50wHR83GcupUT5k44Av6EcSY3Vjc?=
 =?us-ascii?Q?PclGFA6zc5iS7F3Dwo5y+dXDGGCo0fp+1pS8+XEVW7RjpLp61Hfa9QQe3hqP?=
 =?us-ascii?Q?BQmw03vxa8xviJaT/Rfb+KJV1jMcejtcFjUowsnibv0aafkQJb0kgNU8WZBo?=
 =?us-ascii?Q?qMyIRK0oKfDATAaArBuu9jIQbFuoexXXoXl8nSh02WchczeA+B9ZJkv7p7D1?=
 =?us-ascii?Q?GE8lfZk8owRi+5LLlD/bI9SSnaGBiwBJc2LIxGkFQaS4VfH7ZY/UAlNCzIpp?=
 =?us-ascii?Q?GCAIzTlo3WfOa8nJBj4ONcTjPdSbQEDFTJQjS0UGqHuRFFUMAdpGoZri7TUM?=
 =?us-ascii?Q?PvltA4taMDoMM5OT+3e76gZJOmY4K7CBwKveP98MZ6+MdcuS62+kyRfw11GE?=
 =?us-ascii?Q?ENXzPdRjUwQkofoiNqxRSPpVEICdiFUb6eS/XtZQBf3puHh1eepBRtDM0M80?=
 =?us-ascii?Q?C4rQW5AKma7zR0ElkG348U34L7vYbeoeXS7xtoaww0XERZWoqv+gl0b6RPYt?=
 =?us-ascii?Q?yQApasmd1oy/VRgTnJyvTfYPr5XVykUSMjsromxxTVRFK8rh79Qs6a1oaQ4Q?=
 =?us-ascii?Q?c/g/4Q4cHIb5GvMpUVillCliOvl7bijRgbE946dvIGcPMvlYYG8kFCgbxAt3?=
 =?us-ascii?Q?gnQnw9zrv/gbPAakLwS8jHBOqg8sDopIOmcrgyKLv8FdcCxNRnB95f+vvh1I?=
 =?us-ascii?Q?4VB7Ob3ymuXDYNR7l0dncj24tqOoWORju/wBqBXgGNLaxjR+ObhQqEpPnMU6?=
 =?us-ascii?Q?XLLEtyM3MWIL6kx/MhYaofPUFZlcAFjuns7zidVks3XFW1k7ZeqppmPdGTpB?=
 =?us-ascii?Q?bKKGoZWRGpGmVw3JUJYfl1TqQXKT0dnGM9/vPPZZtAsiYgOqC42AxxxNPgvt?=
 =?us-ascii?Q?IZjfM8VgTKoofiuC0ZkMssC7Cyir6WJq6WvzWavxN998eAf+m1WmcRPDjXp4?=
 =?us-ascii?Q?2QIyBaxJgbssft5APWISLTrzBQNbDbAt/6n4V1gTiMUHgy6LOTNJ3sUlm5kE?=
 =?us-ascii?Q?4R5cTJOyNn/ur56pH2lxROXYQg2zHidxYYiEf9kwmu4UrKhAdpLbdzDvY/sW?=
 =?us-ascii?Q?aX0wqS942LHskSJpUG9ZQNQJW9A6Y5Ncw7NXDwPyg0AzuEas3j9rqjUEF1V8?=
 =?us-ascii?Q?2EHW633GrAGukuia6p5CqK721MtkDsHqWJKMbE6w1ulUleP+vUnQjtK/pf/L?=
 =?us-ascii?Q?2yZM5mVAmLfp/lQuNEr6Weh6fyPG05bR4lr/c8AH5GBNozIn+qMX0aCZzGqI?=
 =?us-ascii?Q?rqIR1lNqhEq9iOkRegXUjDFjUjxgrUUPxHS4903x?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98295163-42b2-4891-ce6d-08da710ef276
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 03:03:43.7543
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W9dgaqIT832R/cmJ8lTMdNl4+vLlEfAodo8oqFFDHvN3sUT+OMM0JaqAvWfv9EKWB2/cfGLuDtQHxdANM6gBWWqv3iu1A0VSqx00+0sOJzs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4531
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NO_DNS_FOR_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_SPF_TEMPERROR
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andrew,

> -----Original Message-----
> From: Andrew Jeffery <andrew@aj.id.au>
> Sent: Friday, July 29, 2022 10:29 AM
> To: Ryan Chen <ryan_chen@aspeedtech.com>; Joel Stanley <joel@jms.id.au>;
> Philipp Zabel <p.zabel@pengutronix.de>; linux-arm-kernel@lists.infradead.=
org;
> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org;
> openbmc@lists.ozlabs.org
> Cc: BMC-SW <BMC-SW@aspeedtech.com>
> Subject: Re: [PATCH v3 2/3] dt-bindings: i2c-ast2600: Add bindings for AS=
T2600
> i2C driver
>=20
> Hi Ryan,
>=20
> On Mon, 16 May 2022, at 16:18, ryan_chen wrote:
> > AST2600 support new register set for I2C controller, add bindings
> > document to support driver of i2c new register mode controller
> >
> > Signed-off-by: ryan_chen <ryan_chen@aspeedtech.com>
> > ---
> >  .../bindings/i2c/aspeed,i2c-ast2600.ymal      | 78
> +++++++++++++++++++
> >  1 file changed, 78 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600.ymal
> >
> > diff --git
> > a/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600.ymal
> > b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600.ymal
> > new file mode 100644
> > index 000000000000..7c75f5bac24f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600.ymal
> > @@ -0,0 +1,78 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c-ast2600.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: AST2600 I2C Controller on the AST26XX SoCs Device Tree
> > +Bindings
> > +
> > +maintainers:
> > +  - Ryan Chen <ryan_chen@aspeedtech.com>
> > +
> > +allOf:
> > +  - $ref: /schemas/i2c/i2c-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - aspeed,ast2600-i2c
>=20
> The original driver uses e.g. aspeed,ast2500-i2c-bus for the subordinate
> controllers. While the register layout changes, I'd prefer we try to use =
the
> existing compatibles rather than introducing a new set and causing some
> confusion.
>=20
> Further, what you're proposing here is effectively being used to select t=
he
> driver implementation, which isn't the purpose of the devicetree.
>=20
> My preference would be to reuse the existing compatibles and instead sele=
ct
> the driver implementation via Kconfig. Or, if we can figure out some way =
to do
> so, support both register interfaces in the one driver implementation and=
 fall
> back to the old register interface where the new one isn't available (I d=
on't
> think this is feasible though).
>=20
Yes, that the reason go for another driver ast2600 to implement.
Like others SOC driver implement different generation have diff driver in K=
config=20
and Makefile.
Example :
https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/Makefile#L=
82-L84


> > +
> > +  reg:
> > +    minItems: 1
> > +    items:
> > +      - description: address offset and range of bus
> > +      - description: address offset and range of bus buffer
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +    description:
> > +      root clock of bus, should reference the APB
> > +      clock in the second cell
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +  bus-frequency:
> > +    minimum: 500
> > +    maximum: 2000000
> > +    default: 100000
> > +    description: frequency of the bus clock in Hz defaults to 100 kHz
> > when not
> > +      specified
> > +
> > +  multi-master:
> > +    type: boolean
> > +    description:
> > +      states that there is another master active on this bus
> > +
> > +required:
> > +  - reg
> > +  - compatible
> > +  - clocks
> > +  - resets
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/ast2600-clock.h>
> > +
> > +    i2c_gr: i2c-global-regs@0 {
> > +      compatible =3D "aspeed,ast2600-i2c-global", "syscon";
> > +      reg =3D <0x0 0x20>;
> > +      resets =3D <&syscon ASPEED_RESET_I2C>;
> > +    };
> > +
> > +    i2c0: i2c-bus@80 {
> > +      #address-cells =3D <1>;
> > +      #size-cells =3D <0>;
> > +      #interrupt-cells =3D <1>;
> > +      compatible =3D "aspeed,ast2600-i2c-bus";
>=20
> This isn't quite right with respect to your binding description above :)
Yes, the compatible need to be " aspeed,ast2600-i2c" is that your point ?
If yes, I will start for v4.
> Andrew