Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 29 Jul 2022 13:49:48 +1000
From:   Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH v2 06/12] locking/qspinlock: merge qspinlock_paravirt.h
 into qspinlock.c
To:     kernel test robot <lkp@intel.com>
Cc:     Boqun Feng <boqun.feng@gmail.com>, kbuild-all@lists.01.org,
        "linux-kernel @ vger . kernel . org" <linux-kernel@vger.kernel.org>,
        llvm@lists.linux.dev, Waiman Long <longman@redhat.com>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>
References: <20220713070704.308394-7-npiggin@gmail.com>
        <202207142228.8Z4o18rM-lkp@intel.com>
In-Reply-To: <202207142228.8Z4o18rM-lkp@intel.com>
MIME-Version: 1.0
Message-Id: <1659066516.mc10tbo8hk.astroid@bobo.none>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Excerpts from kernel test robot's message of July 15, 2022 12:16 am:
> Hi Nicholas,
>=20
> I love your patch! Perhaps something to improve:
>=20
> [auto build test WARNING on tip/locking/core]
> [also build test WARNING on tip/x86/core powerpc/next linus/master v5.19-=
rc6 next-20220714]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>=20
> url:    https://github.com/intel-lab-lkp/linux/commits/Nicholas-Piggin/lo=
cking-qspinlock-simplify-code-generation/20220713-151009
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git eae6d=
58d67d9739be5f7ae2dbead1d0ef6528243
> config: i386-randconfig-a004
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e61=
b9c556267086ef9b743a0b57df302eef831b)
> reproduce (this is a W=3D1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi=
n/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/91668ee1ed703d7ea=
84e314136dc732da05ec9e7
>         git remote add linux-review https://github.com/intel-lab-lkp/linu=
x
>         git fetch --no-tags linux-review Nicholas-Piggin/locking-qspinloc=
k-simplify-code-generation/20220713-151009
>         git checkout 91668ee1ed703d7ea84e314136dc732da05ec9e7
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=
=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash kernel/locking/
>=20
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>=20
> All warnings (new ones prefixed by >>):
>=20
>    In file included from kernel/locking/qspinlock.c:29:
>    kernel/locking/qspinlock_stat.h:36:9: warning: no previous prototype f=
or function 'lockevent_read' [-Wmissing-prototypes]
>    ssize_t lockevent_read(struct file *file, char __user *user_buf,
>            ^
>    kernel/locking/qspinlock_stat.h:36:1: note: declare 'static' if the fu=
nction is not intended to be used outside of this translation unit
>    ssize_t lockevent_read(struct file *file, char __user *user_buf,
>    ^
>    static=20
>>> kernel/locking/qspinlock.c:705:1: warning: no previous prototype for fu=
nction '__pv_queued_spin_unlock_slowpath' [-Wmissing-prototypes]
>    __pv_queued_spin_unlock_slowpath(struct qspinlock *lock, u8 locked)
>    ^
>    kernel/locking/qspinlock.c:704:11: note: declare 'static' if the funct=
ion is not intended to be used outside of this translation unit
>    __visible void
>              ^
>              static=20
>    2 warnings generated.

These aren't new warnings btw, just existing W=3D1 warnings in code that=20
moved.

Thanks,
Nick