Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hu, Robert" <robert.hu@intel.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Lutomirski, Andy" <luto@kernel.org>,
        "Peter Zijlstra" <peterz@infradead.org>
CC:     "x86@kernel.org" <x86@kernel.org>,
        Kostya Serebryany <kcc@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Taras Madan <tarasmadan@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        "H . J . Lu" <hjl.tools@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCHv5 01/13] x86/mm: Fix CR3_ADDR_MASK
Thread-Topic: [PATCHv5 01/13] x86/mm: Fix CR3_ADDR_MASK
Thread-Index: AQHYlkUVsiMqTSAE+0yet7IGhjNcfq2UwScg
Date:   Fri, 29 Jul 2022 03:00:52 +0000
Message-ID: <CY5PR11MB6187E92E7DA80111BDBA1E63E0999@CY5PR11MB6187.namprd11.prod.outlook.com>
References: <20220712231328.5294-1-kirill.shutemov@linux.intel.com>
 <20220712231328.5294-2-kirill.shutemov@linux.intel.com>
In-Reply-To: <20220712231328.5294-2-kirill.shutemov@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Alffhe8N8D06/YmLekoE2vpxSlUuj2h8ShhVZn6stn4dED23pVM77QaGIo6J?=
 =?us-ascii?Q?TySe+sTxQro15gT9KxW3kygmUFO5Pr4oEox7rJ5H9s8Im5aI1xGDR4EwAMwr?=
 =?us-ascii?Q?aviLymZ2I8ufhgBFQTAjJO/8fFZDg7jBoCYi0WgF1RTpZWoYrGSZCQTVd6n6?=
 =?us-ascii?Q?Ld8I0mO3o2V1mJhzpgv18zaSDPn4qPhFDjTdCfzEMCPigKwVNPTDxwV8zdEA?=
 =?us-ascii?Q?j5plqU20xH7bhlFp6MhnwloMDS74ZtW3ZlMotVbzfXRgS/Ybfd7RZUnNlfR7?=
 =?us-ascii?Q?WuPUcbJS53fttxuEgoVP6/EIL9iYs5P77ByUzh1OETIhREqvy68BXmmT12Mf?=
 =?us-ascii?Q?ROO/JX5VDC2lf4luilrv9quMBtAN1IAUaer+oxNV4IOVPzkeFas4nr7DEqDP?=
 =?us-ascii?Q?M0/sd6whrHGZ9wfpNT9bXGWOxbodSNzxSV19yBBTYqVJt7mNcSohZ5Tmf422?=
 =?us-ascii?Q?JASzKMrywi/ULJkRCJRfpH6TIQmNpKJ2XkP4YPgxFy6eTPB3zE2D+OJ7Uvky?=
 =?us-ascii?Q?hnnMyiEEAGnUitO2cTopEAvAhiTJgLPX/9mDSEPuYKMgNcO0NKvHpiqwBYDG?=
 =?us-ascii?Q?6LwmkI2Ud2nie0Utf4a8PY4CbuoUp+kgfKlACxASa8kur4J7B2NEE3K2mHpO?=
 =?us-ascii?Q?N83rwTTUs6PGMtQlVVqa8fRxCodqhUREzz3cbw3m1vXhgrXMSHg3gssWqbw8?=
 =?us-ascii?Q?b1u79xtC8k1WSQSqXknm5Ni40vkCVImLAe8NYgnAds7eCwBCd+QvCVpReWlD?=
 =?us-ascii?Q?8+47hPbvo8UtbwgPYCm7nrYJfYfCXtEcuRWQgHdscNzd7tqt5xObeBxiHBX6?=
 =?us-ascii?Q?5vgSZa5XNrh3sgelY6uBu1Rl9nz2aNepp5Bj/mS8ICQ0f6OiMbBIeLVeRVmm?=
 =?us-ascii?Q?VHi7YX4GiAeaDqaFpt8hl0FP9djAZ0hxbWvZftvuMLbheSbhT3tAv7NcEgPh?=
 =?us-ascii?Q?xm8DrjSXVVFfIzsxrku1WdzfByz4gPv9mHU8h3C7CJDKr/pH+Ho+xrJxzs2U?=
 =?us-ascii?Q?d+5ofnR9GetUxX2WGqwIiVBhai7PacNJ1gB3Q6XseLC29Rk/t/eR8V9fmH71?=
 =?us-ascii?Q?uwoSjBXUDzmjUAvJzvyxvJBPV2Cta4GNqyV0V9Ee9o4tDiU93LPjoW1O120P?=
 =?us-ascii?Q?mGSzQ3IlpWk4Cw+haRC1C2h1ztya30f8KO4df8rb99s/Lr8j9ajErMg6le4J?=
 =?us-ascii?Q?4DmIM/bqtSaKzZEuwy0u+37fElABbDKbKTpp6sylDF9qqVeT3sXvW8+bF89b?=
 =?us-ascii?Q?9fyc4rq0GrChQB5CYiUFPsbNyubl6xMsQgMk8HBg6Q8kaPCs5N0rmfqqu6Hh?=
 =?us-ascii?Q?is+XqCit1X1E2q8VsER+kweBNDRhIKm39Z/mxjbA8xnqFa29y+ABFrlB70Gd?=
 =?us-ascii?Q?IIosatBiOzI7r7fzIMVAfM7dJCqgtspEJPDCqGXZZllOhqU/XOE0QgZD4oNw?=
 =?us-ascii?Q?G+84tHEpobeLvdJQxFSvfan+bo3uzAPqnEftyg8D33ALoBSfHoFCGTuTBC5+?=
 =?us-ascii?Q?hRkNWnkbty8peGtI4IOToEM2UJ63yTjpNx7FOq4d0yNDO13aRw6KgOBzYcCY?=
 =?us-ascii?Q?kPb0sNVf3XEHZL016l1tDfMNelCNbOzQVBXba+jM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6187.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3172065d-e0d6-4263-c464-08da710e8c77
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 03:00:52.6174
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bF1W0XyENTv69PRXzBOgjW9sFkcWDIduOrq97+jwaH7grBmfje/JCAUivxbGFrz+XW62WtzuUDN67dhiIGv7nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6051
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Sent: Wednesday, July 13, 2022 07:13
> To: Dave Hansen <dave.hansen@linux.intel.com>; Lutomirski, Andy
> <luto@kernel.org>; Peter Zijlstra <peterz@infradead.org>
> Cc: x86@kernel.org; Kostya Serebryany <kcc@google.com>; Andrey Ryabinin
> <ryabinin.a.a@gmail.com>; Andrey Konovalov <andreyknvl@gmail.com>;
> Alexander Potapenko <glider@google.com>; Taras Madan
> <tarasmadan@google.com>; Dmitry Vyukov <dvyukov@google.com>; H . J . Lu
> <hjl.tools@gmail.com>; Andi Kleen <ak@linux.intel.com>; Edgecombe, Rick P
> <rick.p.edgecombe@intel.com>; linux-mm@kvack.org; linux-
> kernel@vger.kernel.org; Kirill A. Shutemov <kirill.shutemov@linux.intel.c=
om>
> Subject: [PATCHv5 01/13] x86/mm: Fix CR3_ADDR_MASK
>=20
> The mask must not include bits above physical address mask. These bits ar=
e
> reserved and can be used for other things. Bits 61 and 62 are used for Li=
near
> Address Masking.
>=20
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> ---
>  arch/x86/include/asm/processor-flags.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/x86/include/asm/processor-flags.h
> b/arch/x86/include/asm/processor-flags.h
> index 02c2cbda4a74..a7f3d9100adb 100644
> --- a/arch/x86/include/asm/processor-flags.h
> +++ b/arch/x86/include/asm/processor-flags.h
> @@ -35,7 +35,7 @@
>   */
[Hu, Robert]=20
The comments above these #define's, explaining CR3 layout, can be updated o=
n
the new CR3 bits as well?

>  #ifdef CONFIG_X86_64
>  /* Mask off the address space ID and SME encryption bits. */
> -#define CR3_ADDR_MASK	__sme_clr(0x7FFFFFFFFFFFF000ull)
> +#define CR3_ADDR_MASK	__sme_clr(PHYSICAL_PAGE_MASK)
>  #define CR3_PCID_MASK	0xFFFull
>  #define CR3_NOFLUSH	BIT_ULL(63)
>=20
> --
> 2.35.1